From patchwork Thu Apr 11 15:01:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adolf Belka X-Patchwork-Id: 7732 Return-Path: Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4VFjZv1Kpdz3wyH for ; Thu, 11 Apr 2024 15:01:43 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4VFjZt4blSz5Vt; Thu, 11 Apr 2024 15:01:42 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4VFjZh0bmfz32qw; Thu, 11 Apr 2024 15:01:32 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4VFjZQ4hmLz30GW for ; Thu, 11 Apr 2024 15:01:18 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4VFjZQ3GmCz1Gx; Thu, 11 Apr 2024 15:01:18 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1712847678; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mr7PFkTxMUpRXPlekSrLA9vfjSfdgIOohWxkpiPLgx0=; b=4m8TOwSs29pP9KV+35cbxLRy7oZfQMY2Dn/crnWyqj9Yse1tHwzSBt25xgnZLTeOgdTiGv eZriRHPdIeiC4qDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1712847678; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mr7PFkTxMUpRXPlekSrLA9vfjSfdgIOohWxkpiPLgx0=; b=YEG6HniYgDM2yL6dVytg75oV2dFygbJ2ZE3Cp3CYrGcj6roDI0o796PB0WBuJIyPjtWnik sefLGtA3XaoX5YTQ1ahUe8c3A9XjL7aKhpcb7/OlEMov75DxFHymLLzVlm8D8RHsHw2ZpB 7P/RUXgA1TAz2xi/J1DjJyr+UR5YP6RFzq3VlZAHqZ+yWUk8htaIXehVAsl347g2YPTXRW v4FP1M5a7b7l84unahEoZMr9kLv8nsDo9khPQ4q/PeVurVyNxhjhW0cC6CHbfp1Q83qN+2 ybbpF8TVX/h8a+fsvUNH5usK1UfTmPlQVvpB2YI+d1EYx4Yul0NnqThvJZ1gzA== From: Adolf Belka To: development@lists.ipfire.org Subject: [PATCH 8/9] gcp-setup: Fixes bug12763 Date: Thu, 11 Apr 2024 17:01:07 +0200 Message-ID: <20240411150108.21573-8-adolf.belka@ipfire.org> In-Reply-To: <20240411150108.21573-1-adolf.belka@ipfire.org> References: <20240411150108.21573-1-adolf.belka@ipfire.org> MIME-Version: 1.0 Message-ID-Hash: IA6X46A3RJVVKUELFYHH5W4S5M4F2TG6 X-Message-ID-Hash: IA6X46A3RJVVKUELFYHH5W4S5M4F2TG6 X-MailFrom: adolf.belka@ipfire.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: IPFire development talk Archived-At: <> List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: - This ensures that all ip route and ip rule commands are redirected to null if the output is not used to feed into a variable. - This will prevent any error messages related to empty iproute tables being displayed during boot if an empty table is accessed. Fixes: Bug#12763 Tested-by: Adolf Belka Signed-off-by: Adolf Belka --- src/initscripts/helper/gcp-setup | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/initscripts/helper/gcp-setup b/src/initscripts/helper/gcp-setup index 4f5148c3e..8273b70b4 100644 --- a/src/initscripts/helper/gcp-setup +++ b/src/initscripts/helper/gcp-setup @@ -268,8 +268,8 @@ case "${reason}" in ip addr add "${new_ip_address}/${new_subnet_mask}" dev "${interface}" # Add the default route - ip route add "${new_routers}" dev "${interface}" - ip route add default via "${new_routers}" + ip route add "${new_routers}" dev "${interface}" >/dev/null 2>&1 + ip route add default via "${new_routers}" >/dev/null 2>&1 # Setup DNS for domain_name_server in ${new_domain_name_servers}; do