From patchwork Wed Mar 27 19:39:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Schantl X-Patchwork-Id: 7686 Return-Path: Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4V4cSV584Bz3wv4 for ; Wed, 27 Mar 2024 19:39:38 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4V4cSQ4CTgz2VY; Wed, 27 Mar 2024 19:39:34 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4V4cSP6pLmz32Lg; Wed, 27 Mar 2024 19:39:33 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4V4cSM3GmXz2yXQ for ; Wed, 27 Mar 2024 19:39:31 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4V4cSM0NhZz18H; Wed, 27 Mar 2024 19:39:30 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1711568371; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PebdlhCWpJY73rGPC9uWejCpcnNH8Yscbk0zd4B/fEQ=; b=eBjsZz1VXned6Mj11fdidnskvUoBGgkjd8rKlMqALIDHFGzuPY16ncM6xEaPN3lsNiwJLM FMKUPn9qqWOZA7Cg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1711568371; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PebdlhCWpJY73rGPC9uWejCpcnNH8Yscbk0zd4B/fEQ=; b=QLNMkzFD2DxJTthxrYik27878qBSFyZdmwCnnZ03Yp0cLWkTGsmt/w27vo2Kkh/MYiccQ8 NGm9xcmxaR7CXGOSdb1ctpNn2ItxKB48WmzF4AKNqx46b2FPyPJQsStzGUyg5MKG8k7Sz6 PMqdEOZK7RxZlk+WYkj1UccG6mwH3tKT3E0pkCn9tGE19SqR2Hbbnk01ml6k4Ut8VQj9hj 9YngI2vGpUBZ+KD+5ctrqBU2GkfbJ34OadY0FX9VDCP5vFY3xGqjLWaWM2LNrxYeYsKmWk dQS+O8EXz7HNzwu8Z5MrCs/ULuEAQtMwKn4xxirVdwpXN1TGMlC4KpRHcm7O9Q== From: Stefan Schantl To: development@lists.ipfire.org Subject: [PATCHv2 2/4] grub-btrfsd: Use generic volume_fs_type function for FS detection Date: Wed, 27 Mar 2024 20:39:18 +0100 Message-Id: <20240327193920.14311-2-stefan.schantl@ipfire.org> In-Reply-To: <20240327193920.14311-1-stefan.schantl@ipfire.org> References: <20240327193920.14311-1-stefan.schantl@ipfire.org> MIME-Version: 1.0 Message-ID-Hash: CVNUDR2MKYVVGFU7SVRE4HQA63RZUZUS X-Message-ID-Hash: CVNUDR2MKYVVGFU7SVRE4HQA63RZUZUS X-MailFrom: stefan.schantl@ipfire.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: IPFire development talk Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Signed-off-by: Stefan Schantl Reviewed-by: Michael Tremer --- src/initscripts/system/grub-btrfsd | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/src/initscripts/system/grub-btrfsd b/src/initscripts/system/grub-btrfsd index dc5e32ad4..90582b1b1 100644 --- a/src/initscripts/system/grub-btrfsd +++ b/src/initscripts/system/grub-btrfsd @@ -25,21 +25,18 @@ SNAPSHOTDIR="/.snapshots" PIDFILE="/run/grub-btrfsd.pid" -root_is_btrfs() { - [ "$(stat -f --format="%T" /)" == "btrfs" ] || return 1 - - return 0 -} - case "$1" in start) - root_is_btrfs || exit 0 + root_fs_type=$(volume_fs_type "/") - boot_mesg "Starting Grub/Btrfs snapshot manager..." - loadproc -b -p "$PIDFILE" /usr/bin/grub-btrfsd --syslog "$SNAPSHOTDIR" + case "$root_fs_type" in + btrfs) - # Store the gained PID to the defined pidfile - echo "$!" > "$PIDFILE" + boot_mesg "Starting Grub/Btrfs snapshot manager..." + loadproc -b -p "$PIDFILE" /usr/bin/grub-btrfsd --syslog "$SNAPSHOTDIR" + echo "$!" > "$PIDFILE" + ;; + esac ;; stop)