diff mbox series

shadow: Update login.defs to remove reference to cracklib

Message ID 20240325134138.20207-1-adolf.belka@ipfire.org
State Accepted
Commit 2e94953dd40134d05d3dd93c9c3e125f5ec427f9
Headers
Series shadow: Update login.defs to remove reference to cracklib |

Commit Message

Adolf Belka March 25, 2024, 1:41 p.m. UTC 
  - From shadow-15.0.0 all references to cracklib were removed from shadow. Apparently
   some functions were no longer accessible and the shadow team decided to remove cracklib
   references completely. This was not mentioned in the changelkog for 15.0.0
- This resulkts in gettinbg the message configuration error - unknown item
   'CRACKKLIB_DICTPATH' ( notify administrator ) when logging in to the console.
- The login to the console occurs successfully so the message is only a warning that
   cracklib is no longer used.
- IPfire does not use cracklkib anyway so this patch removes the section referring to
   cracklib from the login.defs configuration file.

Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
---
 config/shadow/login.defs | 5 -----
 1 file changed, 5 deletions(-)

Comments

Michael Tremer March 26, 2024, 10:32 a.m. UTC | #1 
Thank you. Merged :)

> On 25 Mar 2024, at 13:41, Adolf Belka <adolf.belka@ipfire.org> wrote:
> 
> - From shadow-15.0.0 all references to cracklib were removed from shadow. Apparently
>   some functions were no longer accessible and the shadow team decided to remove cracklib
>   references completely. This was not mentioned in the changelkog for 15.0.0
> - This resulkts in gettinbg the message configuration error - unknown item
>   'CRACKKLIB_DICTPATH' ( notify administrator ) when logging in to the console.
> - The login to the console occurs successfully so the message is only a warning that
>   cracklib is no longer used.
> - IPfire does not use cracklkib anyway so this patch removes the section referring to
>   cracklib from the login.defs configuration file.
> 
> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
> ---
> config/shadow/login.defs | 5 -----
> 1 file changed, 5 deletions(-)
> 
> diff --git a/config/shadow/login.defs b/config/shadow/login.defs
> index a9559d6c4..2662a62cc 100644
> --- a/config/shadow/login.defs
> +++ b/config/shadow/login.defs
> @@ -175,11 +175,6 @@ PASS_WARN_AGE 7
> #
> SU_WHEEL_ONLY no
> 
> -#
> -# If compiled with cracklib support, sets the path to the dictionaries
> -#
> -CRACKLIB_DICTPATH /var/cache/cracklib/cracklib_dict
> -
> #
> # Min/max values for automatic uid selection in useradd(8)
> #
> -- 
> 2.44.0
>
diff mbox series

Patch

diff --git a/config/shadow/login.defs b/config/shadow/login.defs
index a9559d6c4..2662a62cc 100644
--- a/config/shadow/login.defs
+++ b/config/shadow/login.defs
@@ -175,11 +175,6 @@  PASS_WARN_AGE	7
 #
 SU_WHEEL_ONLY	no
 
-#
-# If compiled with cracklib support, sets the path to the dictionaries
-#
-CRACKLIB_DICTPATH	/var/cache/cracklib/cracklib_dict
-
 #
 # Min/max values for automatic uid selection in useradd(8)
 #