From patchwork Tue Mar 5 18:44:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Adolf Belka X-Patchwork-Id: 7595 Return-Path: Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4Tq4H96kHyz3wvx for ; Tue, 5 Mar 2024 18:44:37 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4Tq4H24Q0xz1qX; Tue, 5 Mar 2024 18:44:30 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4Tq4H23x8gz32qB; Tue, 5 Mar 2024 18:44:30 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4Tq4Gw1kPzz32q5 for ; Tue, 5 Mar 2024 18:44:24 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4Tq4Gw0HDDzT1; Tue, 5 Mar 2024 18:44:24 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1709664264; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=efIAbuz5/UijneytlG5kGM23O9dorTOpgWndtuDREEc=; b=nkvpBUC1Dlc8ixBRco1M/Dt6kyNahpRRyh6OIW/5ZCOHVZGKfQQJla6wNggtWDZHu71UPA zae23aSUdsOreACA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1709664264; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=efIAbuz5/UijneytlG5kGM23O9dorTOpgWndtuDREEc=; b=bR0TP4L5ZelqtIVlZ6yTJqC/y7gH7e6kfGUhYFKZ1gkYnWiHmSqCbJnQFRWbqPMnIR5m1W TpLHpL7GoyPaIu1EmHmAV17kRIyCPMES8yDzB87CjFenHGbjE03XUjHuf6uwIREzaiFB8w EOmuFC/gv5GyzzKYqisS67bd6+JcvQ6P5rBMN7rWP6yas+Vedbclm+x22eSt01LCDEkn5j 9mbbwUf94UHHrVjhTA5xEPW8+mLbfOSJcqXuBgNKcwpkFl/oywc2RMErXUPVqdlLpJ+GG3 WKBAdMHBLlRgL/hJ0qxriLfVAErhU1Y8qyyT4m2kbC/vi5QN38Aq2latHddN+Q== From: Adolf Belka To: development@lists.ipfire.org Subject: [PATCH] vpnmain.cgi: Remove cleanhtml command from Remark Date: Tue, 5 Mar 2024 19:44:17 +0100 Message-ID: <20240305184418.3431741-5-adolf.belka@ipfire.org> In-Reply-To: <20240305184418.3431741-1-adolf.belka@ipfire.org> References: <20240305184418.3431741-1-adolf.belka@ipfire.org> MIME-Version: 1.0 Message-ID-Hash: NNIEPCTWHGYQCXPJ7TSAQBP65RQKREWY X-Message-ID-Hash: NNIEPCTWHGYQCXPJ7TSAQBP65RQKREWY X-MailFrom: adolf.belka@ipfire.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: IPFire development talk Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: - Using cleanhtml on Remarks means that all characters with diacritical marks such as umlauts or grave accents etc get encoded into other characters. - If Freifunk München e.V. is entered as a remark it gets converted to Freifunk München e.V. - cleanhtml is only removed from Remarks or Comment fields. In other places it has been left in place. Tested-by: Adolf Belka Signed-off-by: Adolf Belka --- html/cgi-bin/vpnmain.cgi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/html/cgi-bin/vpnmain.cgi b/html/cgi-bin/vpnmain.cgi index 9173a85d8..ceb0613a4 100644 --- a/html/cgi-bin/vpnmain.cgi +++ b/html/cgi-bin/vpnmain.cgi @@ -2,7 +2,7 @@ ############################################################################### # # # IPFire.org - A linux based firewall # -# Copyright (C) 2007-2022 IPFire Team # +# Copyright (C) 2007-2024 IPFire Team # # # # This program is free software: you can redistribute it and/or modify # # it under the terms of the GNU General Public License as published by # @@ -1724,7 +1724,6 @@ END } } elsif ($cgiparams{'ACTION'} eq $Lang::tr{'save'}) { - $cgiparams{'REMARK'} = &Header::cleanhtml($cgiparams{'REMARK'}); if ($cgiparams{'TYPE'} !~ /^(host|net)$/) { $errormessage = $Lang::tr{'connection type is invalid'}; goto VPNCONF_ERROR;