dnsforward.cgi: Remove cleanhtml command from Remark

Message ID 20240305184418.3431741-3-adolf.belka@ipfire.org
State Dropped
Headers
Series dnsforward.cgi: Remove cleanhtml command from Remark |

Commit Message

Adolf Belka March 5, 2024, 6:44 p.m. UTC
  - Using cleanhtml on Remarks means that all characters with diacritical marks such as
   umlauts or grave accents etc get encoded into other characters.
- If Freifunk München e.V. is entered as a remark it gets converted to
   Freifunk München e.V.
- cleanhtml is only removed from Remarks or Comment fields. In other places it has been
   left in place.

Tested-by: Adolf Belka <adolf.belka@ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
---
 html/cgi-bin/dnsforward.cgi | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
  

Patch

diff --git a/html/cgi-bin/dnsforward.cgi b/html/cgi-bin/dnsforward.cgi
index 4af5ed200..42f124766 100644
--- a/html/cgi-bin/dnsforward.cgi
+++ b/html/cgi-bin/dnsforward.cgi
@@ -2,7 +2,7 @@ 
 ###############################################################################
 #                                                                             #
 # IPFire.org - A linux based firewall                                         #
-# Copyright (C) 2013  IPFire Development Team                                 #
+# Copyright (C) 2013-2024  IPFire Team  <info@ipfire.org>                     #
 #                                                                             #
 # This program is free software: you can redistribute it and/or modify        #
 # it under the terms of the GNU General Public License as published by        #
@@ -87,9 +87,6 @@  if ($cgiparams{'ACTION'} eq $Lang::tr{'add'})
 		# Save servers separated by |
 		$cgiparams{'FORWARD_SERVERS'} = join("|", @forward_servers);
 
-	    # Check if a remark has been entered.
-	    $cgiparams{'REMARK'} = &Header::cleanhtml($cgiparams{'REMARK'});
-
 		# Set to off if not enabled
 		if (!$cgiparams{'DISABLE_DNSSEC'}) {
 			$cgiparams{'DISABLE_DNSSEC'} = "off";