diff mbox series

[1/2] ovpnmain.cgi: Fixes bug#13548 - imported N2N client connections get disabled instead of no-pass

Message ID 20240222124339.9847-1-adolf.belka@ipfire.org
State Staged
Commit 4a0648243b991b00130aca4fcc615e717ddb1003
Headers
Series [1/2] ovpnmain.cgi: Fixes bug#13548 - imported N2N client connections get disabled instead of no-pass |

Commit Message

Adolf Belka Feb. 22, 2024, 12:43 p.m. UTC 
  - When bug#11408 was fixed it was missed that key 41 has disabled inserted into it when
   uploading into the N2N client. This replaced the no-pass entry for all N2N connections
   resulting in the ovpnmain.cgi not being able to show the status correctly as the code
   looks for pass or no-pass.
- The disabled entry has been present for a very long time and is not utilised anywhere
   in the code.
- This fix ensures that key 41 in the uploaded N2N connection has no-pass entered
- Tested out and confirmed in my vm testbed.

Fixes: Bug#13548
Tested-by: Adolf Belka <adolf.belka@ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
---
 html/cgi-bin/ovpnmain.cgi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
index eb89c5095..b773bc4b7 100755
--- a/html/cgi-bin/ovpnmain.cgi
+++ b/html/cgi-bin/ovpnmain.cgi
@@ -3472,7 +3472,7 @@  foreach my $dkey (keys %confighash) {
 	$confighash{$key}[31] = $n2ntunmtu[1];
 	$confighash{$key}[39] = $n2nauth[1];
 	$confighash{$key}[40] = $n2ncipher[1];
-	$confighash{$key}[41] = 'disabled';
+	$confighash{$key}[41] = 'no-pass';
 
   &General::writehasharray("${General::swroot}/ovpn/ovpnconfig", \%confighash);