From patchwork Fri Aug 18 18:46:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adolf Belka X-Patchwork-Id: 7105 Return-Path: Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature ECDSA (secp384r1) client-digest SHA384) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4RS9p51YWHz3wtG for ; Fri, 18 Aug 2023 18:46:53 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature ECDSA (secp384r1) client-digest SHA384) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4RS9p34rBxz1Pc; Fri, 18 Aug 2023 18:46:51 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4RS9p33lfVz2ySn; Fri, 18 Aug 2023 18:46:51 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4RS9p23x6jz2y9y for ; Fri, 18 Aug 2023 18:46:50 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4RS9p15pSczN6; Fri, 18 Aug 2023 18:46:49 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1692384409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=MhTSnLDsU4grDBXVXjw6HdckI9WzZLxD8OfsArpBIrU=; b=2LdixlWYb5TTaVt9hHIkv/Arju1OSDWPnnEmPsuVe2PpE2IXwbk7EsP8LiOU7hiVRrFH6d +ewn+6mK2MyOmqCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1692384409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=MhTSnLDsU4grDBXVXjw6HdckI9WzZLxD8OfsArpBIrU=; b=m00QKhAD5jELYm8ww/9dnvoINzd7LyZvGYxpFlLNX5Qc2xzsdupzMN2vq+luC+tK6orIG9 9D6J8HN9LQJkaQGneQZu+ir7BF3nJXGHjYxNNJ9PCCNPoG2D03SbgIdCqwC6ePNP5yd8kz d8ZhHgf7m1LVkVDQACP3hUU8QapioGBG1InrPr+4QkBUHLS7np5a6gfoRRmQKdZO9yxGUI pA+Io65pWutWWQXgsscvtAqj0WjGCV+WI3zAG6GFgnwIcxiGiDMYV7v75+7fMefO1B8rgx XZ6ZM67KCwzQAuzNPjHaGJ2gyqyGm27Z0Nu2axaV2DuNVqhqFnKi+yWA0bmiSA== From: Adolf Belka To: development@lists.ipfire.org Subject: [PATCH] ppp: Bug#13164 - Update configure options to have correct directory for pid Date: Fri, 18 Aug 2023 20:46:45 +0200 Message-ID: <20230818184645.3934968-1-adolf.belka@ipfire.org> MIME-Version: 1.0 X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: IPFire development talk List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: development-bounces@lists.ipfire.org Sender: "Development" - The original poster of the bug#13164 has already tested out ppp-2.5.0 in CU179 (master) and identified that the startup could not find the directory /usr/var/run/. This is due to the change in use of the prefix command in 2.5.0 vs 2.4.9 so --localstatedir set to /var. runstatedir is then set to localstatedir/run ie /var/run which is then correct for IPFire. - This fix needs to be implemented into CU179 so that the bug poster can test out the update - Updated rootfile to remove additional empty line Fixes: Bug#13164 Signed-off-by: Adolf Belka --- config/rootfiles/common/ppp | 1 - lfs/ppp | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/config/rootfiles/common/ppp b/config/rootfiles/common/ppp index 6098fa7c3..379c64af4 100644 --- a/config/rootfiles/common/ppp +++ b/config/rootfiles/common/ppp @@ -71,4 +71,3 @@ usr/sbin/pppstats #usr/share/man/man8/pppoe-discovery.8 #usr/share/man/man8/pppstats.8 var/log/connect-errors - diff --git a/lfs/ppp b/lfs/ppp index fc4528ece..a6bd633b4 100644 --- a/lfs/ppp +++ b/lfs/ppp @@ -82,6 +82,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) --prefix=/usr \ --sysconfdir=/etc \ --with-logfile-dir=/var/log \ + --localstatedir=/var \ cc="gcc" \ cflags="$(CFLAGS)" cd $(DIR_APP) && make $(MAKETUNING)