diff mbox series

[2/3] mountfs: Remove excessive sync-ing before umount

Message ID 20230815101936.261078-2-michael.tremer@ipfire.org
State Staged
Commit d4a8484eb1805696b9147ef7cc873776d76f0c4e
Headers
Series [1/3] mountfs: Mount ExtraHD filesystems |

Commit Message

Michael Tremer Aug. 15, 2023, 10:19 a.m. UTC 
  The system should perform all write operations when sync is called and
only return when the write queues are empty.

There is no additional benefit for calling sync again as the buffers
should be empty. If data is still being lost, then that is a bug in
either the storage device or driver.

As the (re-)boot process is already so slow, I would like to get rid of
any unnecessary delays.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---
 src/initscripts/system/mountfs | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/src/initscripts/system/mountfs b/src/initscripts/system/mountfs
index 2e2ff0b5b..8975eb02c 100644
--- a/src/initscripts/system/mountfs
+++ b/src/initscripts/system/mountfs
@@ -45,9 +45,7 @@  case "${1}" in
 
 	stop)
 		boot_mesg "Syncing discs..."
-		sync && sync
-		sleep 2
-		sync && sync
+		sync
 		evaluate_retval
 
 		# ExtraHD