samba.cgi: Fixes bug#13193 - disables smb1 unix extensions in smb.conf

Message ID 20230726210359.24473-1-adolf.belka@ipfire.org
State Staged
Commit cee7ddb66c22bfdd7a0dce18617f64b34d7794e7
Headers
Series samba.cgi: Fixes bug#13193 - disables smb1 unix extensions in smb.conf |

Commit Message

Adolf Belka July 26, 2023, 9:03 p.m. UTC
  - Around three years ago the samba wui page was simplified and several parts were removed
   including the ability to set either wide links or unix extensions to be enabled
- When the above was done wide links = yes was defined in the samba.cgi code
- unix extenstions was not defined and therefore took the default value which was/is yes
- unix extensions is now called smb1 unix extensions and has the same default value of yes
- With both wide links = yes and smb1 unix extensions = yes means that when there is a
  wide symlink (one that goes outside the share directory tree) then wide links is disabled
  because smb1 unix extensions is enabled. This is even though the smb1 protocol is disabled
  by default.
- This patch sets smb1 unix extensions = no in the configuration.
- This has been tested in my vm testbed and confirmed that the error message is no longer
   shown and that any wide links are able to be accessed from the share mounted on a client

Fixes: Bug#13193
Tested-by: Adolf Belka <adolf.belka@ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
---
 html/cgi-bin/samba.cgi | 3 +++
 1 file changed, 3 insertions(+)
  

Patch

diff --git a/html/cgi-bin/samba.cgi b/html/cgi-bin/samba.cgi
index 0a3cd8c04..c60dca1d4 100644
--- a/html/cgi-bin/samba.cgi
+++ b/html/cgi-bin/samba.cgi
@@ -810,6 +810,9 @@  vfs objects = catia fruit streams_xattr recycle
 # Enable following symlinks
 wide links = yes
 
+# Disable smb1 unix extensions
+smb1 unix extensions = no
+
 END
 
 # Server Role