| Message ID | 20230704090446.3452010-1-adolf.belka@ipfire.org |
|---|---|
| State | Accepted |
| Commit | 0803c50f76e0b43f91ee6b6b3863684ad4cfa073 |
| Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4QwH1L3z1Wz3wm3 for <patchwork@web04.haj.ipfire.org>; Tue, 4 Jul 2023 09:04:54 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4QwH1K497dz1Kk; Tue, 4 Jul 2023 09:04:53 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4QwH1K2h6Bz2yJ8; Tue, 4 Jul 2023 09:04:53 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4QwH1H2Wqkz2yBg for <development@lists.ipfire.org>; Tue, 4 Jul 2023 09:04:51 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4QwH1G1hVxzsQ; Tue, 4 Jul 2023 09:04:50 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1688461490; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=pgNyXHtjjjpHtfpD7LL0r/W2w8qeJdHTyYcLEjnMjUk=; b=StQxSTHgTMG59tphKoLJVJws8Axv8yVhah7qz7Pvhv4dJ4KkSJ10mhHXrcEHA4kHUmbrBp Af3vx7MXFCIrztCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1688461490; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=pgNyXHtjjjpHtfpD7LL0r/W2w8qeJdHTyYcLEjnMjUk=; b=GDGO0RhIwcNFFFBz07uudi9YqVHKKWaKY2r/nGZVcOoHx+5vWllRvB9mnrEqq4mZzAXCLk VNICHVgTE3IRMCKYrgGkzoFfMvc9nIIs04rlr0XuROznuTS3PyiYeC6GOkzG8vSRwz3IL1 MlFtzjSMd3nxPWQAvTC8uBknIUa6/06+8P9X91jgvIhrmYyKIOgBepDddnFXUn6H1RENQN lshkAEEE94gzdfYJYSu4RT4KJwU+XEbgUNZ1cYM0eJdecyDYrmX334RuckxIyLWLPug9l8 xoeHKPek/c2B0xn3rgi7E67qp0vRk0JzPY3byPlARWd3jAwz0uBhiEW1m1AWTA== From: Adolf Belka <adolf.belka@ipfire.org> To: development@lists.ipfire.org Subject: [PATCH] red: Fixes bug#13164 adjust pppoe plugin name in red initscript Date: Tue, 4 Jul 2023 11:04:46 +0200 Message-ID: <20230704090446.3452010-1-adolf.belka@ipfire.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> List-Unsubscribe: <https://lists.ipfire.org/mailman/options/development>, <mailto:development-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/development/> List-Post: <mailto:development@lists.ipfire.org> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Subscribe: <https://lists.ipfire.org/mailman/listinfo/development>, <mailto:development-request@lists.ipfire.org?subject=subscribe> Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org> |
| Series |
red: Fixes bug#13164 adjust pppoe plugin name in red initscript
|
|
Commit Message
Adolf Belka
July 4, 2023, 9:04 a.m. UTC
- This patch goes together with the patch for the ppp update to 2.5.0
- The rp-pppoe.so option is no longer available. There is only the pppoe.so available now
Fixes: Bug#13164
Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
---
src/initscripts/networking/red | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Thanks. This looks good to me. Reviewed-by: Michael Tremer <michael.tremer@ipfire.org> > On 4 Jul 2023, at 10:04, Adolf Belka <adolf.belka@ipfire.org> wrote: > > - This patch goes together with the patch for the ppp update to 2.5.0 > - The rp-pppoe.so option is no longer available. There is only the pppoe.so available now > > Fixes: Bug#13164 > Signed-off-by: Adolf Belka <adolf.belka@ipfire.org> > --- > src/initscripts/networking/red | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/initscripts/networking/red b/src/initscripts/networking/red > index 16d48f3ac..75a17bd5a 100644 > --- a/src/initscripts/networking/red > +++ b/src/initscripts/networking/red > @@ -365,7 +365,7 @@ case "${1}" in > # > if [ "$TYPE" == "pppoe" ]; then > [ "${METHOD}" == "PPPOE_PLUGIN" ] && \ > - PLUGOPTS="plugin rp-pppoe.so" > + PLUGOPTS="plugin pppoe.so" > fi > > ### Synchronous Mode > -- > 2.41.0 >
So next thing is to see if this updated version works for Peter and Arne or if I have more work to do. :-) Regards, Adolf. On 04/07/2023 11:08, Michael Tremer wrote: > Thanks. This looks good to me. > > Reviewed-by: Michael Tremer <michael.tremer@ipfire.org> > >> On 4 Jul 2023, at 10:04, Adolf Belka <adolf.belka@ipfire.org> wrote: >> >> - This patch goes together with the patch for the ppp update to 2.5.0 >> - The rp-pppoe.so option is no longer available. There is only the pppoe.so available now >> >> Fixes: Bug#13164 >> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org> >> --- >> src/initscripts/networking/red | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/initscripts/networking/red b/src/initscripts/networking/red >> index 16d48f3ac..75a17bd5a 100644 >> --- a/src/initscripts/networking/red >> +++ b/src/initscripts/networking/red >> @@ -365,7 +365,7 @@ case "${1}" in >> # >> if [ "$TYPE" == "pppoe" ]; then >> [ "${METHOD}" == "PPPOE_PLUGIN" ] && \ >> - PLUGOPTS="plugin rp-pppoe.so" >> + PLUGOPTS="plugin pppoe.so" >> fi >> >> ### Synchronous Mode >> -- >> 2.41.0 >> >
Hi All, On 04/07/2023 14:52, Adolf Belka wrote: > So next thing is to see if this updated version works for Peter and > Arne or if I have more work to do. :-) > At the last video conf call Peter and Arne mentioned that they are able to test a pppoe connection with the ppp version update patch I submitted at the beginning of July. https://lists.ipfire.org/pipermail/development/2023-July/016101.html Any progress on the testing. Just let me know if there are any issues that I need to work on. Regards, Adolf. > Regards, > Adolf. > > On 04/07/2023 11:08, Michael Tremer wrote: >> Thanks. This looks good to me. >> >> Reviewed-by: Michael Tremer <michael.tremer@ipfire.org> >> >>> On 4 Jul 2023, at 10:04, Adolf Belka <adolf.belka@ipfire.org> wrote: >>> >>> - This patch goes together with the patch for the ppp update to 2.5.0 >>> - The rp-pppoe.so option is no longer available. There is only the >>> pppoe.so available now >>> >>> Fixes: Bug#13164 >>> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org> >>> --- >>> src/initscripts/networking/red | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/src/initscripts/networking/red >>> b/src/initscripts/networking/red >>> index 16d48f3ac..75a17bd5a 100644 >>> --- a/src/initscripts/networking/red >>> +++ b/src/initscripts/networking/red >>> @@ -365,7 +365,7 @@ case "${1}" in >>> # >>> if [ "$TYPE" == "pppoe" ]; then >>> [ "${METHOD}" == "PPPOE_PLUGIN" ] && \ >>> - PLUGOPTS="plugin rp-pppoe.so" >>> + PLUGOPTS="plugin pppoe.so" >>> fi >>> >>> ### Synchronous Mode >>> -- >>> 2.41.0 >>> >>
Hello Adolf, As the update has been released, I would say this counts as the testing being done. -Michael > On 2 Aug 2023, at 16:14, Adolf Belka <adolf.belka@ipfire.org> wrote: > > Hi All, > > On 04/07/2023 14:52, Adolf Belka wrote: >> So next thing is to see if this updated version works for Peter and Arne or if I have more work to do. :-) >> > At the last video conf call Peter and Arne mentioned that they are able to test a pppoe connection with the ppp version update patch I submitted at the beginning of July. > > https://lists.ipfire.org/pipermail/development/2023-July/016101.html > > Any progress on the testing. Just let me know if there are any issues that I need to work on. > > Regards, > Adolf. > >> Regards, >> Adolf. >> >> On 04/07/2023 11:08, Michael Tremer wrote: >>> Thanks. This looks good to me. >>> >>> Reviewed-by: Michael Tremer <michael.tremer@ipfire.org> >>> >>>> On 4 Jul 2023, at 10:04, Adolf Belka <adolf.belka@ipfire.org> wrote: >>>> >>>> - This patch goes together with the patch for the ppp update to 2.5.0 >>>> - The rp-pppoe.so option is no longer available. There is only the pppoe.so available now >>>> >>>> Fixes: Bug#13164 >>>> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org> >>>> --- >>>> src/initscripts/networking/red | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/src/initscripts/networking/red b/src/initscripts/networking/red >>>> index 16d48f3ac..75a17bd5a 100644 >>>> --- a/src/initscripts/networking/red >>>> +++ b/src/initscripts/networking/red >>>> @@ -365,7 +365,7 @@ case "${1}" in >>>> # >>>> if [ "$TYPE" == "pppoe" ]; then >>>> [ "${METHOD}" == "PPPOE_PLUGIN" ] && \ >>>> - PLUGOPTS="plugin rp-pppoe.so" >>>> + PLUGOPTS="plugin pppoe.so" >>>> fi >>>> >>>> ### Synchronous Mode >>>> -- >>>> 2.41.0 >>>> >>> > > -- > Sent from my laptop
Hi Michael, On 07/08/2023 11:30, Michael Tremer wrote: > Hello Adolf, > > As the update has been released, I would say this counts as the testing being done. Neither this change to the red initscript nor the change of ppp version from 2.4.9 to 2.5.0 have been merged into CU177 or into next. The last video call feedback was that the change of ppp from 2.4.9 to 2.5.0 was significant enough that we had to be careful because it could cause people to fail to have a connection. So the decision was that it would be tested within the devs first before releasing it into a Testing release. Regards, Adolf. > > -Michael > >> On 2 Aug 2023, at 16:14, Adolf Belka <adolf.belka@ipfire.org> wrote: >> >> Hi All, >> >> On 04/07/2023 14:52, Adolf Belka wrote: >>> So next thing is to see if this updated version works for Peter and Arne or if I have more work to do. :-) >>> >> At the last video conf call Peter and Arne mentioned that they are able to test a pppoe connection with the ppp version update patch I submitted at the beginning of July. >> >> https://lists.ipfire.org/pipermail/development/2023-July/016101.html >> >> Any progress on the testing. Just let me know if there are any issues that I need to work on. >> >> Regards, >> Adolf. >> >>> Regards, >>> Adolf. >>> >>> On 04/07/2023 11:08, Michael Tremer wrote: >>>> Thanks. This looks good to me. >>>> >>>> Reviewed-by: Michael Tremer <michael.tremer@ipfire.org> >>>> >>>>> On 4 Jul 2023, at 10:04, Adolf Belka <adolf.belka@ipfire.org> wrote: >>>>> >>>>> - This patch goes together with the patch for the ppp update to 2.5.0 >>>>> - The rp-pppoe.so option is no longer available. There is only the pppoe.so available now >>>>> >>>>> Fixes: Bug#13164 >>>>> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org> >>>>> --- >>>>> src/initscripts/networking/red | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/src/initscripts/networking/red b/src/initscripts/networking/red >>>>> index 16d48f3ac..75a17bd5a 100644 >>>>> --- a/src/initscripts/networking/red >>>>> +++ b/src/initscripts/networking/red >>>>> @@ -365,7 +365,7 @@ case "${1}" in >>>>> # >>>>> if [ "$TYPE" == "pppoe" ]; then >>>>> [ "${METHOD}" == "PPPOE_PLUGIN" ] && \ >>>>> - PLUGOPTS="plugin rp-pppoe.so" >>>>> + PLUGOPTS="plugin pppoe.so" >>>>> fi >>>>> >>>>> ### Synchronous Mode >>>>> -- >>>>> 2.41.0 >>>>> >>>> >> >> -- >> Sent from my laptop > >
Ah, that is not good then. Where did those patches go? I will dig them up and merge them into the next update. -Michael > On 7 Aug 2023, at 12:48, Adolf Belka <adolf.belka@ipfire.org> wrote: > > Hi Michael, > > On 07/08/2023 11:30, Michael Tremer wrote: >> Hello Adolf, >> As the update has been released, I would say this counts as the testing being done. > Neither this change to the red initscript nor the change of ppp version from 2.4.9 to 2.5.0 have been merged into CU177 or into next. > > The last video call feedback was that the change of ppp from 2.4.9 to 2.5.0 was significant enough that we had to be careful because it could cause people to fail to have a connection. > So the decision was that it would be tested within the devs first before releasing it into a Testing release. > > Regards, > > Adolf. >> -Michael >>> On 2 Aug 2023, at 16:14, Adolf Belka <adolf.belka@ipfire.org> wrote: >>> >>> Hi All, >>> >>> On 04/07/2023 14:52, Adolf Belka wrote: >>>> So next thing is to see if this updated version works for Peter and Arne or if I have more work to do. :-) >>>> >>> At the last video conf call Peter and Arne mentioned that they are able to test a pppoe connection with the ppp version update patch I submitted at the beginning of July. >>> >>> https://lists.ipfire.org/pipermail/development/2023-July/016101.html >>> >>> Any progress on the testing. Just let me know if there are any issues that I need to work on. >>> >>> Regards, >>> Adolf. >>> >>>> Regards, >>>> Adolf. >>>> >>>> On 04/07/2023 11:08, Michael Tremer wrote: >>>>> Thanks. This looks good to me. >>>>> >>>>> Reviewed-by: Michael Tremer <michael.tremer@ipfire.org> >>>>> >>>>>> On 4 Jul 2023, at 10:04, Adolf Belka <adolf.belka@ipfire.org> wrote: >>>>>> >>>>>> - This patch goes together with the patch for the ppp update to 2.5.0 >>>>>> - The rp-pppoe.so option is no longer available. There is only the pppoe.so available now >>>>>> >>>>>> Fixes: Bug#13164 >>>>>> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org> >>>>>> --- >>>>>> src/initscripts/networking/red | 2 +- >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/src/initscripts/networking/red b/src/initscripts/networking/red >>>>>> index 16d48f3ac..75a17bd5a 100644 >>>>>> --- a/src/initscripts/networking/red >>>>>> +++ b/src/initscripts/networking/red >>>>>> @@ -365,7 +365,7 @@ case "${1}" in >>>>>> # >>>>>> if [ "$TYPE" == "pppoe" ]; then >>>>>> [ "${METHOD}" == "PPPOE_PLUGIN" ] && \ >>>>>> - PLUGOPTS="plugin rp-pppoe.so" >>>>>> + PLUGOPTS="plugin pppoe.so" >>>>>> fi >>>>>> >>>>>> ### Synchronous Mode >>>>>> -- >>>>>> 2.41.0 >>>>>> >>>>> >>> >>> -- >>> Sent from my laptop > > -- > Sent from my laptop
diff --git a/src/initscripts/networking/red b/src/initscripts/networking/red index 16d48f3ac..75a17bd5a 100644 --- a/src/initscripts/networking/red +++ b/src/initscripts/networking/red @@ -365,7 +365,7 @@ case "${1}" in # if [ "$TYPE" == "pppoe" ]; then [ "${METHOD}" == "PPPOE_PLUGIN" ] && \ - PLUGOPTS="plugin rp-pppoe.so" + PLUGOPTS="plugin pppoe.so" fi ### Synchronous Mode