Message ID | 20230523172314.7826-8-jonatan.schlag@ipfire.org |
---|---|
State | Changes Requested |
Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4QQh4b3hHFz3wls for <patchwork@web04.haj.ipfire.org>; Tue, 23 May 2023 17:23:59 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4QQh4Z4Rdmz1CX; Tue, 23 May 2023 17:23:58 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4QQh4Z3NTJz30Kv; Tue, 23 May 2023 17:23:58 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4QQh4X5PT8z2ySG for <development@lists.ipfire.org>; Tue, 23 May 2023 17:23:56 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4QQh4X3Dykz9V2; Tue, 23 May 2023 17:23:56 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1684862636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5SdfioiWDLlJ2+7zHo1ZWtJCDq+a5xpYdiiP08M27d4=; b=IrW00QYjy07OO/4EjjOD15I5VmS4GUm49bGd7n6Y7+rA4RCl48Z105QevIeEuhqAH9VyyC PS+Rb1ItFjn/ZODA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1684862636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5SdfioiWDLlJ2+7zHo1ZWtJCDq+a5xpYdiiP08M27d4=; b=c2zaWMc++27q+dfu76WvbBU8XORDQmiOTliGDyv888ldfY8srmbrwsJ6g3myWonagDqr9m duUgdWe31KePn6y4LLK2Swhtg/P7qggR9rgu4WdaVd1EUJem0kd/v6gklCJzvWKl0D5z7c cIvksZ5P8ZMCHfOk3rhJDnuHviavlRDsEUGCfFR1FYX3z8UFQQcnyzLG/wX1120Mf0bKgi isR8K/602chPhNxDDyp0RUjHMvYnEfYl48MdvBB8Oid7YX5GMnhT4IjYY5Tj+FA6qWIqTN ssaS+0sy0bJT0EJ2VSy47O98P8Yi4rwv4A5aY/Bc2Xmvb5qG9CcWtH/SCe/FfQ== From: Jonatan Schlag <jonatan.schlag@ipfire.org> To: development@lists.ipfire.org Subject: [Patch RFC 07/15] network startup: Reload routing informations for every interface Date: Tue, 23 May 2023 19:23:07 +0200 Message-Id: <20230523172314.7826-8-jonatan.schlag@ipfire.org> In-Reply-To: <20230523172314.7826-1-jonatan.schlag@ipfire.org> References: <20230523172314.7826-1-jonatan.schlag@ipfire.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> List-Unsubscribe: <https://lists.ipfire.org/mailman/options/development>, <mailto:development-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/development/> List-Post: <mailto:development@lists.ipfire.org> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Subscribe: <https://lists.ipfire.org/mailman/listinfo/development>, <mailto:development-request@lists.ipfire.org?subject=subscribe> Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org> |
Series |
[RFC,01/15] Remove ipsec interface creation from network startup
|
|
Commit Message
Jonatan Schlag
May 23, 2023, 5:23 p.m. UTC
This reload can and needs to be done when an interface is started. Not only
when all interfaces are started.
Signed-off-by: Jonatan Schlag <jonatan.schlag@ipfire.org>
---
src/initscripts/networking/any | 2 ++
src/initscripts/system/network | 2 --
2 files changed, 2 insertions(+), 2 deletions(-)
Comments
This assumption is incorrect. You could have a route that points somewhere else if a certain interface is not available (e.g. VPNs). This is probably bad network design, but I suppose that we did support this before. > On 23 May 2023, at 18:23, Jonatan Schlag <jonatan.schlag@ipfire.org> wrote: > > This reload can and needs to be done when an interface is started. Not only > when all interfaces are started. > > Signed-off-by: Jonatan Schlag <jonatan.schlag@ipfire.org> > --- > src/initscripts/networking/any | 2 ++ > src/initscripts/system/network | 2 -- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/initscripts/networking/any b/src/initscripts/networking/any > index 6dba5bef9..ec1321ad9 100644 > --- a/src/initscripts/networking/any > +++ b/src/initscripts/networking/any > @@ -109,6 +109,8 @@ case "${1}" in > ip addr add ${args} dev ${DEVICE} > evaluate_retval > fi > + > + /etc/rc.d/init.d/static-routes reload > ;; > > stop) > diff --git a/src/initscripts/system/network b/src/initscripts/system/network > index 6a47456f3..b346d487c 100644 > --- a/src/initscripts/system/network > +++ b/src/initscripts/system/network > @@ -66,8 +66,6 @@ case "${DO}" in > /etc/rc.d/init.d/networking/red start > fi > > - /etc/rc.d/init.d/static-routes start > - > boot_mesg "Mounting network file systems..." > mount -a -O _netdev > evaluate_retval > -- > 2.30.2 >
diff --git a/src/initscripts/networking/any b/src/initscripts/networking/any index 6dba5bef9..ec1321ad9 100644 --- a/src/initscripts/networking/any +++ b/src/initscripts/networking/any @@ -109,6 +109,8 @@ case "${1}" in ip addr add ${args} dev ${DEVICE} evaluate_retval fi + + /etc/rc.d/init.d/static-routes reload ;; stop) diff --git a/src/initscripts/system/network b/src/initscripts/system/network index 6a47456f3..b346d487c 100644 --- a/src/initscripts/system/network +++ b/src/initscripts/system/network @@ -66,8 +66,6 @@ case "${DO}" in /etc/rc.d/init.d/networking/red start fi - /etc/rc.d/init.d/static-routes start - boot_mesg "Mounting network file systems..." mount -a -O _netdev evaluate_retval