diff mbox series

rules.pl: Proposed patch - Fix for missing bracket

Message ID 20230312132800.1625540-1-matthias.fischer@ipfire.org
State Accepted
Commit ab5b17a98ebb53cc0dfe74ed360a9f444cd057ef
Headers
Series rules.pl: Proposed patch - Fix for missing bracket |

Commit Message

Matthias Fischer March 12, 2023, 1:28 p.m. UTC 
  Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org>
---
 config/firewall/rules.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bernhard Bitsch March 12, 2023, 5:19 p.m. UTC | #1 
Good find. ;)

Reviewed-by: Bernhard Bitsch <bbitsch@ipfire.org>

Am 12.03.2023 um 14:28 schrieb Matthias Fischer:
> Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org>
> ---
>   config/firewall/rules.pl | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/config/firewall/rules.pl b/config/firewall/rules.pl
> index 80985ca53..6c08feb86 100644
> --- a/config/firewall/rules.pl
> +++ b/config/firewall/rules.pl
> @@ -761,7 +761,7 @@ sub ipblocklist () {
>   			}
>   
>   			# Check if logging is enabled.
> -			if($blocklistsettings{'LOGGING'}) && ($blocklistsettings{'LOGGING'} eq "on")) {
> +			if(($blocklistsettings{'LOGGING'}) && ($blocklistsettings{'LOGGING'} eq "on")) {
>   				# Create logging rule.
>   				run("$IPTABLES -A ${blocklist}_DROP -j LOG -m limit --limit 10/second --log-prefix \"BLKLST_$blocklist \"");
>   			}
diff mbox series

Patch

diff --git a/config/firewall/rules.pl b/config/firewall/rules.pl
index 80985ca53..6c08feb86 100644
--- a/config/firewall/rules.pl
+++ b/config/firewall/rules.pl
@@ -761,7 +761,7 @@  sub ipblocklist () {
 			}
 
 			# Check if logging is enabled.
-			if($blocklistsettings{'LOGGING'}) && ($blocklistsettings{'LOGGING'} eq "on")) {
+			if(($blocklistsettings{'LOGGING'}) && ($blocklistsettings{'LOGGING'} eq "on")) {
 				# Create logging rule.
 				run("$IPTABLES -A ${blocklist}_DROP -j LOG -m limit --limit 10/second --log-prefix \"BLKLST_$blocklist \"");
 			}