wio.cgi: Fixes bug#13039 - Input boxes extend outside of WUI boundary with some browsers

Message ID 20230221125011.3658-1-adolf.belka@ipfire.org
State Accepted
Commit 0407daeeb628ef4d415fb94e370c494fba627608
Series wio.cgi: Fixes bug#13039 - Input boxes extend outside of WUI boundary with some browsers |

Commit Message

Adolf Belka Feb. 21, 2023, 12:50 p.m. UTC
  - Original poster found this effect with using Vivaldi at 100% zoom.
- I tested it with Vivaldi and Firefox on Arch Linux and was not able to show the effect but
   running SeaMonkey and changing the zoom from 100% to lower or higher caused the input
   boxes to go outside of the WUI boundary as described by the bug reporter.
- It looks like the effect is dependent on the browser, the zoom setting and the OS
- In all cases the similar three input boxes in a row in the dhcp.cgi code for entering a
   fixed lease stayed fixed in ratrio to the WUI page whatever zoom or browser was used.
- This patch changes the wio code for those three input boxes to use the approach from the
   dhcp.cgi code.
- Tested on my vm testbed and change confirmed to fix the size of the input boxes
   irrespective of the browser or zoom setting.

Fixes: Bug#13039
Tested-by: Adolf Belka <adolf.belka@ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
 src/wio/wio.cgi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)


diff --git a/src/wio/wio.cgi b/src/wio/wio.cgi
index a61102894..f31f5d565 100644
--- a/src/wio/wio.cgi
+++ b/src/wio/wio.cgi
@@ -1761,12 +1761,12 @@  print"
 	<td colspan='4'>&nbsp;</td>
-	<td height='30'>$Lang::tr{'wio ipadress'}:</td>
-	<td align='left'><input type='text' name='IPADR' value='$wiosettings{'IPADR'}' size='25' /></td>
-	<td>$Lang::tr{'wio name'}:</td>
-	<td align='left'><input type='text' name='HOST' value='$wiosettings{'HOST'}' size='25' /></td>
-	<td>$Lang::tr{'remark'}:</td>
-	<td align='left'><input type='text' name='REMARK' value='$wiosettings{'REMARK'}' size='30'></td>
+	<td class='base'>$Lang::tr{'wio ipadress'}:</td>
+	<td><input type='text' name='IPADR' value='$wiosettings{'IPADR'}' size='18' /></td>
+	<td class='base'>$Lang::tr{'wio name'}:</td>
+	<td><input type='text' name='HOST' value='$wiosettings{'HOST'}' size='18' /></td>
+	<td class='base'>$Lang::tr{'remark'}:</td>
+	<td><input type='text' name='REMARK' value='$wiosettings{'REMARK'}' size='18' /></td>
 	<td height='30'>$Lang::tr{'wio_ping_send'}:</td>