diff mbox series

build.macro: Explicitly call make install in the install section.

Message ID 20230221100356.597004-1-stefan.schantl@ipfire.org
State New
Headers
Series build.macro: Explicitly call make install in the install section. |

Commit Message

Stefan Schantl Feb. 21, 2023, 10:03 a.m. UTC 
  When using the make_install_targets value in a build file,
this value got overwritten by the given one.

This mean the "install" value got lost, except you have
specified it again in your custom make_install_targets.

This is not very intuitive at all and leads to aborted
builds, missing files etc.

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
---
 macros/build.macro | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/macros/build.macro b/macros/build.macro
index 36c8fa03..dbb55213 100644
--- a/macros/build.macro
+++ b/macros/build.macro
@@ -162,7 +162,7 @@  build
 	# These variables are used if you have to add some targets
 	# directly to the make command.
 	make_build_targets   =
-	make_install_targets = install
+	make_install_targets =
 
 	def _prepare
 		rm -rf %{BUILDROOT}/*
@@ -245,7 +245,7 @@  build
 	end
 
 	def install
-		make DESTDIR=%{BUILDROOT} %{make_install_targets}
+		make DESTDIR=%{BUILDROOT} %{make_install_targets} install
 
 		# Run custom commands.
 		%{install_cmds}