From patchwork Mon Feb 20 16:30:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adolf Belka X-Patchwork-Id: 6564 Return-Path: Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4PL7F11mH6z3x1w for ; Mon, 20 Feb 2023 16:30:13 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4PL7Dz0Wxtz1ln; Mon, 20 Feb 2023 16:30:11 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4PL7Dy5vhSz309Q; Mon, 20 Feb 2023 16:30:10 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4PL7Dx2pRlz2xdN for ; Mon, 20 Feb 2023 16:30:09 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4PL7Dx1B2Jzqt; Mon, 20 Feb 2023 16:30:09 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1676910609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7maP5ufQFtc89kdaH7/BzYr42vl1hUBjdddAIutXzYE=; b=l/FB9drIFrIfWPJGt1eUjzn0/IPyJxMW84o8QQ7WZ37Rbs5KEd8Aiv312ORkwoEcimvFr1 9qW9JYXXSJLw4uBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1676910609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7maP5ufQFtc89kdaH7/BzYr42vl1hUBjdddAIutXzYE=; b=By3egqekG5bpK0eiABWPAq2BK6RBIe8FyBDK3ALABoB8Wf+Qw81kMxTk19+CgxofGIp/K9 4voRpOKUvXQAgf86uYn4YDoGPYk1i6tjfIwup1opmFAypaCZnlgSOQdm9m8vRpdPWK6LTB IF7zkd/IqFq/xacKo0/P3D9WXRfMO6nh06jeszxTAghCAvYA5vOIDGrlpSHdy8n+n/Y8vs LCzh5f954M5pnDvLD/ZIBbVlVYxHvcWNZCS/sXr9IHfTrSSI6bEY6K8v2GNA0n/HzcVU9p hOSQSGMd3tV3/nthQlfXVwNKAQmUAjX8zwQ/UefLU+CEld4hB5M82EeidUwHQQ== From: Adolf Belka To: development@lists.ipfire.org Subject: [PATCH 2/2] wio-lib.pl: Fixes bug#13040 - Change multipart/mixed to multipart/alternative Date: Mon, 20 Feb 2023 17:30:02 +0100 Message-Id: <20230220163003.3434540-2-adolf.belka@ipfire.org> In-Reply-To: <20230220163003.3434540-1-adolf.belka@ipfire.org> References: <20230220163003.3434540-1-adolf.belka@ipfire.org> MIME-Version: 1.0 X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: IPFire development talk List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: development-bounces@lists.ipfire.org Sender: "Development" - Thunderbird and Roundcube mail clients presume that any mail with Content Type of multipart/mixed has an attachment included rather than actually checking for disposition attachment. This means that any mail with multipart/mixed gets the attachment icon marked up even though there is no attachment. - Although this is a problem of the clients involved, in this case the simplest solution is to change multipart/mixed to multipart/alternative as WIO Mail only sends text without any attachment or other part to indicate that a client is active or inactive. - Confirmed on my vm testbed Fixes: Bug#13040 Tested-by: Adolf Belka Signed-off-by: Adolf Belka --- src/wio/wio-lib.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wio/wio-lib.pl b/src/wio/wio-lib.pl index eb7b33e7d..46de7be2f 100644 --- a/src/wio/wio-lib.pl +++ b/src/wio/wio-lib.pl @@ -157,7 +157,7 @@ sub mailsender { From => $mailsettings{'SENDER'}, To => $mailsettings{'RECIPIENT'}, Subject => $_[0], - Type => 'multipart/mixed' + Type => 'multipart/alternative' ); $msg->attach(