diff mbox series

ovpnmain.cgi: Fix for bug 13030 - Table style rendering bug

Message ID 20230117140358.3564163-1-adolf.belka@ipfire.org
State Accepted
Commit f99ed824205d8a585c02df4b3f0b4d2b55c2cb33
Headers
Series ovpnmain.cgi: Fix for bug 13030 - Table style rendering bug |

Commit Message

Adolf Belka Jan. 17, 2023, 2:03 p.m. UTC 
  - In six places <td class'base'> has been used instead of <td class='base'>
- This patch fixes that error - tested on my vm testbed. Selecting Inspect Element now
   shows the corrrect result rather than class 'base' being set to null.

Tested-by: Adolf Belka <adolf.belka@ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
---
 html/cgi-bin/ovpnmain.cgi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Bernhard Bitsch Jan. 17, 2023, 2:08 p.m. UTC | #1 
Reviewed-by: Bernhard Bitsch <bbitsch@ipfire.org>

Am 17.01.2023 um 15:03 schrieb Adolf Belka:
> - In six places <td class'base'> has been used instead of <td class='base'>
> - This patch fixes that error - tested on my vm testbed. Selecting Inspect Element now
>     shows the corrrect result rather than class 'base' being set to null.
> 
> Tested-by: Adolf Belka <adolf.belka@ipfire.org>
> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
> ---
>   html/cgi-bin/ovpnmain.cgi | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
> index 2d19301a6..42a7354fc 100644
> --- a/html/cgi-bin/ovpnmain.cgi
> +++ b/html/cgi-bin/ovpnmain.cgi
> @@ -2710,7 +2710,7 @@ print <<END;
>   <hr size='1'>
>   <table width='100%'>
>   	<tr>
> -		<td class'base'><b>$Lang::tr{'misc-options'}</b></td>
> +		<td class='base'><b>$Lang::tr{'misc-options'}</b></td>
>   	</tr>
>   
>   	<tr>
> @@ -2765,7 +2765,7 @@ print <<END;
>   <hr size='1'>
>   <table width='100%'>
>       <tr>
> -	<td class'base'><b>$Lang::tr{'log-options'}</b></td>
> +	<td class='base'><b>$Lang::tr{'log-options'}</b></td>
>       </tr>
>       <tr>
>   	<td width='20%'></td> <td width='30%'> </td><td width='25%'> </td><td width='25%'></td>
> @@ -4648,7 +4648,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
>   	<tr><td colspan=4><hr /></td></tr><tr>
>   
>   	<tr>
> -		<td class'base'><b>$Lang::tr{'MTU settings'}</b></td>
> +		<td class='base'><b>$Lang::tr{'MTU settings'}</b></td>
>   	</tr>
>   
>           <tr><td class='boldbase' nowrap='nowrap'>$Lang::tr{'MTU'}</td>
> @@ -4672,7 +4672,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
>   
>   <tr><td colspan=4><hr /></td></tr><tr>
>   	<tr>
> -		<td class'base'><b>$Lang::tr{'ovpn crypt options'}:</b></td>
> +		<td class='base'><b>$Lang::tr{'ovpn crypt options'}:</b></td>
>   	</tr>
>   
>   	<tr><td class='boldbase'>$Lang::tr{'cipher'}</td>
> @@ -5222,7 +5222,7 @@ END
>   
>   	<tr><td colspan='4'><br></td></tr>
>   	<tr>
> -		<td class'base'><b>$Lang::tr{'net config'}:</b></td>
> +		<td class='base'><b>$Lang::tr{'net config'}:</b></td>
>   	</tr>
>       <tr><td colspan='1'><br></td></tr>
>   
> @@ -5239,7 +5239,7 @@ END
>   
>   	<tr><td colspan='4'><br></td></tr>
>   	<tr>
> -		<td class'base'><b>$Lang::tr{'ovpn crypt options'}:</b></td>
> +		<td class='base'><b>$Lang::tr{'ovpn crypt options'}:</b></td>
>   	</tr>
>   	<tr><td colspan='1'><br></td></tr>
>
diff mbox series

Patch

diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
index 2d19301a6..42a7354fc 100644
--- a/html/cgi-bin/ovpnmain.cgi
+++ b/html/cgi-bin/ovpnmain.cgi
@@ -2710,7 +2710,7 @@  print <<END;
 <hr size='1'>
 <table width='100%'>
 	<tr>
-		<td class'base'><b>$Lang::tr{'misc-options'}</b></td>
+		<td class='base'><b>$Lang::tr{'misc-options'}</b></td>
 	</tr>
 
 	<tr>
@@ -2765,7 +2765,7 @@  print <<END;
 <hr size='1'>
 <table width='100%'>
     <tr>
-	<td class'base'><b>$Lang::tr{'log-options'}</b></td>
+	<td class='base'><b>$Lang::tr{'log-options'}</b></td>
     </tr>
     <tr>
 	<td width='20%'></td> <td width='30%'> </td><td width='25%'> </td><td width='25%'></td>
@@ -4648,7 +4648,7 @@  if ($cgiparams{'TYPE'} eq 'net') {
 	<tr><td colspan=4><hr /></td></tr><tr>
 
 	<tr>
-		<td class'base'><b>$Lang::tr{'MTU settings'}</b></td>
+		<td class='base'><b>$Lang::tr{'MTU settings'}</b></td>
 	</tr>
 
         <tr><td class='boldbase' nowrap='nowrap'>$Lang::tr{'MTU'}</td>
@@ -4672,7 +4672,7 @@  if ($cgiparams{'TYPE'} eq 'net') {
 
 <tr><td colspan=4><hr /></td></tr><tr>
 	<tr>
-		<td class'base'><b>$Lang::tr{'ovpn crypt options'}:</b></td>
+		<td class='base'><b>$Lang::tr{'ovpn crypt options'}:</b></td>
 	</tr>
 
 	<tr><td class='boldbase'>$Lang::tr{'cipher'}</td>
@@ -5222,7 +5222,7 @@  END
 
 	<tr><td colspan='4'><br></td></tr>
 	<tr>
-		<td class'base'><b>$Lang::tr{'net config'}:</b></td>
+		<td class='base'><b>$Lang::tr{'net config'}:</b></td>
 	</tr>
     <tr><td colspan='1'><br></td></tr>
 
@@ -5239,7 +5239,7 @@  END
 
 	<tr><td colspan='4'><br></td></tr>
 	<tr>
-		<td class'base'><b>$Lang::tr{'ovpn crypt options'}:</b></td>
+		<td class='base'><b>$Lang::tr{'ovpn crypt options'}:</b></td>
 	</tr>
 	<tr><td colspan='1'><br></td></tr>