Message ID | 20230116203404.3723490-1-jon.murphy@ipfire.org |
---|---|
State | Accepted |
Commit | 4941ce0031e9a9f699d0d9ff100f26a6bbce1654 |
Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4NwkJv2Vy8z3wgZ for <patchwork@web04.haj.ipfire.org>; Mon, 16 Jan 2023 20:34:23 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4NwkJs21qKzhR; Mon, 16 Jan 2023 20:34:21 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4NwkJr6lWqz2ytl; Mon, 16 Jan 2023 20:34:20 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4NwkJq5txWz2x9t for <development@lists.ipfire.org>; Mon, 16 Jan 2023 20:34:19 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4NwkJp6Cq2zQM; Mon, 16 Jan 2023 20:34:18 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1673901259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=MNiKyGzMo9wRabaGa0PJGJpAwx1q7ziLwWLwHShg2h8=; b=GxfObKGECYzgUs9Nx9yJSgs4t3/bItXk7igVWF+nbiM51Fa8q2u0TCJSSLuA6hcio1k9BE eJ99oRqMuFdZTlAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1673901259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=MNiKyGzMo9wRabaGa0PJGJpAwx1q7ziLwWLwHShg2h8=; b=bpJ1sCgAjPbxB9gVfGF9YEtTLQZ874eYfTFzegIoFn5JXByR8oEX3bHYSwBqJKEEV6waoO 5WvcpQcg+ATfrsrnPFgxrA8Braggtwbq9iJ6NjKE0hizukAMp9pM6Zb82qgqlQxiRVDPzn bAM0EFIH/LDqunWiI2E6q1HjOqOKuDLr2KONejvFBOq74HAARvLGzNt4Ag82UyP78WBYZG Qld/jD6QAE4gWvH3tappT1sgeb2DiOoS8+pZ/AQh0PRGvcjjLnoOMvQf9IF/jio12DJTC3 oSxBFhHoL5uPgPUttrRtL1lrqc6DgPtCx93ymRT0UYlgWA+NThSL9ApFlrIB+A== From: Jon Murphy <jon.murphy@ipfire.org> To: development@lists.ipfire.org Subject: [PATCH] services.cgi: avoid experimental warnings Date: Mon, 16 Jan 2023 14:34:04 -0600 Message-Id: <20230116203404.3723490-1-jon.murphy@ipfire.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> List-Unsubscribe: <https://lists.ipfire.org/mailman/options/development>, <mailto:development-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/development/> List-Post: <mailto:development@lists.ipfire.org> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Subscribe: <https://lists.ipfire.org/mailman/listinfo/development>, <mailto:development-request@lists.ipfire.org?subject=subscribe> Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org> |
Series |
services.cgi: avoid experimental warnings
|
|
Commit Message
jon
Jan. 16, 2023, 8:34 p.m. UTC
- add single line to code: no warnings 'experimental';
- corrects this issue:
https://lists.ipfire.org/pipermail/development/2022-December/015113.html
Signed-off-by: Jon Murphy <jon.murphy@ipfire.org>
---
html/cgi-bin/services.cgi | 1 +
1 file changed, 1 insertion(+)
Comments
Hi, just a little annotation after reading the Perl docs. Am 16.01.2023 um 21:34 schrieb Jon Murphy: > - add single line to code: no warnings 'experimental'; > - corrects this issue: > https://lists.ipfire.org/pipermail/development/2022-December/015113.html > > Signed-off-by: Jon Murphy <jon.murphy@ipfire.org> > --- > html/cgi-bin/services.cgi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/html/cgi-bin/services.cgi b/html/cgi-bin/services.cgi > index 3c0f27f99..0d06ab5fe 100644 > --- a/html/cgi-bin/services.cgi > +++ b/html/cgi-bin/services.cgi > @@ -21,6 +21,7 @@ > > use strict; > use feature "switch"; > +no warnings 'experimental'; Because the warnings originate from the switch statement only, we should be specific: no warnings 'experimental:smartmatch'; > # enable only the following on debugging purpose > #use warnings; > #use CGI::Carp 'fatalsToBrowser'; Further the line should be placed here. This creates the right sequence if the debugging mode is switched on ( by uncommenting these lines ). Regards, Bernhard
Did the: > no warnings 'experimental:smartmatch’; work A-OK? Should this not be `no warnings ‘experimental:switch’;` ? I don’t mind making the changes but I am doing this a little blind since I don’t do perl… Jon Jon Murphy jon.murphy@ipfire.org > On Jan 16, 2023, at 3:28 PM, Bernhard Bitsch <bbitsch@ipfire.org> wrote: > > Hi, > > just a little annotation after reading the Perl docs. > > Am 16.01.2023 um 21:34 schrieb Jon Murphy: >> - add single line to code: no warnings 'experimental'; >> - corrects this issue: >> https://lists.ipfire.org/pipermail/development/2022-December/015113.html >> Signed-off-by: Jon Murphy <jon.murphy@ipfire.org> >> --- >> html/cgi-bin/services.cgi | 1 + >> 1 file changed, 1 insertion(+) >> diff --git a/html/cgi-bin/services.cgi b/html/cgi-bin/services.cgi >> index 3c0f27f99..0d06ab5fe 100644 >> --- a/html/cgi-bin/services.cgi >> +++ b/html/cgi-bin/services.cgi >> @@ -21,6 +21,7 @@ >> use strict; >> use feature "switch"; >> +no warnings 'experimental'; > Because the warnings originate from the switch statement only, we should be specific: > > no warnings 'experimental:smartmatch'; > >> # enable only the following on debugging purpose >> #use warnings; >> #use CGI::Carp 'fatalsToBrowser'; > Further the line should be placed here. This creates the right sequence if the debugging mode is switched on ( by uncommenting these lines ). > > Regards, > Bernhard
Hi, Am 17.01.2023 um 04:12 schrieb jon: > Did the: >> no warnings 'experimental:smartmatch’; > work A-OK? > Sorry for the typo. The correct syntax is no warnings 'experimental::smartmatch'; I just tried it. > Should this not be `no warnings ‘experimental:switch’;` ? > No. As far as I've understood the docs, you can switch on the switch functionality with use feature "switch"; The implementation of the 'when' sometimes uses the experimental smartmatch operator. Therefore the warnings have to be disabled. > I don’t mind making the changes but I am doing this a little blind since > I don’t do perl… > > Jon > Therefore others on the dev list can look on this. ;) Bernhard > Jon Murphy > jon.murphy@ipfire.org <mailto:jon.murphy@ipfire.org> > > > >> On Jan 16, 2023, at 3:28 PM, Bernhard Bitsch <bbitsch@ipfire.org >> <mailto:bbitsch@ipfire.org>> wrote: >> >> Hi, >> >> just a little annotation after reading the Perl docs. >> >> Am 16.01.2023 um 21:34 schrieb Jon Murphy: >>> - add single line to code: no warnings 'experimental'; >>> - corrects this issue: >>> https://lists.ipfire.org/pipermail/development/2022-December/015113.html <https://lists.ipfire.org/pipermail/development/2022-December/015113.html> >>> Signed-off-by: Jon Murphy <jon.murphy@ipfire.org >>> <mailto:jon.murphy@ipfire.org>> >>> --- >>> html/cgi-bin/services.cgi | 1 + >>> 1 file changed, 1 insertion(+) >>> diff --git a/html/cgi-bin/services.cgi b/html/cgi-bin/services.cgi >>> index 3c0f27f99..0d06ab5fe 100644 >>> --- a/html/cgi-bin/services.cgi >>> +++ b/html/cgi-bin/services.cgi >>> @@ -21,6 +21,7 @@ >>> use strict; >>> use feature "switch"; >>> +no warnings 'experimental'; >> Because the warnings originate from the switch statement only, we >> should be specific: >> >> no warnings 'experimental:smartmatch'; >> >>> # enable only the following on debugging purpose >>> #use warnings; >>> #use CGI::Carp 'fatalsToBrowser'; >> Further the line should be placed here. This creates the right >> sequence if the debugging mode is switched on ( by uncommenting these >> lines ). >> >> Regards, >> Bernhard >
Peter, Was this patch to be included in CU 173? Jon Jon Murphy jon.murphy@ipfire.org > On Jan 16, 2023, at 2:34 PM, Jon Murphy <jon.murphy@ipfire.org> wrote: > > - add single line to code: no warnings 'experimental'; > - corrects this issue: > https://lists.ipfire.org/pipermail/development/2022-December/015113.html > > Signed-off-by: Jon Murphy <jon.murphy@ipfire.org> > --- > html/cgi-bin/services.cgi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/html/cgi-bin/services.cgi b/html/cgi-bin/services.cgi > index 3c0f27f99..0d06ab5fe 100644 > --- a/html/cgi-bin/services.cgi > +++ b/html/cgi-bin/services.cgi > @@ -21,6 +21,7 @@ > > use strict; > use feature "switch"; > +no warnings 'experimental'; > # enable only the following on debugging purpose > #use warnings; > #use CGI::Carp 'fatalsToBrowser'; > -- > 2.30.2 > >
Hello, No, it doesn’t look like it: https://git.ipfire.org/?p=ipfire-2.x.git;a=history;f=html/cgi-bin/services.cgi;h=3c0f27f99ff72f9f96132787017f218ea79fbd1a;hb=HEAD I will merge it into next. As it is only cosmetic, I will avoid rebuilding master for a little while. We will have to do this later on anyways. -Michael > On 8 Feb 2023, at 04:29, jon <jon.murphy@ipfire.org> wrote: > > Peter, > > Was this patch to be included in CU 173? > > Jon > > > Jon Murphy > jon.murphy@ipfire.org > > > >> On Jan 16, 2023, at 2:34 PM, Jon Murphy <jon.murphy@ipfire.org> wrote: >> >> - add single line to code: no warnings 'experimental'; >> - corrects this issue: >> https://lists.ipfire.org/pipermail/development/2022-December/015113.html >> >> Signed-off-by: Jon Murphy <jon.murphy@ipfire.org> >> --- >> html/cgi-bin/services.cgi | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/html/cgi-bin/services.cgi b/html/cgi-bin/services.cgi >> index 3c0f27f99..0d06ab5fe 100644 >> --- a/html/cgi-bin/services.cgi >> +++ b/html/cgi-bin/services.cgi >> @@ -21,6 +21,7 @@ >> >> use strict; >> use feature "switch"; >> +no warnings 'experimental'; >> # enable only the following on debugging purpose >> #use warnings; >> #use CGI::Carp 'fatalsToBrowser'; >> -- >> 2.30.2 >> >> >
diff --git a/html/cgi-bin/services.cgi b/html/cgi-bin/services.cgi index 3c0f27f99..0d06ab5fe 100644 --- a/html/cgi-bin/services.cgi +++ b/html/cgi-bin/services.cgi @@ -21,6 +21,7 @@ use strict; use feature "switch"; +no warnings 'experimental'; # enable only the following on debugging purpose #use warnings; #use CGI::Carp 'fatalsToBrowser';