diff mbox series

[v2] general-functions.pl: Fix for bug#12937

Message ID 20221219091236.3427-1-adolf.belka@ipfire.org
State Accepted
Commit 859f8e3d90246d0277994abf1916f3077f813884
Headers
Series [v2] general-functions.pl: Fix for bug#12937 |

Commit Message

Adolf Belka 19 Dec 2022, 9:12 a.m. UTC 
  - The check for validwildcarddomainname did not allow wildcards of the form
   *.ipfire.org* which is the example given on the proxy.cgi page for excluded url's
   for the wpad file.
- A forum user sufferred from this problem and the bug was raised for it.
   https://community.ipfire.org/t/proxy-cgi-error-message-when-use-wildcard-in-wpad-excluded-url-s/8597
   forum user has tested the patch change and confirmed it solves the problem.

Fixes: Bug#12937
Suggested-by: Bernhard Bitsch <bbitsch@ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
---
 config/cfgroot/general-functions.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bernhard Bitsch 19 Dec 2022, 12:37 p.m. UTC | #1 
Reviewed-by: Bernhard Bitsch <bbitsch@ipfire.org>

Am 19.12.2022 um 10:12 schrieb Adolf Belka:
> - The check for validwildcarddomainname did not allow wildcards of the form
>     *.ipfire.org* which is the example given on the proxy.cgi page for excluded url's
>     for the wpad file.
> - A forum user sufferred from this problem and the bug was raised for it.
>     https://community.ipfire.org/t/proxy-cgi-error-message-when-use-wildcard-in-wpad-excluded-url-s/8597
>     forum user has tested the patch change and confirmed it solves the problem.
> 
> Fixes: Bug#12937
> Suggested-by: Bernhard Bitsch <bbitsch@ipfire.org>
> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
> ---
>   config/cfgroot/general-functions.pl | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/config/cfgroot/general-functions.pl b/config/cfgroot/general-functions.pl
> index 98bedb4b9..d871025eb 100644
> --- a/config/cfgroot/general-functions.pl
> +++ b/config/cfgroot/general-functions.pl
> @@ -760,7 +760,7 @@ sub validwildcarddomainname($) {
>   	my $domainname = shift;
>   
>   	# Ignore any leading dots
> -	if ($domainname =~ m/^\*\.(.*)/) {
> +	if ($domainname =~ m/^\*\.([^\*]*)\*?/) {
>   		$domainname = $1;
>   	}
>
diff mbox series

Patch

diff --git a/config/cfgroot/general-functions.pl b/config/cfgroot/general-functions.pl
index 98bedb4b9..d871025eb 100644
--- a/config/cfgroot/general-functions.pl
+++ b/config/cfgroot/general-functions.pl
@@ -760,7 +760,7 @@  sub validwildcarddomainname($) {
 	my $domainname = shift;
 
 	# Ignore any leading dots
-	if ($domainname =~ m/^\*\.(.*)/) {
+	if ($domainname =~ m/^\*\.([^\*]*)\*?/) {
 		$domainname = $1;
 	}