| Message ID | 20221006175958.11036-4-robin.roevens@disroot.org |
|---|---|
| State | Superseded |
| Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4MjzwJ0b80z3wg5 for <patchwork@web04.haj.ipfire.org>; Thu, 6 Oct 2022 18:09:04 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4MjzwB3nP7z1Pk; Thu, 6 Oct 2022 18:08:58 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4MjzwB3GhKz2yWP; Thu, 6 Oct 2022 18:08:58 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4Mjzw90ZN0z2xhl for <development@lists.ipfire.org>; Thu, 6 Oct 2022 18:08:57 +0000 (UTC) Received: from knopi.disroot.org (knopi.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mail01.ipfire.org (Postfix) with ESMTPS id 4Mjzw746b1z2Yw for <development@lists.ipfire.org>; Thu, 6 Oct 2022 18:08:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 160CA4CB1A for <development@lists.ipfire.org>; Thu, 6 Oct 2022 20:08:55 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with UTF8SMTP id lqz8j6i5jhQo for <development@lists.ipfire.org>; Thu, 6 Oct 2022 20:08:54 +0200 (CEST) Received: from chojin.sicho.home (amaterasu.sicho.home [192.168.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (no client certificate requested) (Authenticated sender) by hachiman (MailScanner Milter) with SMTP id 0DD637353F; Thu, 6 Oct 2022 20:00:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1665079223; bh=vbDvSVGhgCO6+RtYlm/w2uMpg29aUcrnpQFLZJTdVho=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=BtedIHBInE09UETl3VdQ/ISKf6FfDsCeEhx6rxLjbR9RQoTSbSj0AZTtQU6aiQTfI e1+E2BW0dLnKkpiuOq6ueNJBGJMNzVuSYFzJX9WUuf91twsXSEt0ar+JoUFNQzMPz1 pzzHp82/79WbuLltwNOQf/45RCK6qFVizFd/gEWnpXCto1JEkPNJb/o8t6pz9AduQK 9bhIVpJYueS2tLKxYf4wVMSJohw1Om6EM0+UHc5Bv+/v5c1uzMciTI7d6hjN8nf0nW TnNIuNEyybvZPW9RpnQOx2cqeMXA2uBvTzyN8JtSSg5qRbBLd/q/jQdUt1EjyUGBgM sRqTWWFvJo15g== From: Robin Roevens <robin.roevens@disroot.org> To: development@lists.ipfire.org Subject: [PATCH v2 3/5] services.cgi: minor cosmetics Date: Thu, 6 Oct 2022 19:59:56 +0200 Message-Id: <20221006175958.11036-4-robin.roevens@disroot.org> In-Reply-To: <20221006175958.11036-1-robin.roevens@disroot.org> References: <20221006175958.11036-1-robin.roevens@disroot.org> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-sicho-MailScanner-ID: 0DD637353F.A8A80 X-sicho-MailScanner: Found to be clean X-sicho-MailScanner-From: robin.roevens@disroot.org X-sicho-MailScanner-Watermark: 1665684008.80866@o14oBPoKcM59OZdWgqsZSA ARC-Seal: i=1; s=202003rsa; d=lists.ipfire.org; t=1665079735; a=rsa-sha256; cv=none; b=EdrsD8p+QYh52DrV890NU6tg9IQKADmqDC/a7ompAIqP4Ak3K8C3/Rj9OR4+qb3C3xFZvy yqRZv/BWYWx5YUTrzq82kKbKAYr3P3z48bnS36zf+kTienKup0Gh8tEowoIfm24VQseFYW zuraPsIbtIaZ/rp/uSYbjss5mPDGgstzTtrqSYPEluRQGtCeHX/NYhIHSx5ZmOJGAKLEac Kg2bMuPe43t/Joe5tN9L7Qj3uMP5GStYyrIOKMv+5lY4RleJZMeQgZJUbvB2e2wDva4J/N YiCibOulRfVem1cVMhciff9SYP4yZhaDUoW7mvwifVSwuLzBFCdLgS7mGeBeUw== ARC-Authentication-Results: i=1; mail01.ipfire.org; dkim=pass header.d=disroot.org header.s=mail header.b=BtedIHBI; spf=pass (mail01.ipfire.org: domain of robin.roevens@disroot.org designates 178.21.23.139 as permitted sender) smtp.mailfrom=robin.roevens@disroot.org; dmarc=pass (policy=quarantine) header.from=disroot.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.ipfire.org; s=202003rsa; t=1665079735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kv4X7Ldg++5HyH98neE3Ar4qsUNU6YeUaIoFM7DSOko=; b=ME4GNtLt42V72PtRr8ItwnEvBpjtTPKcwZKCzKa5DBbpJdfUMY2Eosl5ImZ2dR2hxqz+3e 8xujb7vt6ZT8MPIuR1BYbdwSJx05Cs2w+ojfiYh6WpBX2aiPchpgx/G/+ZhnHcCfQzeKJY K7soqUY9KcwV+zFbI65X34sYwJuvo2F2as5dUihHp+UGZux+EO1Bxr1cxHe53J188zfTao 4gMVAIO2czEzUKmKrBmR8hfbiBBpg9i5BhfiVNLdvXIKmVlO+Cy7mCwkU+vhT661AAhbny aAsl6xd2DbXjSCOynqHdHJD/no0QMprLoOIC1iYzLyHkSzjqBEgAs8VnZjMmTg== Authentication-Results: mail01.ipfire.org; dkim=pass header.d=disroot.org header.s=mail header.b=BtedIHBI; spf=pass (mail01.ipfire.org: domain of robin.roevens@disroot.org designates 178.21.23.139 as permitted sender) smtp.mailfrom=robin.roevens@disroot.org; dmarc=pass (policy=quarantine) header.from=disroot.org X-Rspamd-Server: mail01.haj.ipfire.org X-Spamd-Result: default: False [-7.22 / 11.00]; REPLY(-4.00)[]; BAYES_HAM(-1.10)[88.24%]; IP_REPUTATION_HAM(-1.10)[asn: 50673(-0.31), country: NL(-0.01), ip: 178.21.23.139(-0.78)]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM(-1.00)[-1.000]; DKIM_REPUTATION(-0.79)[-0.79182037427657]; SPF_REPUTATION_HAM(-0.68)[-0.68195341966138]; R_MISSING_CHARSET(0.50)[]; MV_CASE(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[disroot.org,quarantine]; R_DKIM_ALLOW(0.26)[disroot.org:s=mail]; R_SPF_ALLOW(-0.20)[+a:c]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[development@lists.ipfire.org]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; ARC_SIGNED(0.00)[lists.ipfire.org:s=202003rsa:i=1]; RCVD_COUNT_THREE(0.00)[4]; ASN(0.00)[asn:50673, ipnet:178.21.23.0/24, country:NL]; DKIM_TRACE(0.00)[disroot.org:+]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWO(0.00)[2]; TO_DN_SOME(0.00)[] X-Rspamd-Queue-Id: 4Mjzw746b1z2Yw X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> List-Unsubscribe: <https://lists.ipfire.org/mailman/options/development>, <mailto:development-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/development/> List-Post: <mailto:development@lists.ipfire.org> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Subscribe: <https://lists.ipfire.org/mailman/listinfo/development>, <mailto:development-request@lists.ipfire.org?subject=subscribe> Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org> |
| Series |
Fix Bug#12935 + cosmetic changes/enhancements
|
|
Commit Message
Robin Roevens
Oct. 6, 2022, 5:59 p.m. UTC
* Singular 'Service' instead of plural 'Services' as column header of
services table
* Sort list of services
Signed-off-by: Robin Roevens <robin.roevens@disroot.org>
---
html/cgi-bin/services.cgi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
Reviewed-by: Bernhard Bitsch <bbitsch@ipfire.org> Am 06.10.2022 um 19:59 schrieb Robin Roevens: > * Singular 'Service' instead of plural 'Services' as column header of > services table > * Sort list of services > > Signed-off-by: Robin Roevens <robin.roevens@disroot.org> > --- > html/cgi-bin/services.cgi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/html/cgi-bin/services.cgi b/html/cgi-bin/services.cgi > index de946d755..e35b04cae 100644 > --- a/html/cgi-bin/services.cgi > +++ b/html/cgi-bin/services.cgi > @@ -105,7 +105,7 @@ if ( $querry[0] =~ "processescpu"){ > <div align='center'> > <table width='80%' cellspacing='1' class='tbl'> > <tr> > - <th align='left'><b>$Lang::tr{'services'}</b></th> > + <th align='left'><b>$Lang::tr{'service'}</b></th> > <th align='center' ><b>$Lang::tr{'status'}</b></th> > <th align='center'><b>PID</b></th> > <th align='center'><b>$Lang::tr{'memory'}</b></th> > @@ -174,7 +174,7 @@ END > # Generate list of installed addon pak services > my %paklist = &Pakfire::dblist("installed"); > > - foreach my $pak (keys %paklist) { > + foreach my $pak (sort keys %paklist) { > my %metadata = &Pakfire::getmetadata($pak, "installed"); > > my $service;
diff --git a/html/cgi-bin/services.cgi b/html/cgi-bin/services.cgi index de946d755..e35b04cae 100644 --- a/html/cgi-bin/services.cgi +++ b/html/cgi-bin/services.cgi @@ -105,7 +105,7 @@ if ( $querry[0] =~ "processescpu"){ <div align='center'> <table width='80%' cellspacing='1' class='tbl'> <tr> - <th align='left'><b>$Lang::tr{'services'}</b></th> + <th align='left'><b>$Lang::tr{'service'}</b></th> <th align='center' ><b>$Lang::tr{'status'}</b></th> <th align='center'><b>PID</b></th> <th align='center'><b>$Lang::tr{'memory'}</b></th> @@ -174,7 +174,7 @@ END # Generate list of installed addon pak services my %paklist = &Pakfire::dblist("installed"); - foreach my $pak (keys %paklist) { + foreach my $pak (sort keys %paklist) { my %metadata = &Pakfire::getmetadata($pak, "installed"); my $service;