Message ID | 20221003153905.14824-2-robin.roevens@disroot.org |
---|---|
State | Superseded |
Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4Mh5kf5X3Kz3wcJ for <patchwork@web04.haj.ipfire.org>; Mon, 3 Oct 2022 16:24:10 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4Mh5kf0lshz1Pk; Mon, 3 Oct 2022 16:24:10 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4Mh5kd715rz2xn3; Mon, 3 Oct 2022 16:24:09 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4Mh5kd2220z2xJQ for <development@lists.ipfire.org>; Mon, 3 Oct 2022 16:24:09 +0000 (UTC) Received: from knopi.disroot.org (knopi.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mail01.ipfire.org (Postfix) with ESMTPS id 4Mh5kc6XmRz1Q5 for <development@lists.ipfire.org>; Mon, 3 Oct 2022 16:24:08 +0000 (UTC) Received: by disroot.org (Postfix, from userid 107) id A6D224C4EC; Mon, 3 Oct 2022 18:14:42 +0200 (CEST) Received: from chojin.sicho.home (amaterasu.sicho.home [192.168.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (no client certificate requested) (Authenticated sender) by hachiman (MailScanner Milter) with SMTP id 62A5B71E74; Mon, 3 Oct 2022 17:39:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1664813681; bh=Hqth7SXQZgzjmXF7N6P8V+A/CKGEJQjgWj3QEMzmfx4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=CWQz1d5sCLt0WP8PivhXKKh04Dknmv7CPVpq6YLVrHCdMtYEYKiQn7SchlEoiBwGE bbcvpVtZmx7479D2na43xe/rlHFruj87AoIS8YZa85MRxuWfkJk1GNBTjgCROzaXHO +RYWa0Rfgu23cEKbV8Erfn9FwkAu18izjAtqB2UhRPkIBzE3Cg+ADXWnyEB6qArLBs 01aDsZXii4sh+4+b8NTtwrrrRZOtJf1UJ59v32zkVCRsdK1RPU9nEH1DLCLrDleK7w CGCSm3QWXytuedUvokwK5pob0dDh811jZZV6uCGIGLzvUHZAMvAc/zHekRZn1v/mAF 2TXpUuRsHT3Zw== From: Robin Roevens <robin.roevens@disroot.org> To: development@lists.ipfire.org Subject: [PATCH 1/3] services.cgi: minor cosmetics Date: Mon, 3 Oct 2022 17:39:03 +0200 Message-Id: <20221003153905.14824-2-robin.roevens@disroot.org> In-Reply-To: <20221003153905.14824-1-robin.roevens@disroot.org> References: <20221003153905.14824-1-robin.roevens@disroot.org> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-sicho-MailScanner-ID: 62A5B71E74.A8A80 X-sicho-MailScanner: Found to be clean X-sicho-MailScanner-From: robin.roevens@disroot.org X-sicho-MailScanner-Watermark: 1665416364.34753@tDQZHvN8+dfZkQTdw9oQKA X-Spam-Status: No ARC-Seal: i=1; s=202003rsa; d=lists.ipfire.org; t=1664814248; a=rsa-sha256; cv=none; b=BdHpskzepx2f95h7JjsyiueBOpY9ULHT74MAzMwPBi0piW5BzrbUtqtjqhQEuU6U3no9lV XKom68DINsqGMJEe+bZnxJUKviUemLrV1OCuqEKCralkf+d66wTDG5dt/ulzTCjkkQ+Q4Q /7W00rj8T42wkSqw4tw+62wUdhfk/kOJk5o5MQRAV3GSRXF6XjqpT0tTveR7cuOvDv7AgL EFyjpB4qrNIYafHyGgoc+S8SMM24IJU/TrAfXKDRtjxm93zdyGiBdEZbQQuY0w721TrItk 2NeysOHY/NofVveRrefjmteh+US6hOhCcLgzqcUBeabGjySO3XNiWBOnKNL9GQ== ARC-Authentication-Results: i=1; mail01.ipfire.org; dkim=pass header.d=disroot.org header.s=mail header.b=CWQz1d5s; spf=pass (mail01.ipfire.org: domain of robin.roevens@disroot.org designates 178.21.23.139 as permitted sender) smtp.mailfrom=robin.roevens@disroot.org; dmarc=pass (policy=quarantine) header.from=disroot.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.ipfire.org; s=202003rsa; t=1664814248; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vH72+C5iA2fXoN3GrKkSJD978Q7X9enj43wJN4/3b+w=; b=mHg1ADIrh/TQhqx0ENQrk0EXGNO38Fq++RitihbddDh8uWeFjfnJFtmWfYCvAJDzewkAng CpmBhvOmPgxsF3V9vXEmqJnLm0m4PEZWdOjTEjm++dwNHWNS+En4eGuQ2YM7iZtoo1m9UC HLlHvu9v+Zat1QgdbmpzPJJcw5rKsRy1bpUy0hv9V/HrGtfcHHef6y8uV0PTXY50OHPdZ3 u2+kuIyXZDfiKTZNYjSbrAwkjpCmnYVLrCJq7BlzLmU6l2gmu8A7dGjJCTu8CtibyFAzdA l5Hujr5dW/KD5SQvq6irWJnZ4auj9jfPlD0u3m9CAcYgRZOa8mKQwQm3QhE6rQ== Authentication-Results: mail01.ipfire.org; dkim=pass header.d=disroot.org header.s=mail header.b=CWQz1d5s; spf=pass (mail01.ipfire.org: domain of robin.roevens@disroot.org designates 178.21.23.139 as permitted sender) smtp.mailfrom=robin.roevens@disroot.org; dmarc=pass (policy=quarantine) header.from=disroot.org X-Rspamd-Server: mail01.haj.ipfire.org X-Spamd-Result: default: False [-6.55 / 11.00]; REPLY(-4.00)[]; IP_REPUTATION_HAM(-1.07)[asn: 50673(-0.30), country: NL(-0.01), ip: 178.21.23.139(-0.76)]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM(-1.00)[-1.000]; DKIM_REPUTATION(-0.77)[-0.76741038557295]; SPF_REPUTATION_HAM(-0.67)[-0.66694015940493]; DMARC_POLICY_ALLOW(-0.50)[disroot.org,quarantine]; R_MISSING_CHARSET(0.50)[]; MV_CASE(0.50)[]; BAYES_HAM(-0.50)[79.87%]; R_DKIM_ALLOW(0.26)[disroot.org:s=mail]; R_SPF_ALLOW(-0.20)[+a:c]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; MIME_TRACE(0.00)[0:+]; ARC_SIGNED(0.00)[lists.ipfire.org:s=202003rsa:i=1]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[disroot.org:+]; RCPT_COUNT_TWO(0.00)[2]; ARC_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:50673, ipnet:178.21.23.0/24, country:NL]; TO_DN_SOME(0.00)[] X-Rspamd-Queue-Id: 4Mh5kc6XmRz1Q5 X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> List-Unsubscribe: <https://lists.ipfire.org/mailman/options/development>, <mailto:development-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/development/> List-Post: <mailto:development@lists.ipfire.org> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Subscribe: <https://lists.ipfire.org/mailman/listinfo/development>, <mailto:development-request@lists.ipfire.org?subject=subscribe> Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org> |
Series | services.cgi: few cosmetic changes/enhancements | |
Commit Message
Robin Roevens
Oct. 3, 2022, 3:39 p.m. UTC
* Singular 'Service' instead of plural 'Services' as column header of
services table
* Sort list of services
Signed-off-by: Robin Roevens <robin.roevens@disroot.org>
---
html/cgi-bin/services.cgi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
Reviewed-by: Bernhard Bitsch <bbitsch@ipfire.org> Am 03.10.2022 um 17:39 schrieb Robin Roevens: > * Singular 'Service' instead of plural 'Services' as column header of > services table > * Sort list of services > > Signed-off-by: Robin Roevens <robin.roevens@disroot.org> > --- > html/cgi-bin/services.cgi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/html/cgi-bin/services.cgi b/html/cgi-bin/services.cgi > index e91da884b..d480088a8 100644 > --- a/html/cgi-bin/services.cgi > +++ b/html/cgi-bin/services.cgi > @@ -105,7 +105,7 @@ if ( $querry[0] =~ "processescpu"){ > <div align='center'> > <table width='80%' cellspacing='1' class='tbl'> > <tr> > - <th align='left'><b>$Lang::tr{'services'}</b></th> > + <th align='left'><b>$Lang::tr{'service'}</b></th> > <th align='center' ><b>$Lang::tr{'status'}</b></th> > <th align='center'><b>PID</b></th> > <th align='center'><b>$Lang::tr{'memory'}</b></th> > @@ -167,7 +167,7 @@ END > # Generate list of installed addon pak services > my %paklist = &Pakfire::dblist("installed"); > > - foreach my $pak (keys %paklist) { > + foreach my $pak (sort keys %paklist) { > my %metadata = &Pakfire::getmetadata($pak, "installed"); > > my $service;
diff --git a/html/cgi-bin/services.cgi b/html/cgi-bin/services.cgi index e91da884b..d480088a8 100644 --- a/html/cgi-bin/services.cgi +++ b/html/cgi-bin/services.cgi @@ -105,7 +105,7 @@ if ( $querry[0] =~ "processescpu"){ <div align='center'> <table width='80%' cellspacing='1' class='tbl'> <tr> - <th align='left'><b>$Lang::tr{'services'}</b></th> + <th align='left'><b>$Lang::tr{'service'}</b></th> <th align='center' ><b>$Lang::tr{'status'}</b></th> <th align='center'><b>PID</b></th> <th align='center'><b>$Lang::tr{'memory'}</b></th> @@ -167,7 +167,7 @@ END # Generate list of installed addon pak services my %paklist = &Pakfire::dblist("installed"); - foreach my $pak (keys %paklist) { + foreach my $pak (sort keys %paklist) { my %metadata = &Pakfire::getmetadata($pak, "installed"); my $service;