[v2] cpufrequtils: Remove SERVICES entry for this package - fixes Bug#12933

Message ID 20220921103719.3810-1-adolf.belka@ipfire.org
State Accepted
Commit 7bb62b122541633c0e79538120b1175faaa521bb
Headers
Series [v2] cpufrequtils: Remove SERVICES entry for this package - fixes Bug#12933 |

Commit Message

Adolf Belka Sept. 21, 2022, 10:37 a.m. UTC
  - cpufrequtils is a set of "tools" to manage and set cpu freq settings.
- There is an initscript but this is only loading the cpu dependent kernel modules that
   are required by cpufrequtils.
- Therefore cpufrequtils is not a service but a set of tools that are used when required.
- SERVICES line made blank so that this addon does not show up in the services addon table.
- Modified install initscript line to not use SERVICES variable

Fixes: Bug#12933
Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
---
 lfs/cpufrequtils | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
  

Comments

Bernhard Bitsch Sept. 21, 2022, 10:41 a.m. UTC | #1
Reviewed-by: Bernhard Bitsch <bbitsch@ipfire.org>

Am 21.09.2022 um 12:37 schrieb Adolf Belka:
> - cpufrequtils is a set of "tools" to manage and set cpu freq settings.
> - There is an initscript but this is only loading the cpu dependent kernel modules that
>     are required by cpufrequtils.
> - Therefore cpufrequtils is not a service but a set of tools that are used when required.
> - SERVICES line made blank so that this addon does not show up in the services addon table.
> - Modified install initscript line to not use SERVICES variable
> 
> Fixes: Bug#12933
> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
> ---
>   lfs/cpufrequtils | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lfs/cpufrequtils b/lfs/cpufrequtils
> index 752964198..dab254014 100644
> --- a/lfs/cpufrequtils
> +++ b/lfs/cpufrequtils
> @@ -34,11 +34,11 @@ DL_FROM    = $(URL_IPFIRE)
>   DIR_APP    = $(DIR_SRC)/$(THISAPP)
>   TARGET     = $(DIR_INFO)/$(THISAPP)
>   PROG       = cpufrequtils
> -PAK_VER    = 11
> +PAK_VER    = 12
>   
>   DEPS       =
>   
> -SERVICES   = cpufreq
> +SERVICES   =
>   
>   ###############################################################################
>   # Top-level Rules
> @@ -91,7 +91,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
>   	cd $(DIR_APP) && make install
>   
>   	#install initscripts
> -	$(call INSTALL_INITSCRIPTS,$(SERVICES))
> +	$(call INSTALL_INITSCRIPTS,cpufreq)
>   
>   	@rm -rf $(DIR_APP)
>   	@$(POSTBUILD)
  

Patch

diff --git a/lfs/cpufrequtils b/lfs/cpufrequtils
index 752964198..dab254014 100644
--- a/lfs/cpufrequtils
+++ b/lfs/cpufrequtils
@@ -34,11 +34,11 @@  DL_FROM    = $(URL_IPFIRE)
 DIR_APP    = $(DIR_SRC)/$(THISAPP)
 TARGET     = $(DIR_INFO)/$(THISAPP)
 PROG       = cpufrequtils
-PAK_VER    = 11
+PAK_VER    = 12
 
 DEPS       =
 
-SERVICES   = cpufreq
+SERVICES   = 
 
 ###############################################################################
 # Top-level Rules
@@ -91,7 +91,7 @@  $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
 	cd $(DIR_APP) && make install
 
 	#install initscripts
-	$(call INSTALL_INITSCRIPTS,$(SERVICES))
+	$(call INSTALL_INITSCRIPTS,cpufreq)
 
 	@rm -rf $(DIR_APP)
 	@$(POSTBUILD)