diff mbox series

cpufrequtils: Remove SERVICES entry for this package - fixes Bug#12933

Message ID 20220919145129.6714-1-adolf.belka@ipfire.org
State Superseded
Headers
Series cpufrequtils: Remove SERVICES entry for this package - fixes Bug#12933 |

Commit Message

Adolf Belka Sept. 19, 2022, 2:51 p.m. UTC 
  - cpufrequtils is a set of "tools" to manage and set cpu freq settings.
- There is an initscript but this is only loading the cpu dependent kernel modules that
   are required by cpufrequtils.
- Therefore cpufrequtils is not a service but a set of tools that are used when required.
- SERVICES line made blank so that this addon does not show up in the services addon table.

Fixes: Bug#12933
Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
---
 lfs/cpufrequtils | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Michael Tremer Sept. 19, 2022, 5:18 p.m. UTC | #1 
Reviewed-by: Michael Tremer <michael.tremer@ipfire.org>

> On 19 Sep 2022, at 16:51, Adolf Belka <adolf.belka@ipfire.org> wrote:
> 
> - cpufrequtils is a set of "tools" to manage and set cpu freq settings.
> - There is an initscript but this is only loading the cpu dependent kernel modules that
>   are required by cpufrequtils.
> - Therefore cpufrequtils is not a service but a set of tools that are used when required.
> - SERVICES line made blank so that this addon does not show up in the services addon table.
> 
> Fixes: Bug#12933
> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
> ---
> lfs/cpufrequtils | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lfs/cpufrequtils b/lfs/cpufrequtils
> index 752964198..9076a70d7 100644
> --- a/lfs/cpufrequtils
> +++ b/lfs/cpufrequtils
> @@ -34,11 +34,11 @@ DL_FROM    = $(URL_IPFIRE)
> DIR_APP    = $(DIR_SRC)/$(THISAPP)
> TARGET     = $(DIR_INFO)/$(THISAPP)
> PROG       = cpufrequtils
> -PAK_VER    = 11
> +PAK_VER    = 12
> 
> DEPS       =
> 
> -SERVICES   = cpufreq
> +SERVICES   = 
> 
> ###############################################################################
> # Top-level Rules
> -- 
> 2.37.3
>
Robin Roevens Sept. 20, 2022, 8:22 p.m. UTC | #2 
I think you missed the install initscripts part lower in the LFS file:

	$(call INSTALL_INITSCRIPTS,$(SERVICES))

should then also be changed to 

	$(call INSTALL_INITSCRIPTS,cpufreq)

otherwise the initscript won't be installed as SERVICES is now empty.

Regards 
Robin

Adolf Belka schreef op ma 19-09-2022 om 16:51 [+0200]:
> - cpufrequtils is a set of "tools" to manage and set cpu freq
> settings.
> - There is an initscript but this is only loading the cpu dependent
> kernel modules that
>    are required by cpufrequtils.
> - Therefore cpufrequtils is not a service but a set of tools that are
> used when required.
> - SERVICES line made blank so that this addon does not show up in the
> services addon table.
> 
> Fixes: Bug#12933
> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
> ---
>  lfs/cpufrequtils | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lfs/cpufrequtils b/lfs/cpufrequtils
> index 752964198..9076a70d7 100644
> --- a/lfs/cpufrequtils
> +++ b/lfs/cpufrequtils
> @@ -34,11 +34,11 @@ DL_FROM    = $(URL_IPFIRE)
>  DIR_APP    = $(DIR_SRC)/$(THISAPP)
>  TARGET     = $(DIR_INFO)/$(THISAPP)
>  PROG       = cpufrequtils
> -PAK_VER    = 11
> +PAK_VER    = 12
>  
>  DEPS       =
>  
> -SERVICES   = cpufreq
> +SERVICES   = 
>  
>  ####################################################################
> ###########
>  # Top-level Rules
> -- 
> 2.37.3
> 
>
Adolf Belka Sept. 21, 2022, 8:27 a.m. UTC | #3 
Thanks Robin,

On 20/09/2022 22:22, Robin Roevens wrote:
> I think you missed the install initscripts part lower in the LFS file:
> 
> 	$(call INSTALL_INITSCRIPTS,$(SERVICES))
> 
> should then also be changed to
> 
> 	$(call INSTALL_INITSCRIPTS,cpufreq)
> 
> otherwise the initscript won't be installed as SERVICES is now empty.
Very good catch. I will try and remember to check for the use of 
$(SERVICES) in future when I am changing things.

I will submit an updated patch.

Regards,

Adolf.
> 
> Regards
> Robin
> 
> Adolf Belka schreef op ma 19-09-2022 om 16:51 [+0200]:
>> - cpufrequtils is a set of "tools" to manage and set cpu freq
>> settings.
>> - There is an initscript but this is only loading the cpu dependent
>> kernel modules that
>>     are required by cpufrequtils.
>> - Therefore cpufrequtils is not a service but a set of tools that are
>> used when required.
>> - SERVICES line made blank so that this addon does not show up in the
>> services addon table.
>>
>> Fixes: Bug#12933
>> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
>> ---
>>   lfs/cpufrequtils | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/lfs/cpufrequtils b/lfs/cpufrequtils
>> index 752964198..9076a70d7 100644
>> --- a/lfs/cpufrequtils
>> +++ b/lfs/cpufrequtils
>> @@ -34,11 +34,11 @@ DL_FROM    = $(URL_IPFIRE)
>>   DIR_APP    = $(DIR_SRC)/$(THISAPP)
>>   TARGET     = $(DIR_INFO)/$(THISAPP)
>>   PROG       = cpufrequtils
>> -PAK_VER    = 11
>> +PAK_VER    = 12
>>   
>>   DEPS       =
>>   
>> -SERVICES   = cpufreq
>> +SERVICES   =
>>   
>>   ####################################################################
>> ###########
>>   # Top-level Rules
>> -- 
>> 2.37.3
>>
>>
>
diff mbox series

Patch

diff --git a/lfs/cpufrequtils b/lfs/cpufrequtils
index 752964198..9076a70d7 100644
--- a/lfs/cpufrequtils
+++ b/lfs/cpufrequtils
@@ -34,11 +34,11 @@  DL_FROM    = $(URL_IPFIRE)
 DIR_APP    = $(DIR_SRC)/$(THISAPP)
 TARGET     = $(DIR_INFO)/$(THISAPP)
 PROG       = cpufrequtils
-PAK_VER    = 11
+PAK_VER    = 12
 
 DEPS       =
 
-SERVICES   = cpufreq
+SERVICES   = 
 
 ###############################################################################
 # Top-level Rules