diff mbox series

[2/2] aliases: Don't call arpping to announce new IP addresses

Message ID 20220629182724.392049-2-michael.tremer@ipfire.org
State Accepted
Commit 72696db892c8dcc8533f7b1813316592111cb46a
Headers
Series [1/2] aliases: Add support to assign aliases to multiple RED interfaces |

Commit Message

Michael Tremer June 29, 2022, 6:27 p.m. UTC 
  I am not sure what the rationale is here, but we should probably not do
this. Other hosts on the network will be able to update their ARP caches
properly.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---
 src/misc-progs/setaliases.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Peter Müller July 6, 2022, 9:59 a.m. UTC | #1 
Acked-by: Peter Müller <peter.mueller@ipfire.org>

> I am not sure what the rationale is here, but we should probably not do
> this. Other hosts on the network will be able to update their ARP caches
> properly.
> 
> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
> ---
>  src/misc-progs/setaliases.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/src/misc-progs/setaliases.c b/src/misc-progs/setaliases.c
> index 4d59aa0a8..a541a4fd2 100644
> --- a/src/misc-progs/setaliases.c
> +++ b/src/misc-progs/setaliases.c
> @@ -188,11 +188,6 @@ int main(void)
>  			aliasip, red_netmask, intf, SCOPE);
>  		safe_system(command);
>  
> -		// Send an ARP broadcast
> -		snprintf(command, STRING_SIZE-1,
> -				"/usr/sbin/arping -q -c 1 -w 1 -i %s -S %s %s",
> -				intf, aliasip, default_gateway);
> -		safe_system(command);
>  		alias++;
>  	}
>  	return 0;
diff mbox series

Patch

diff --git a/src/misc-progs/setaliases.c b/src/misc-progs/setaliases.c
index 4d59aa0a8..a541a4fd2 100644
--- a/src/misc-progs/setaliases.c
+++ b/src/misc-progs/setaliases.c
@@ -188,11 +188,6 @@  int main(void)
 			aliasip, red_netmask, intf, SCOPE);
 		safe_system(command);
 
-		// Send an ARP broadcast
-		snprintf(command, STRING_SIZE-1,
-				"/usr/sbin/arping -q -c 1 -w 1 -i %s -S %s %s",
-				intf, aliasip, default_gateway);
-		safe_system(command);
 		alias++;
 	}
 	return 0;