diff mbox series

ruleset-sources: Update download URL for Talos rulesets.

Message ID 20220623060319.2661-1-stefan.schantl@ipfire.org
State Accepted
Commit b77b41a579982fd6ee524f1c8ee45fea03bb9b76
Headers
Series ruleset-sources: Update download URL for Talos rulesets. |

Commit Message

Stefan Schantl June 23, 2022, 6:03 a.m. UTC 
  Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
---
 config/suricata/ruleset-sources | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Peter Müller June 23, 2022, 10:30 a.m. UTC | #1 
Hello Stefan,

thank you for submitting this.

Does this patch urgently need to go into Core Update 169? While there is still an
issue left to solve with the update, I would rather abstain from packing any patch
that now comes up into it as well...

Apart from that:

Reviewed-by: Peter Müller <peter.mueller@ipfire.org>

Thanks, and best regards,
Peter Müller


> Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
> ---
>  config/suricata/ruleset-sources | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/config/suricata/ruleset-sources b/config/suricata/ruleset-sources
> index 1d2c6e98b..592cbedf0 100644
> --- a/config/suricata/ruleset-sources
> +++ b/config/suricata/ruleset-sources
> @@ -23,7 +23,7 @@ our %Providers = (
>  		website => "https://www.snort.org",
>  		tr_string => "registered user rules",
>  		requires_subscription => "True",
> -		dl_url => "https://www.snort.org/rules/snortrules-snapshot-29190.tar.gz?oinkcode=<subscription_code>",
> +		dl_url => "https://www.snort.org/rules/snortrules-snapshot-29200.tar.gz?oinkcode=<subscription_code>",
>  		dl_type => "archive",
>  	},
>  
> @@ -33,7 +33,7 @@ our %Providers = (
>  		website => "https://www.snort.org",
>  		tr_string => "subscripted user rules",
>  		requires_subscription => "True",
> -		dl_url => "https://www.snort.org/rules/snortrules-snapshot-29190.tar.gz?oinkcode=<subscription_code>",
> +		dl_url => "https://www.snort.org/rules/snortrules-snapshot-29200.tar.gz?oinkcode=<subscription_code>",
>  		dl_type => "archive",
>  	},
>
Michael Tremer June 23, 2022, 11:31 a.m. UTC | #2 
I don’t quite understand why we can’t ship this.

> On 23 Jun 2022, at 11:30, Peter Müller <peter.mueller@ipfire.org> wrote:
> 
> Hello Stefan,
> 
> thank you for submitting this.
> 
> Does this patch urgently need to go into Core Update 169? While there is still an
> issue left to solve with the update, I would rather abstain from packing any patch
> that now comes up into it as well...
> 
> Apart from that:
> 
> Reviewed-by: Peter Müller <peter.mueller@ipfire.org>
> 
> Thanks, and best regards,
> Peter Müller
> 
> 
>> Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
>> ---
>> config/suricata/ruleset-sources | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/config/suricata/ruleset-sources b/config/suricata/ruleset-sources
>> index 1d2c6e98b..592cbedf0 100644
>> --- a/config/suricata/ruleset-sources
>> +++ b/config/suricata/ruleset-sources
>> @@ -23,7 +23,7 @@ our %Providers = (
>> 		website => "https://www.snort.org",
>> 		tr_string => "registered user rules",
>> 		requires_subscription => "True",
>> -		dl_url => "https://www.snort.org/rules/snortrules-snapshot-29190.tar.gz?oinkcode=<subscription_code>",
>> +		dl_url => "https://www.snort.org/rules/snortrules-snapshot-29200.tar.gz?oinkcode=<subscription_code>",
>> 		dl_type => "archive",
>> 	},
>> 
>> @@ -33,7 +33,7 @@ our %Providers = (
>> 		website => "https://www.snort.org",
>> 		tr_string => "subscripted user rules",
>> 		requires_subscription => "True",
>> -		dl_url => "https://www.snort.org/rules/snortrules-snapshot-29190.tar.gz?oinkcode=<subscription_code>",
>> +		dl_url => "https://www.snort.org/rules/snortrules-snapshot-29200.tar.gz?oinkcode=<subscription_code>",
>> 		dl_type => "archive",
>> 	},
>>
Stefan Schantl June 23, 2022, 5:07 p.m. UTC | #3 
Hello Peter,

if possible it would we great to ship this with core 169. It is simply
a minor change and allows those who are using the rulesets from Talos
to get the latest rules again.

Best regards,

-Stefan
> Hello Stefan,
> 
> thank you for submitting this.
> 
> Does this patch urgently need to go into Core Update 169? While there
> is still an
> issue left to solve with the update, I would rather abstain from
> packing any patch
> that now comes up into it as well...
> 
> Apart from that:
> 
> Reviewed-by: Peter Müller <peter.mueller@ipfire.org>
> 
> Thanks, and best regards,
> Peter Müller
> 
> 
> > Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
> > ---
> >  config/suricata/ruleset-sources | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/config/suricata/ruleset-sources
> > b/config/suricata/ruleset-sources
> > index 1d2c6e98b..592cbedf0 100644
> > --- a/config/suricata/ruleset-sources
> > +++ b/config/suricata/ruleset-sources
> > @@ -23,7 +23,7 @@ our %Providers = (
> >                 website => "https://www.snort.org",
> >                 tr_string => "registered user rules",
> >                 requires_subscription => "True",
> > -               dl_url =>
> > "https://www.snort.org/rules/snortrules-snapshot-29190.tar.gz?oinkcode=
> > <subscription_code>",
> > +               dl_url =>
> > "https://www.snort.org/rules/snortrules-snapshot-29200.tar.gz?oinkcode=
> > <subscription_code>",
> >                 dl_type => "archive",
> >         },
> >  
> > @@ -33,7 +33,7 @@ our %Providers = (
> >                 website => "https://www.snort.org",
> >                 tr_string => "subscripted user rules",
> >                 requires_subscription => "True",
> > -               dl_url =>
> > "https://www.snort.org/rules/snortrules-snapshot-29190.tar.gz?oinkcode=
> > <subscription_code>",
> > +               dl_url =>
> > "https://www.snort.org/rules/snortrules-snapshot-29200.tar.gz?oinkcode=
> > <subscription_code>",
> >                 dl_type => "archive",
> >         },
> >
Peter Müller June 23, 2022, 5:49 p.m. UTC | #4 
Hello Stefan,

thanks for your reply.

Michael already explained the nature of this patch to me, and it is included
wit C169: https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=b77b41a579982fd6ee524f1c8ee45fea03bb9b76

Thanks for your follow-up and elaboration though. :-)

All the best,
Peter Müller


> Hello Peter,
> 
> if possible it would we great to ship this with core 169. It is simply
> a minor change and allows those who are using the rulesets from Talos
> to get the latest rules again.
> 
> Best regards,
> 
> -Stefan
>> Hello Stefan,
>>
>> thank you for submitting this.
>>
>> Does this patch urgently need to go into Core Update 169? While there
>> is still an
>> issue left to solve with the update, I would rather abstain from
>> packing any patch
>> that now comes up into it as well...
>>
>> Apart from that:
>>
>> Reviewed-by: Peter Müller <peter.mueller@ipfire.org>
>>
>> Thanks, and best regards,
>> Peter Müller
>>
>>
>>> Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
>>> ---
>>>  config/suricata/ruleset-sources | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/config/suricata/ruleset-sources
>>> b/config/suricata/ruleset-sources
>>> index 1d2c6e98b..592cbedf0 100644
>>> --- a/config/suricata/ruleset-sources
>>> +++ b/config/suricata/ruleset-sources
>>> @@ -23,7 +23,7 @@ our %Providers = (
>>>                 website => "https://www.snort.org",
>>>                 tr_string => "registered user rules",
>>>                 requires_subscription => "True",
>>> -               dl_url =>
>>> "https://www.snort.org/rules/snortrules-snapshot-29190.tar.gz?oinkcode=
>>> <subscription_code>",
>>> +               dl_url =>
>>> "https://www.snort.org/rules/snortrules-snapshot-29200.tar.gz?oinkcode=
>>> <subscription_code>",
>>>                 dl_type => "archive",
>>>         },
>>>  
>>> @@ -33,7 +33,7 @@ our %Providers = (
>>>                 website => "https://www.snort.org",
>>>                 tr_string => "subscripted user rules",
>>>                 requires_subscription => "True",
>>> -               dl_url =>
>>> "https://www.snort.org/rules/snortrules-snapshot-29190.tar.gz?oinkcode=
>>> <subscription_code>",
>>> +               dl_url =>
>>> "https://www.snort.org/rules/snortrules-snapshot-29200.tar.gz?oinkcode=
>>> <subscription_code>",
>>>                 dl_type => "archive",
>>>         },
>>>  
>
diff mbox series

Patch

diff --git a/config/suricata/ruleset-sources b/config/suricata/ruleset-sources
index 1d2c6e98b..592cbedf0 100644
--- a/config/suricata/ruleset-sources
+++ b/config/suricata/ruleset-sources
@@ -23,7 +23,7 @@  our %Providers = (
 		website => "https://www.snort.org",
 		tr_string => "registered user rules",
 		requires_subscription => "True",
-		dl_url => "https://www.snort.org/rules/snortrules-snapshot-29190.tar.gz?oinkcode=<subscription_code>",
+		dl_url => "https://www.snort.org/rules/snortrules-snapshot-29200.tar.gz?oinkcode=<subscription_code>",
 		dl_type => "archive",
 	},
 
@@ -33,7 +33,7 @@  our %Providers = (
 		website => "https://www.snort.org",
 		tr_string => "subscripted user rules",
 		requires_subscription => "True",
-		dl_url => "https://www.snort.org/rules/snortrules-snapshot-29190.tar.gz?oinkcode=<subscription_code>",
+		dl_url => "https://www.snort.org/rules/snortrules-snapshot-29200.tar.gz?oinkcode=<subscription_code>",
 		dl_type => "archive",
 	},