wakeonlan.cgi: Fix meta refresh tag

Message ID 20220420121309.1590-1-hofmann@leo-andres.de
State Accepted
Commit 154dfcb7a2ec7ab399f8ca5393987bfa8defefa9
Headers
Series wakeonlan.cgi: Fix meta refresh tag |

Commit Message

Leo-Andres Hofmann April 20, 2022, 12:13 p.m. UTC
  This fixes an HTML error that is briefly visible
on the "magic packet sent" page.

Signed-off-by: Leo-Andres Hofmann <hofmann@leo-andres.de>
---
 html/cgi-bin/wakeonlan.cgi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Peter Müller April 24, 2022, 7:12 p.m. UTC | #1
Reviewed-by: Peter Müller <peter.mueller@ipfire.org>

> This fixes an HTML error that is briefly visible
> on the "magic packet sent" page.
> 
> Signed-off-by: Leo-Andres Hofmann <hofmann@leo-andres.de>
> ---
>  html/cgi-bin/wakeonlan.cgi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/html/cgi-bin/wakeonlan.cgi b/html/cgi-bin/wakeonlan.cgi
> index c3c4c6911..e88448964 100644
> --- a/html/cgi-bin/wakeonlan.cgi
> +++ b/html/cgi-bin/wakeonlan.cgi
> @@ -173,10 +173,10 @@ if ( $cgiparams{'ACTION'} eq 'wakeup' )
>  
>    &General::system("/usr/sbin/etherwake", "-i", "$iface", "$mac");
>  
> -  # make a box with info, 'refresh' to normal screen after 5 seconds
> +  # make a box with info, 'refresh' to normal screen after 3 seconds
>    if ( $refresh eq 'yes' )
>    {
> -    &Header::openpage($Lang::tr{'WakeOnLan'}, 1, "<meta http-equiv='refresh' content='3;url=/cgi-bin/wakeonlan.cgi'");
> +    &Header::openpage($Lang::tr{'WakeOnLan'}, 1, "<meta http-equiv='refresh' content='3; url=/cgi-bin/wakeonlan.cgi'>");
>      &Header::openbigbox('100%', 'left');
>    }
>    &Header::openbox('100%', 'left', $Lang::tr{'WakeOnLan'});
  

Patch

diff --git a/html/cgi-bin/wakeonlan.cgi b/html/cgi-bin/wakeonlan.cgi
index c3c4c6911..e88448964 100644
--- a/html/cgi-bin/wakeonlan.cgi
+++ b/html/cgi-bin/wakeonlan.cgi
@@ -173,10 +173,10 @@  if ( $cgiparams{'ACTION'} eq 'wakeup' )
 
   &General::system("/usr/sbin/etherwake", "-i", "$iface", "$mac");
 
-  # make a box with info, 'refresh' to normal screen after 5 seconds
+  # make a box with info, 'refresh' to normal screen after 3 seconds
   if ( $refresh eq 'yes' )
   {
-    &Header::openpage($Lang::tr{'WakeOnLan'}, 1, "<meta http-equiv='refresh' content='3;url=/cgi-bin/wakeonlan.cgi'");
+    &Header::openpage($Lang::tr{'WakeOnLan'}, 1, "<meta http-equiv='refresh' content='3; url=/cgi-bin/wakeonlan.cgi'>");
     &Header::openbigbox('100%', 'left');
   }
   &Header::openbox('100%', 'left', $Lang::tr{'WakeOnLan'});