| Message ID | 20220403160404.5577-1-matthias.fischer@ipfire.org |
|---|---|
| State | Accepted |
| Commit | 652da33c019a9ed4bab40670c88356b18ac9cccf |
| Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4KWdy61sTgz3x1Y for <patchwork@web04.haj.ipfire.org>; Sun, 3 Apr 2022 16:04:14 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4KWdy40FcPz2cj; Sun, 3 Apr 2022 16:04:11 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4KWdy365JTz2yWd; Sun, 3 Apr 2022 16:04:11 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4KWdy26np2z2xhV for <development@lists.ipfire.org>; Sun, 3 Apr 2022 16:04:10 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4KWdy22N6Kz17R for <development@lists.ipfire.org>; Sun, 3 Apr 2022 16:04:10 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1649001850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=/HfbESzm+467icpLJ2GPew5ISPrsR5Uh49Zs5CFsEWw=; b=7O0gSWLJuAbpPvluQVfq+vGtOs3mlAPqZUgiFRY9wXL6wj100/9KKlP3gJQDBUyJChKGKn 9BP/3qyIpWoRlPDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1649001850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=/HfbESzm+467icpLJ2GPew5ISPrsR5Uh49Zs5CFsEWw=; b=PIrMTDKYuJxXxUsJO/4h4pQIWoKFGDef0duJ0oU1aoVLcqGkMWitYsJT/YScd+dzknEobz qQHUAmAIS7nVF/viFjfpbiLhK2mstyhCYA5edFq4//gH01gh0nUJR26Y+1SZ/NUrF3LpBk boNdS58t/7BTUi7aIJVwa7YWW+qNrWd+zGqVY8gjFRVgYFCPTkd43/jRHcpnmvc6yuVFOR YsiMqgaBfwaKj7jDH2DPFuAcxeDNt/j70d621Jr2ObTTnMU73jOOcECOwTg5UoyInrRs+L qLW1p5pGofcIhlt2FH8LuMDtAhJu6wGseLPmqvoWlP30/Z+bWdJjOsX7Uq/lBg== From: Matthias Fischer <matthias.fischer@ipfire.org> To: development@lists.ipfire.org Subject: [PATCH] qos.cgi: Removed last two P2P lines Date: Sun, 3 Apr 2022 18:04:04 +0200 Message-Id: <20220403160404.5577-1-matthias.fischer@ipfire.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> List-Unsubscribe: <https://lists.ipfire.org/mailman/options/development>, <mailto:development-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/development/> List-Post: <mailto:development@lists.ipfire.org> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Subscribe: <https://lists.ipfire.org/mailman/listinfo/development>, <mailto:development-request@lists.ipfire.org?subject=subscribe> Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org> |
| Series |
qos.cgi: Removed last two P2P lines
|
|
Commit Message
Matthias Fischer
April 3, 2022, 4:04 p.m. UTC
P2P "has left da house"...
Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org>
---
html/cgi-bin/qos.cgi | 2 --
1 file changed, 2 deletions(-)
Comments
Reviewed-by: Peter Müller <peter.mueller@ipfire.org> > P2P "has left da house"... > > Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org> > --- > html/cgi-bin/qos.cgi | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/html/cgi-bin/qos.cgi b/html/cgi-bin/qos.cgi > index f3bbd1bf4..6d1c61638 100644 > --- a/html/cgi-bin/qos.cgi > +++ b/html/cgi-bin/qos.cgi > @@ -474,13 +474,11 @@ imq0;200;1;$DOWN[20];$DOWN[1];;;8;VoIP; > imq0;203;4;$DOWN[20];$DOWN[1];;;0;VPN; > imq0;204;5;$DOWN[20];$DOWN[1];;;8;Webtraffic; > imq0;210;6;1;$DOWN[1];;;0;Default; > -imq0;220;7;1;$DOWN[1];;;1;P2P; > $qossettings{'RED_DEV'};101;1;$UP[10];$UP[1];;;8;ACKs; > $qossettings{'RED_DEV'};102;2;$UP[10];$UP[1];;;8;VoIP; > $qossettings{'RED_DEV'};103;4;$UP[10];$UP[1];;;2;VPN; > $qossettings{'RED_DEV'};104;5;$UP[10];$UP[1];;;8;Webtraffic; > $qossettings{'RED_DEV'};110;6;1;$UP[1];;;0;Default; > -$qossettings{'RED_DEV'};120;7;1;$UP[1];;;1;P2P; > END > ; > close FILE;
Hello Matthias, Although this mentions the phrase “P2P”, this has nothing to do with the filter. This creates a class which uses the l7 filter to match any P2P traffic and throttle it. Please drop this patch as it would create an inconsistent QoS configuration since the rules in that class are not deleted. -Michael > On 3 Apr 2022, at 17:04, Matthias Fischer <matthias.fischer@ipfire.org> wrote: > > P2P "has left da house"... > > Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org> > --- > html/cgi-bin/qos.cgi | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/html/cgi-bin/qos.cgi b/html/cgi-bin/qos.cgi > index f3bbd1bf4..6d1c61638 100644 > --- a/html/cgi-bin/qos.cgi > +++ b/html/cgi-bin/qos.cgi > @@ -474,13 +474,11 @@ imq0;200;1;$DOWN[20];$DOWN[1];;;8;VoIP; > imq0;203;4;$DOWN[20];$DOWN[1];;;0;VPN; > imq0;204;5;$DOWN[20];$DOWN[1];;;8;Webtraffic; > imq0;210;6;1;$DOWN[1];;;0;Default; > -imq0;220;7;1;$DOWN[1];;;1;P2P; > $qossettings{'RED_DEV'};101;1;$UP[10];$UP[1];;;8;ACKs; > $qossettings{'RED_DEV'};102;2;$UP[10];$UP[1];;;8;VoIP; > $qossettings{'RED_DEV'};103;4;$UP[10];$UP[1];;;2;VPN; > $qossettings{'RED_DEV'};104;5;$UP[10];$UP[1];;;8;Webtraffic; > $qossettings{'RED_DEV'};110;6;1;$UP[1];;;0;Default; > -$qossettings{'RED_DEV'};120;7;1;$UP[1];;;1;P2P; > END > ; > close FILE; > -- > 2.25.1 >
Hi, On 04.04.2022 10:34, Michael Tremer wrote: > Hello Matthias, > > Although this mentions the phrase “P2P”, this has nothing to do with the filter. Thats why I asked on the list, but didn't wait long enough. Doh! > This creates a class which uses the l7 filter to match any P2P traffic and throttle it. > > Please drop this patch as it would create an inconsistent QoS configuration since the rules in that class are not deleted. Done. Sorry for the noise. Best, Matthias > -Michael > >> On 3 Apr 2022, at 17:04, Matthias Fischer <matthias.fischer@ipfire.org> wrote: >> >> P2P "has left da house"... >> >> Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org> >> --- >> html/cgi-bin/qos.cgi | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/html/cgi-bin/qos.cgi b/html/cgi-bin/qos.cgi >> index f3bbd1bf4..6d1c61638 100644 >> --- a/html/cgi-bin/qos.cgi >> +++ b/html/cgi-bin/qos.cgi >> @@ -474,13 +474,11 @@ imq0;200;1;$DOWN[20];$DOWN[1];;;8;VoIP; >> imq0;203;4;$DOWN[20];$DOWN[1];;;0;VPN; >> imq0;204;5;$DOWN[20];$DOWN[1];;;8;Webtraffic; >> imq0;210;6;1;$DOWN[1];;;0;Default; >> -imq0;220;7;1;$DOWN[1];;;1;P2P; >> $qossettings{'RED_DEV'};101;1;$UP[10];$UP[1];;;8;ACKs; >> $qossettings{'RED_DEV'};102;2;$UP[10];$UP[1];;;8;VoIP; >> $qossettings{'RED_DEV'};103;4;$UP[10];$UP[1];;;2;VPN; >> $qossettings{'RED_DEV'};104;5;$UP[10];$UP[1];;;8;Webtraffic; >> $qossettings{'RED_DEV'};110;6;1;$UP[1];;;0;Default; >> -$qossettings{'RED_DEV'};120;7;1;$UP[1];;;1;P2P; >> END >> ; >> close FILE; >> -- >> 2.25.1 >> >
diff --git a/html/cgi-bin/qos.cgi b/html/cgi-bin/qos.cgi index f3bbd1bf4..6d1c61638 100644 --- a/html/cgi-bin/qos.cgi +++ b/html/cgi-bin/qos.cgi @@ -474,13 +474,11 @@ imq0;200;1;$DOWN[20];$DOWN[1];;;8;VoIP; imq0;203;4;$DOWN[20];$DOWN[1];;;0;VPN; imq0;204;5;$DOWN[20];$DOWN[1];;;8;Webtraffic; imq0;210;6;1;$DOWN[1];;;0;Default; -imq0;220;7;1;$DOWN[1];;;1;P2P; $qossettings{'RED_DEV'};101;1;$UP[10];$UP[1];;;8;ACKs; $qossettings{'RED_DEV'};102;2;$UP[10];$UP[1];;;8;VoIP; $qossettings{'RED_DEV'};103;4;$UP[10];$UP[1];;;2;VPN; $qossettings{'RED_DEV'};104;5;$UP[10];$UP[1];;;8;Webtraffic; $qossettings{'RED_DEV'};110;6;1;$UP[1];;;0;Default; -$qossettings{'RED_DEV'};120;7;1;$UP[1];;;1;P2P; END ; close FILE;