misc-progs: Set a reasonable default PATH variable

Message ID 20220321190706.2969988-1-michael.tremer@ipfire.org
State Accepted
Commit 136d91f3463445c8ee525d98f06f82d5a028784e
Headers
Series misc-progs: Set a reasonable default PATH variable |

Commit Message

Michael Tremer March 21, 2022, 7:07 p.m. UTC
  We have some scripts in /usr/local/bin which cannot be found by any
misc-progs which is fixed by this patch.

Fixes: #12811
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---
 src/misc-progs/setuid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Peter Müller March 21, 2022, 7:11 p.m. UTC | #1
Reviewed-by: Peter Müller <peter.mueller@ipfire.org>

> We have some scripts in /usr/local/bin which cannot be found by any
> misc-progs which is fixed by this patch.
> 
> Fixes: #12811
> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
> ---
>  src/misc-progs/setuid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/misc-progs/setuid.c b/src/misc-progs/setuid.c
> index 8044742f2..831fb1f90 100644
> --- a/src/misc-progs/setuid.c
> +++ b/src/misc-progs/setuid.c
> @@ -46,7 +46,7 @@
>  
>  /* Trusted environment for executing commands */
>  char * trusted_env[4] = {
> -	"PATH=/usr/bin:/usr/sbin:/sbin:/bin",
> +	"PATH=/usr/local/bin:/usr/local/sbin:/sbin:/usr/sbin:/bin:/usr/bin",
>  	"SHELL=/bin/sh",
>  	"TERM=dumb",
>  	NULL
  

Patch

diff --git a/src/misc-progs/setuid.c b/src/misc-progs/setuid.c
index 8044742f2..831fb1f90 100644
--- a/src/misc-progs/setuid.c
+++ b/src/misc-progs/setuid.c
@@ -46,7 +46,7 @@ 
 
 /* Trusted environment for executing commands */
 char * trusted_env[4] = {
-	"PATH=/usr/bin:/usr/sbin:/sbin:/bin",
+	"PATH=/usr/local/bin:/usr/local/sbin:/sbin:/usr/sbin:/bin:/usr/bin",
 	"SHELL=/bin/sh",
 	"TERM=dumb",
 	NULL