diff mbox series

advoptions-list: Add additional dhcp options - fixes bug 12291

Message ID 20211226215512.3525919-1-adolf.belka@ipfire.org
State Accepted
Commit 4df6daf381223ecc040df3c1baed246782fd9cd2
Headers
Series advoptions-list: Add additional dhcp options - fixes bug 12291 |

Commit Message

Adolf Belka Dec. 26, 2021, 9:55 p.m. UTC 
  - Add ms-classless-static-routes and rfc3442-classless-static-routes as options for dhcp
   These are apparently required for deployiong classless IP routes
- Original static-routes option is not intended for classless IP routing but is being
   left in place for backward compatibility
- The option "rfc3442-classless-static-routes" is for normal clients
- The option "ms-classless-static-routes" is for Microsoft clients

Fixes: bug 12291
Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
---
 config/cfgroot/advoptions-list | 2 ++
 1 file changed, 2 insertions(+)

Comments

Michael Tremer Dec. 27, 2021, 10:36 a.m. UTC | #1 
Reviewed-by: Michael Tremer <michael.tremer@ipfire.org>

Thank you for posting this to the list.

-Michael

> On 26 Dec 2021, at 22:55, Adolf Belka <adolf.belka@ipfire.org> wrote:
> 
> - Add ms-classless-static-routes and rfc3442-classless-static-routes as options for dhcp
>   These are apparently required for deployiong classless IP routes
> - Original static-routes option is not intended for classless IP routing but is being
>   left in place for backward compatibility
> - The option "rfc3442-classless-static-routes" is for normal clients
> - The option "ms-classless-static-routes" is for Microsoft clients

LOL Normal vs. Microsoft :)

> 
> Fixes: bug 12291
> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
> ---
> config/cfgroot/advoptions-list | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/config/cfgroot/advoptions-list b/config/cfgroot/advoptions-list
> index 8a1e75ebb..6330aefde 100644
> --- a/config/cfgroot/advoptions-list
> +++ b/config/cfgroot/advoptions-list
> @@ -22,6 +22,7 @@ option mask-supplier flag;
> option max-dgram-reassembly uint16;
> option merit-dump string;
> option mobile-ip-home-agent ip-address [, ip-address... ];
> +option ms-classless-static-routes string;
> option netbios-dd-server ip-address [, ip-address... ];
> option netbios-node-type uint8;
> option netbios-scope string;
> @@ -38,6 +39,7 @@ option perform-mask-discovery flag;
> option policy-filter ip-address ip-address [, ip-address ip-address... ];
> option pop-server ip-address [, ip-address... ];
> option resource-location-servers ip-address [, ip-address... ];
> +option rfc3442-classless-static-routes string;
> option root-path string;
> option router-discovery flag;
> option router-solicitation-address ip-address;
> -- 
> 2.34.1
>
Peter Müller Dec. 27, 2021, 6:49 p.m. UTC | #2 
Reviewed-by: Peter Müller <peter.mueller@ipfire.org>

> - Add ms-classless-static-routes and rfc3442-classless-static-routes as options for dhcp
>    These are apparently required for deployiong classless IP routes
> - Original static-routes option is not intended for classless IP routing but is being
>    left in place for backward compatibility
> - The option "rfc3442-classless-static-routes" is for normal clients
> - The option "ms-classless-static-routes" is for Microsoft clients
> 
> Fixes: bug 12291
> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
> ---
>  config/cfgroot/advoptions-list | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/config/cfgroot/advoptions-list b/config/cfgroot/advoptions-list
> index 8a1e75ebb..6330aefde 100644
> --- a/config/cfgroot/advoptions-list
> +++ b/config/cfgroot/advoptions-list
> @@ -22,6 +22,7 @@ option mask-supplier flag;
>  option max-dgram-reassembly uint16;
>  option merit-dump string;
>  option mobile-ip-home-agent ip-address [, ip-address... ];
> +option ms-classless-static-routes string;
>  option netbios-dd-server ip-address [, ip-address... ];
>  option netbios-node-type uint8;
>  option netbios-scope string;
> @@ -38,6 +39,7 @@ option perform-mask-discovery flag;
>  option policy-filter ip-address ip-address [, ip-address ip-address... ];
>  option pop-server ip-address [, ip-address... ];
>  option resource-location-servers ip-address [, ip-address... ];
> +option rfc3442-classless-static-routes string;
>  option root-path string;
>  option router-discovery flag;
>  option router-solicitation-address ip-address;
>
diff mbox series

Patch

diff --git a/config/cfgroot/advoptions-list b/config/cfgroot/advoptions-list
index 8a1e75ebb..6330aefde 100644
--- a/config/cfgroot/advoptions-list
+++ b/config/cfgroot/advoptions-list
@@ -22,6 +22,7 @@  option mask-supplier flag;
 option max-dgram-reassembly uint16;
 option merit-dump string;
 option mobile-ip-home-agent ip-address [, ip-address... ];
+option ms-classless-static-routes string;
 option netbios-dd-server ip-address [, ip-address... ];
 option netbios-node-type uint8;
 option netbios-scope string;
@@ -38,6 +39,7 @@  option perform-mask-discovery flag;
 option policy-filter ip-address ip-address [, ip-address ip-address... ];
 option pop-server ip-address [, ip-address... ];
 option resource-location-servers ip-address [, ip-address... ];
+option rfc3442-classless-static-routes string;
 option root-path string;
 option router-discovery flag;
 option router-solicitation-address ip-address;