backup definitions: housekeeping to remove orphaned definitions

Message ID 20211023115451.3442894-1-adolf.belka@ipfire.org
State Accepted
Commit 71b06657f986715b23b7a5cfbdf1553d85a33eb7
Headers
Series backup definitions: housekeeping to remove orphaned definitions |

Commit Message

Adolf Belka Oct. 23, 2021, 11:54 a.m. UTC
  - check_mk_agent, client175 & lcr are addons that have been removed so the backup
   definitions are no longer required.
- dma is not a package but a core program and has its config backup requirements
   built into the core backup include file so the addon backup definition is not
   used or needed.
- No issues found in the build after these files were removed.

Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
---
 config/backup/includes/check_mk_agent | 1 -
 config/backup/includes/client175      | 2 --
 config/backup/includes/dma            | 5 -----
 config/backup/includes/lcr            | 6 ------
 4 files changed, 14 deletions(-)
 delete mode 100644 config/backup/includes/check_mk_agent
 delete mode 100644 config/backup/includes/client175
 delete mode 100644 config/backup/includes/dma
 delete mode 100644 config/backup/includes/lcr
  

Comments

Peter Müller Oct. 23, 2021, 12:25 p.m. UTC | #1
Reviewed-by: Peter Müller <peter.mueller@ipfire.org>

> - check_mk_agent, client175 & lcr are addons that have been removed so the backup
>    definitions are no longer required.
> - dma is not a package but a core program and has its config backup requirements
>    built into the core backup include file so the addon backup definition is not
>    used or needed.
> - No issues found in the build after these files were removed.
> 
> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
> ---
>  config/backup/includes/check_mk_agent | 1 -
>  config/backup/includes/client175      | 2 --
>  config/backup/includes/dma            | 5 -----
>  config/backup/includes/lcr            | 6 ------
>  4 files changed, 14 deletions(-)
>  delete mode 100644 config/backup/includes/check_mk_agent
>  delete mode 100644 config/backup/includes/client175
>  delete mode 100644 config/backup/includes/dma
>  delete mode 100644 config/backup/includes/lcr
> 
> diff --git a/config/backup/includes/check_mk_agent b/config/backup/includes/check_mk_agent
> deleted file mode 100644
> index ca710461b..000000000
> --- a/config/backup/includes/check_mk_agent
> +++ /dev/null
> @@ -1 +0,0 @@
> -/etc/check_mk/
> diff --git a/config/backup/includes/client175 b/config/backup/includes/client175
> deleted file mode 100644
> index 6cde8e8ca..000000000
> --- a/config/backup/includes/client175
> +++ /dev/null
> @@ -1,2 +0,0 @@
> -/src/client175/site.conf
> -/var/ipfire/mpfire/*.m3u
> diff --git a/config/backup/includes/dma b/config/backup/includes/dma
> deleted file mode 100644
> index 7c7520551..000000000
> --- a/config/backup/includes/dma
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -/var/ipfire/dma
> -/var/ipfire/dma/dma.conf
> -/var/ipfire/dma/auth.conf
> -/var/ipfire/dma/mail.conf
> -/var/spool/dma
> diff --git a/config/backup/includes/lcr b/config/backup/includes/lcr
> deleted file mode 100644
> index 618f4c784..000000000
> --- a/config/backup/includes/lcr
> +++ /dev/null
> @@ -1,6 +0,0 @@
> -/var/ipfire/lcr/extensions
> -/var/ipfire/lcr/directory.list
> -/var/ipfire/lcr/interface.conf
> -/var/ipfire/lcr/options.conf
> -/var/ipfire/lcr/routing.conf
> -/var/log/lcr
>
  
Michael Tremer Oct. 25, 2021, 6:33 p.m. UTC | #2
Reviewed-by: Michael Tremer <michael.tremer@ipfire.org>

> On 23 Oct 2021, at 12:54, Adolf Belka <adolf.belka@ipfire.org> wrote:
> 
> - check_mk_agent, client175 & lcr are addons that have been removed so the backup
>   definitions are no longer required.
> - dma is not a package but a core program and has its config backup requirements
>   built into the core backup include file so the addon backup definition is not
>   used or needed.
> - No issues found in the build after these files were removed.
> 
> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
> ---
> config/backup/includes/check_mk_agent | 1 -
> config/backup/includes/client175      | 2 --
> config/backup/includes/dma            | 5 -----
> config/backup/includes/lcr            | 6 ------
> 4 files changed, 14 deletions(-)
> delete mode 100644 config/backup/includes/check_mk_agent
> delete mode 100644 config/backup/includes/client175
> delete mode 100644 config/backup/includes/dma
> delete mode 100644 config/backup/includes/lcr
> 
> diff --git a/config/backup/includes/check_mk_agent b/config/backup/includes/check_mk_agent
> deleted file mode 100644
> index ca710461b..000000000
> --- a/config/backup/includes/check_mk_agent
> +++ /dev/null
> @@ -1 +0,0 @@
> -/etc/check_mk/
> diff --git a/config/backup/includes/client175 b/config/backup/includes/client175
> deleted file mode 100644
> index 6cde8e8ca..000000000
> --- a/config/backup/includes/client175
> +++ /dev/null
> @@ -1,2 +0,0 @@
> -/src/client175/site.conf
> -/var/ipfire/mpfire/*.m3u
> diff --git a/config/backup/includes/dma b/config/backup/includes/dma
> deleted file mode 100644
> index 7c7520551..000000000
> --- a/config/backup/includes/dma
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -/var/ipfire/dma
> -/var/ipfire/dma/dma.conf
> -/var/ipfire/dma/auth.conf
> -/var/ipfire/dma/mail.conf
> -/var/spool/dma
> diff --git a/config/backup/includes/lcr b/config/backup/includes/lcr
> deleted file mode 100644
> index 618f4c784..000000000
> --- a/config/backup/includes/lcr
> +++ /dev/null
> @@ -1,6 +0,0 @@
> -/var/ipfire/lcr/extensions
> -/var/ipfire/lcr/directory.list
> -/var/ipfire/lcr/interface.conf
> -/var/ipfire/lcr/options.conf
> -/var/ipfire/lcr/routing.conf
> -/var/log/lcr
> -- 
> 2.33.1
>
  

Patch

diff --git a/config/backup/includes/check_mk_agent b/config/backup/includes/check_mk_agent
deleted file mode 100644
index ca710461b..000000000
--- a/config/backup/includes/check_mk_agent
+++ /dev/null
@@ -1 +0,0 @@ 
-/etc/check_mk/
diff --git a/config/backup/includes/client175 b/config/backup/includes/client175
deleted file mode 100644
index 6cde8e8ca..000000000
--- a/config/backup/includes/client175
+++ /dev/null
@@ -1,2 +0,0 @@ 
-/src/client175/site.conf
-/var/ipfire/mpfire/*.m3u
diff --git a/config/backup/includes/dma b/config/backup/includes/dma
deleted file mode 100644
index 7c7520551..000000000
--- a/config/backup/includes/dma
+++ /dev/null
@@ -1,5 +0,0 @@ 
-/var/ipfire/dma
-/var/ipfire/dma/dma.conf
-/var/ipfire/dma/auth.conf
-/var/ipfire/dma/mail.conf
-/var/spool/dma
diff --git a/config/backup/includes/lcr b/config/backup/includes/lcr
deleted file mode 100644
index 618f4c784..000000000
--- a/config/backup/includes/lcr
+++ /dev/null
@@ -1,6 +0,0 @@ 
-/var/ipfire/lcr/extensions
-/var/ipfire/lcr/directory.list
-/var/ipfire/lcr/interface.conf
-/var/ipfire/lcr/options.conf
-/var/ipfire/lcr/routing.conf
-/var/log/lcr