| Message ID | 20211008171905.2205-1-matthias.fischer@ipfire.org |
|---|---|
| State | Accepted |
| Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4HQw0L1mSpz3xWd for <patchwork@web04.haj.ipfire.org>; Fri, 8 Oct 2021 17:19:14 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4HQw0H2bk6zpW; Fri, 8 Oct 2021 17:19:11 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4HQw0G6RxWz2yWb; Fri, 8 Oct 2021 17:19:10 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4HQw0G0vL4z2xLF for <development@lists.ipfire.org>; Fri, 8 Oct 2021 17:19:10 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4HQw0F2bqmzpW for <development@lists.ipfire.org>; Fri, 8 Oct 2021 17:19:09 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1633713549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc; bh=U3Kr+ii8cFLO1jYyGnC6VkKJkjdavs2Les8wj0JuN90=; b=EiOSOx9oaJEnPUTP7/g8ancE6pxDvUWiEJ9dLyjT685I4VzDai+gtcp1TndvSRiOnWocg7 F0G3KkO6VX6I9cAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1633713549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc; bh=U3Kr+ii8cFLO1jYyGnC6VkKJkjdavs2Les8wj0JuN90=; b=ujW7tElOFEaMUVqqKSARZqz1getxNMF5B5yViAwAR4OpbispkDIP7PlH8CSp6s2y3IuYye EZrljAiJf9GjpZtG/PjZY0zTmRtWijyO2+sTZCKoHplX9HKf/AE6qtrtAQaQ6LV4IP8awH PNI7QPjlCl2ubsD1dLEr6euRZQgDFz7+B1iNULaOGiQayRNW3Z/UGNQcX15O8gdOze6Sbu fDKD1qbOxdM+56cQnhFRz//tVHstUdI8+PoTzhujfBrMESCl3MPBMZJEhJDfDKofGV64aI JAqXE8f5hzJzl67iWEHj7G2hmj5DKa9+zaTKYgjMzu5mIPPiEykTPRlKcRAFOg== From: Matthias Fischer <matthias.fischer@ipfire.org> To: development@lists.ipfire.org Subject: [PATCH] squid: Update to 5.2 Date: Fri, 8 Oct 2021 19:19:05 +0200 Message-Id: <20211008171905.2205-1-matthias.fischer@ipfire.org> X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> List-Unsubscribe: <https://lists.ipfire.org/mailman/options/development>, <mailto:development-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/development/> List-Post: <mailto:development@lists.ipfire.org> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Subscribe: <https://lists.ipfire.org/mailman/listinfo/development>, <mailto:development-request@lists.ipfire.org?subject=subscribe> Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org> |
| Series |
squid: Update to 5.2
|
|
Commit Message
Matthias Fischer
Oct. 8, 2021, 5:19 p.m. UTC
For details see:
http://www.squid-cache.org/Versions/v5/changesets/
Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org>
---
lfs/squid | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
Reviewed-by: Adolf Belka <adolf.belka@ipfire.org> On 08/10/2021 19:19, Matthias Fischer wrote: > For details see: > http://www.squid-cache.org/Versions/v5/changesets/ > > Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org> > --- > lfs/squid | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lfs/squid b/lfs/squid > index c56dca7de..5e9648aba 100644 > --- a/lfs/squid > +++ b/lfs/squid > @@ -24,7 +24,7 @@ > > include Config > > -VER = 5.1 > +VER = 5.2 > > THISAPP = squid-$(VER) > DL_FILE = $(THISAPP).tar.xz > @@ -46,7 +46,7 @@ objects = $(DL_FILE) > > $(DL_FILE) = $(DL_FROM)/$(DL_FILE) > > -$(DL_FILE)_MD5 = 17be9709b54fe0146452113404be7b54 > +$(DL_FILE)_MD5 = 102984f3ea382a1fa5bd917c2ee155ec > > install : $(TARGET) >
Hey, Are we ready to got to squid 5, yet? I thought there were some remaining changes required in the CGI file? -Michael > On 8 Oct 2021, at 18:19, Matthias Fischer <matthias.fischer@ipfire.org> wrote: > > For details see: > http://www.squid-cache.org/Versions/v5/changesets/ > > Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org> > --- > lfs/squid | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lfs/squid b/lfs/squid > index c56dca7de..5e9648aba 100644 > --- a/lfs/squid > +++ b/lfs/squid > @@ -24,7 +24,7 @@ > > include Config > > -VER = 5.1 > +VER = 5.2 > > THISAPP = squid-$(VER) > DL_FILE = $(THISAPP).tar.xz > @@ -46,7 +46,7 @@ objects = $(DL_FILE) > > $(DL_FILE) = $(DL_FROM)/$(DL_FILE) > > -$(DL_FILE)_MD5 = 17be9709b54fe0146452113404be7b54 > +$(DL_FILE)_MD5 = 102984f3ea382a1fa5bd917c2ee155ec > > install : $(TARGET) > > -- > 2.18.0 >
Hi, On 09.10.2021 14:06, Michael Tremer wrote: > Hey, > > Are we ready to got to squid 5, yet? Up and running here, but... > I thought there were some remaining changes required in the CGI file? ...the question is whether we adopt the new maximum of 32k filedescriptors as a fixed setting and remove the corresponding adjustment field or leave the user the possibility to influence these settings via GUI. I'm testing here with '16384' and didn't see any problem with that. If it is desired I can of course remove the setting, I just didn't see the need so far. > -Michael > >> On 8 Oct 2021, at 18:19, Matthias Fischer <matthias.fischer@ipfire.org> wrote: >> >> For details see: >> http://www.squid-cache.org/Versions/v5/changesets/ >> >> Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org> >> --- >> lfs/squid | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/lfs/squid b/lfs/squid >> index c56dca7de..5e9648aba 100644 >> --- a/lfs/squid >> +++ b/lfs/squid >> @@ -24,7 +24,7 @@ >> >> include Config >> >> -VER = 5.1 >> +VER = 5.2 >> >> THISAPP = squid-$(VER) >> DL_FILE = $(THISAPP).tar.xz >> @@ -46,7 +46,7 @@ objects = $(DL_FILE) >> >> $(DL_FILE) = $(DL_FROM)/$(DL_FILE) >> >> -$(DL_FILE)_MD5 = 17be9709b54fe0146452113404be7b54 >> +$(DL_FILE)_MD5 = 102984f3ea382a1fa5bd917c2ee155ec >> >> install : $(TARGET) >> >> -- >> 2.18.0 >> >
Hello, I would say that 16k should be fine. 32k would be even better. It probably only becomes a problem on a very busy proxy with a lot of open (but idle) connections. -Michael > On 9 Oct 2021, at 13:46, Matthias Fischer <matthias.fischer@ipfire.org> wrote: > > Hi, > > On 09.10.2021 14:06, Michael Tremer wrote: >> Hey, >> >> Are we ready to got to squid 5, yet? > > Up and running here, but... > >> I thought there were some remaining changes required in the CGI file? > > ...the question is whether we adopt the new maximum of 32k > filedescriptors as a fixed setting and remove the corresponding > adjustment field or leave the user the possibility to influence these > settings via GUI. > > I'm testing here with '16384' and didn't see any problem with that. If > it is desired I can of course remove the setting, I just didn't see the > need so far. > >> -Michael >> >>> On 8 Oct 2021, at 18:19, Matthias Fischer <matthias.fischer@ipfire.org> wrote: >>> >>> For details see: >>> http://www.squid-cache.org/Versions/v5/changesets/ >>> >>> Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org> >>> --- >>> lfs/squid | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/lfs/squid b/lfs/squid >>> index c56dca7de..5e9648aba 100644 >>> --- a/lfs/squid >>> +++ b/lfs/squid >>> @@ -24,7 +24,7 @@ >>> >>> include Config >>> >>> -VER = 5.1 >>> +VER = 5.2 >>> >>> THISAPP = squid-$(VER) >>> DL_FILE = $(THISAPP).tar.xz >>> @@ -46,7 +46,7 @@ objects = $(DL_FILE) >>> >>> $(DL_FILE) = $(DL_FROM)/$(DL_FILE) >>> >>> -$(DL_FILE)_MD5 = 17be9709b54fe0146452113404be7b54 >>> +$(DL_FILE)_MD5 = 102984f3ea382a1fa5bd917c2ee155ec >>> >>> install : $(TARGET) >>> >>> -- >>> 2.18.0 >>> >> >
Hi, On 09.10.2021 14:47, Michael Tremer wrote: > Hello, > > I would say that 16k should be fine. 32k would be even better. > > It probably only becomes a problem on a very busy proxy with a lot of open (but idle) connections. This leaves me in the state "Remove or not?" ;-) My two cents: Let the user decide and leave this setting as it is... Opinions? Matthias > -Michael > >> On 9 Oct 2021, at 13:46, Matthias Fischer <matthias.fischer@ipfire.org> wrote: >> >> Hi, >> >> On 09.10.2021 14:06, Michael Tremer wrote: >>> Hey, >>> >>> Are we ready to got to squid 5, yet? >> >> Up and running here, but... >> >>> I thought there were some remaining changes required in the CGI file? >> >> ...the question is whether we adopt the new maximum of 32k >> filedescriptors as a fixed setting and remove the corresponding >> adjustment field or leave the user the possibility to influence these >> settings via GUI. >> >> I'm testing here with '16384' and didn't see any problem with that. If >> it is desired I can of course remove the setting, I just didn't see the >> need so far. >> >>> -Michael >>> >>>> On 8 Oct 2021, at 18:19, Matthias Fischer <matthias.fischer@ipfire.org> wrote: >>>> >>>> For details see: >>>> http://www.squid-cache.org/Versions/v5/changesets/ >>>> >>>> Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org> >>>> --- >>>> lfs/squid | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/lfs/squid b/lfs/squid >>>> index c56dca7de..5e9648aba 100644 >>>> --- a/lfs/squid >>>> +++ b/lfs/squid >>>> @@ -24,7 +24,7 @@ >>>> >>>> include Config >>>> >>>> -VER = 5.1 >>>> +VER = 5.2 >>>> >>>> THISAPP = squid-$(VER) >>>> DL_FILE = $(THISAPP).tar.xz >>>> @@ -46,7 +46,7 @@ objects = $(DL_FILE) >>>> >>>> $(DL_FILE) = $(DL_FROM)/$(DL_FILE) >>>> >>>> -$(DL_FILE)_MD5 = 17be9709b54fe0146452113404be7b54 >>>> +$(DL_FILE)_MD5 = 102984f3ea382a1fa5bd917c2ee155ec >>>> >>>> install : $(TARGET) >>>> >>>> -- >>>> 2.18.0 >>>> >>> >> >
Hello, > On 9 Oct 2021, at 14:00, Matthias Fischer <matthias.fischer@ipfire.org> wrote: > > Hi, > > On 09.10.2021 14:47, Michael Tremer wrote: >> Hello, >> >> I would say that 16k should be fine. 32k would be even better. >> >> It probably only becomes a problem on a very busy proxy with a lot of open (but idle) connections. > > This leaves me in the state "Remove or not?" ;-) > > My two cents: Let the user decide and leave this setting as it is... My metric always is: If we don’t know, how does the user? The only thing we don’t know is how many connections the user is expecting. But we know the technical details. Let’s do it 32k and if that isn’t enough someone will open a bug report. -Michael > Opinions? > > Matthias > >> -Michael >> >>> On 9 Oct 2021, at 13:46, Matthias Fischer <matthias.fischer@ipfire.org> wrote: >>> >>> Hi, >>> >>> On 09.10.2021 14:06, Michael Tremer wrote: >>>> Hey, >>>> >>>> Are we ready to got to squid 5, yet? >>> >>> Up and running here, but... >>> >>>> I thought there were some remaining changes required in the CGI file? >>> >>> ...the question is whether we adopt the new maximum of 32k >>> filedescriptors as a fixed setting and remove the corresponding >>> adjustment field or leave the user the possibility to influence these >>> settings via GUI. >>> >>> I'm testing here with '16384' and didn't see any problem with that. If >>> it is desired I can of course remove the setting, I just didn't see the >>> need so far. >>> >>>> -Michael >>>> >>>>> On 8 Oct 2021, at 18:19, Matthias Fischer <matthias.fischer@ipfire.org> wrote: >>>>> >>>>> For details see: >>>>> http://www.squid-cache.org/Versions/v5/changesets/ >>>>> >>>>> Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org> >>>>> --- >>>>> lfs/squid | 4 ++-- >>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/lfs/squid b/lfs/squid >>>>> index c56dca7de..5e9648aba 100644 >>>>> --- a/lfs/squid >>>>> +++ b/lfs/squid >>>>> @@ -24,7 +24,7 @@ >>>>> >>>>> include Config >>>>> >>>>> -VER = 5.1 >>>>> +VER = 5.2 >>>>> >>>>> THISAPP = squid-$(VER) >>>>> DL_FILE = $(THISAPP).tar.xz >>>>> @@ -46,7 +46,7 @@ objects = $(DL_FILE) >>>>> >>>>> $(DL_FILE) = $(DL_FROM)/$(DL_FILE) >>>>> >>>>> -$(DL_FILE)_MD5 = 17be9709b54fe0146452113404be7b54 >>>>> +$(DL_FILE)_MD5 = 102984f3ea382a1fa5bd917c2ee155ec >>>>> >>>>> install : $(TARGET) >>>>> >>>>> -- >>>>> 2.18.0 >>>>> >>>> >>> >> >
diff --git a/lfs/squid b/lfs/squid index c56dca7de..5e9648aba 100644 --- a/lfs/squid +++ b/lfs/squid @@ -24,7 +24,7 @@ include Config -VER = 5.1 +VER = 5.2 THISAPP = squid-$(VER) DL_FILE = $(THISAPP).tar.xz @@ -46,7 +46,7 @@ objects = $(DL_FILE) $(DL_FILE) = $(DL_FROM)/$(DL_FILE) -$(DL_FILE)_MD5 = 17be9709b54fe0146452113404be7b54 +$(DL_FILE)_MD5 = 102984f3ea382a1fa5bd917c2ee155ec install : $(TARGET)