[03/13] kernel: Disable IRQ time accounting

Message ID 20210917114229.10704-3-michael.tremer@ipfire.org
State New
Headers show
Series [01/13] kernel: Change timer tick to 1000Hz | expand

Commit Message

Michael Tremer Sept. 17, 2021, 11:42 a.m. UTC
This feature is now disabled (was disabled on ARM before) as we do not
need it:

"Select this option to enable fine granularity task irq time accounting.
This is done by reading a timestamp on each transitions between softirq
and hardirq state, so there can be a small performance impact."

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---
 config/kernel/kernel.config.i586-ipfire   | 2 +-
 config/kernel/kernel.config.x86_64-ipfire | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Peter Müller Sept. 18, 2021, 4:10 p.m. UTC | #1
Thanks for cleaning this up. :-)

Acked-by: Peter Müller <peter.mueller@ipfire.org>


> This feature is now disabled (was disabled on ARM before) as we do not
> need it:
> 
> "Select this option to enable fine granularity task irq time accounting.
> This is done by reading a timestamp on each transitions between softirq
> and hardirq state, so there can be a small performance impact."
> 
> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
> ---
>   config/kernel/kernel.config.i586-ipfire   | 2 +-
>   config/kernel/kernel.config.x86_64-ipfire | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/config/kernel/kernel.config.i586-ipfire b/config/kernel/kernel.config.i586-ipfire
> index b159db581..ff94e949e 100644
> --- a/config/kernel/kernel.config.i586-ipfire
> +++ b/config/kernel/kernel.config.i586-ipfire
> @@ -103,7 +103,7 @@ CONFIG_PREEMPT_VOLUNTARY=y
>   # CPU/Task time and stats accounting
>   #
>   CONFIG_TICK_CPU_ACCOUNTING=y
> -CONFIG_IRQ_TIME_ACCOUNTING=y
> +# CONFIG_IRQ_TIME_ACCOUNTING is not set
>   CONFIG_HAVE_SCHED_AVG_IRQ=y
>   CONFIG_BSD_PROCESS_ACCT=y
>   # CONFIG_BSD_PROCESS_ACCT_V3 is not set
> diff --git a/config/kernel/kernel.config.x86_64-ipfire b/config/kernel/kernel.config.x86_64-ipfire
> index bf738bda5..43c483f00 100644
> --- a/config/kernel/kernel.config.x86_64-ipfire
> +++ b/config/kernel/kernel.config.x86_64-ipfire
> @@ -107,7 +107,7 @@ CONFIG_PREEMPT_VOLUNTARY=y
>   #
>   CONFIG_TICK_CPU_ACCOUNTING=y
>   # CONFIG_VIRT_CPU_ACCOUNTING_GEN is not set
> -CONFIG_IRQ_TIME_ACCOUNTING=y
> +# CONFIG_IRQ_TIME_ACCOUNTING is not set
>   CONFIG_HAVE_SCHED_AVG_IRQ=y
>   CONFIG_BSD_PROCESS_ACCT=y
>   # CONFIG_BSD_PROCESS_ACCT_V3 is not set
>

Patch

diff --git a/config/kernel/kernel.config.i586-ipfire b/config/kernel/kernel.config.i586-ipfire
index b159db581..ff94e949e 100644
--- a/config/kernel/kernel.config.i586-ipfire
+++ b/config/kernel/kernel.config.i586-ipfire
@@ -103,7 +103,7 @@  CONFIG_PREEMPT_VOLUNTARY=y
 # CPU/Task time and stats accounting
 #
 CONFIG_TICK_CPU_ACCOUNTING=y
-CONFIG_IRQ_TIME_ACCOUNTING=y
+# CONFIG_IRQ_TIME_ACCOUNTING is not set
 CONFIG_HAVE_SCHED_AVG_IRQ=y
 CONFIG_BSD_PROCESS_ACCT=y
 # CONFIG_BSD_PROCESS_ACCT_V3 is not set
diff --git a/config/kernel/kernel.config.x86_64-ipfire b/config/kernel/kernel.config.x86_64-ipfire
index bf738bda5..43c483f00 100644
--- a/config/kernel/kernel.config.x86_64-ipfire
+++ b/config/kernel/kernel.config.x86_64-ipfire
@@ -107,7 +107,7 @@  CONFIG_PREEMPT_VOLUNTARY=y
 #
 CONFIG_TICK_CPU_ACCOUNTING=y
 # CONFIG_VIRT_CPU_ACCOUNTING_GEN is not set
-CONFIG_IRQ_TIME_ACCOUNTING=y
+# CONFIG_IRQ_TIME_ACCOUNTING is not set
 CONFIG_HAVE_SCHED_AVG_IRQ=y
 CONFIG_BSD_PROCESS_ACCT=y
 # CONFIG_BSD_PROCESS_ACCT_V3 is not set