getrrdimage.cgi: Fix supported origins list

Message ID 20210807204207.1713-1-hofmann@leo-andres.de
State Accepted
Commit 6eb9d445bc2f7bbe6ee38bceb954032ebcb44a1c
Headers show
Series getrrdimage.cgi: Fix supported origins list | expand

Commit Message

Leo Hofmann Aug. 7, 2021, 8:42 p.m. UTC
Support for the graphs of "services.cgi" is implemented,
but it was forgotten to add this to the list of origins.
This patch fixes the list and prevents possibly missing graphs.

Signed-off-by: Leo-Andres Hofmann <hofmann@leo-andres.de>
---

Well, to be honest, I just missed it while copy-pasting the origins and never checked that list again.

 html/cgi-bin/getrrdimage.cgi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Bernhard Bitsch Aug. 7, 2021, 9:11 p.m. UTC | #1
Reviewed-by: Bernhard Bitsch <bbitsch@ipfire.org>

Am 07.08.2021 um 22:42 schrieb Leo-Andres Hofmann:
> Support for the graphs of "services.cgi" is implemented,
> but it was forgotten to add this to the list of origins.
> This patch fixes the list and prevents possibly missing graphs.
> 
> Signed-off-by: Leo-Andres Hofmann <hofmann@leo-andres.de>
> ---
> 
> Well, to be honest, I just missed it while copy-pasting the origins and never checked that list again.
> 
>   html/cgi-bin/getrrdimage.cgi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/html/cgi-bin/getrrdimage.cgi b/html/cgi-bin/getrrdimage.cgi
> index 92f8b585d..26bcf0905 100644
> --- a/html/cgi-bin/getrrdimage.cgi
> +++ b/html/cgi-bin/getrrdimage.cgi
> @@ -36,8 +36,8 @@ require "${General::swroot}/graphs.pl";
>   # List of graph origins that getrrdimage.cgi can process directly
>   # (unknown origins are forwarded to ensure compatibility)
>   my @supported_origins = ("entropy.cgi", "hardwaregraphs.cgi", "media.cgi",
> -	"memory.cgi","netexternal.cgi", "netinternal.cgi", "netother.cgi",
> -	"netovpnrw.cgi", "netovpnsrv.cgi", "qos.cgi", "system.cgi");
> +	"memory.cgi", "netexternal.cgi", "netinternal.cgi", "netother.cgi",
> +	"netovpnrw.cgi", "netovpnsrv.cgi", "qos.cgi", "services.cgi", "system.cgi");
>   
>   ### Process GET parameters ###
>   # URL format: /?origin=[graph origin cgi]&graph=[graph name]&range=[time range]
>

Patch

diff --git a/html/cgi-bin/getrrdimage.cgi b/html/cgi-bin/getrrdimage.cgi
index 92f8b585d..26bcf0905 100644
--- a/html/cgi-bin/getrrdimage.cgi
+++ b/html/cgi-bin/getrrdimage.cgi
@@ -36,8 +36,8 @@  require "${General::swroot}/graphs.pl";
 # List of graph origins that getrrdimage.cgi can process directly
 # (unknown origins are forwarded to ensure compatibility)
 my @supported_origins = ("entropy.cgi", "hardwaregraphs.cgi", "media.cgi",
-	"memory.cgi","netexternal.cgi", "netinternal.cgi", "netother.cgi",
-	"netovpnrw.cgi", "netovpnsrv.cgi", "qos.cgi", "system.cgi");
+	"memory.cgi", "netexternal.cgi", "netinternal.cgi", "netother.cgi",
+	"netovpnrw.cgi", "netovpnsrv.cgi", "qos.cgi", "services.cgi", "system.cgi");
 
 ### Process GET parameters ###
 # URL format: /?origin=[graph origin cgi]&graph=[graph name]&range=[time range]