diff mbox series

[1/3] firewall.cgi: Remove faulty assignments for selected hash.

Message ID 20210711175419.3582-1-stefan.schantl@ipfire.org
State Accepted
Commit 0e9b16472230a7f1022cebc445615905574e3e23
Headers
Series [1/3] firewall.cgi: Remove faulty assignments for selected hash. |

Commit Message

Stefan Schantl July 11, 2021, 5:54 p.m. UTC 
  The removed assignments are wrong because both are trying to assign
something different to the same key and will overwrite each other.

Secondary the assignment to the hash is not needed at this place, so it
safely can be removed.

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
---
 html/cgi-bin/firewall.cgi | 2 --
 1 file changed, 2 deletions(-)
diff mbox series

Patch

diff --git a/html/cgi-bin/firewall.cgi b/html/cgi-bin/firewall.cgi
index 70dee8d3c..d3cddfa23 100644
--- a/html/cgi-bin/firewall.cgi
+++ b/html/cgi-bin/firewall.cgi
@@ -1022,8 +1022,6 @@  sub gen_dd_block
 	$checked{'TIME_SUN'}{$fwdfwsettings{'TIME_SUN'}} 		= 'CHECKED';
 	$selected{'TIME_FROM'}{$fwdfwsettings{'TIME_FROM'}}		= 'selected';
 	$selected{'TIME_TO'}{$fwdfwsettings{'TIME_TO'}}			= 'selected';
-	$selected{'ipfire'}{$fwdfwsettings{$fwdfwsettings{'grp1'}}} ='selected';
-	$selected{'ipfire'}{$fwdfwsettings{$fwdfwsettings{'grp2'}}} ='selected';
 print<<END;
 		<table width='100%' border='0'>
 		<tr><td width='50%' valign='top'>