jquery: Update to 3.6.0

Message ID 20210317214201.40768-1-adolf.belka@ipfire.org
State Accepted
Commit bc8cb4040b0b953069fecc92d04d471c3029e0e4
Headers
Series jquery: Update to 3.6.0 |

Commit Message

Adolf Belka March 17, 2021, 9:42 p.m. UTC
  - Update from 1.10.2 to 3.6.0
- No update required for rootfile
- Changelog covers 8 years and 3 branches of code version
- The 1.x and 2.x branches no longer receive patches
   Summary of Important Changes for move to 3.0
    Attributes
        Breaking change: .removeAttr() no longer sets properties to false
        Breaking change: select-multiple with nothing selected returns an empty array
        Feature: SVG documents support class operations
        Deprecated: .toggleClass() with no arguments and .toggleClass( Boolean )
    Callbacks
        Feature: Locking a Callback prevents only future list execution
    Core
        Breaking change: jQuery 3.0 runs in Strict Mode
        Breaking change: document-ready handlers are now asynchronous
        Breaking change: jQuery.isNumeric() and custom .toString()
        Breaking change: Deprecated .context and .selector properties removed
        Breaking change: Deprecated .size() removed
        Breaking change: Undocumented internal methods no longer exposed
        Breaking change: Return values on empty sets are undefined
        Feature: for...of loops can be used on jQuery collections
        Feature: jQuery.ready promise is formally supported
        Deprecated: jQuery.unique(), renamed to jQuery.uniqueSort()
        Deprecated: jQuery.parseJSON()
        Deprecated: document-ready handlers other than jQuery(function)

Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
---
 lfs/jquery | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Adolf Belka March 17, 2021, 9:48 p.m. UTC | #1
Hi All,

This patch for jquery has very significant changes. It has changed from 
Branch 1 to 2 to 3. The change from Branch 2 to 3 lists several breaking 
changes.
I have no familiarity with jquery so cannot tell if these changes could 
give a problem or not to IPFire.

It would be good for someone familiar with the use of jquery in IPFire 
to test this patch to check if it is okay or creates a problem.

Regards,
Adolf.


On 17/03/2021 22:42, Adolf Belka wrote:
> - Update from 1.10.2 to 3.6.0
> - No update required for rootfile
> - Changelog covers 8 years and 3 branches of code version
> - The 1.x and 2.x branches no longer receive patches
>     Summary of Important Changes for move to 3.0
>      Attributes
>          Breaking change: .removeAttr() no longer sets properties to false
>          Breaking change: select-multiple with nothing selected returns an empty array
>          Feature: SVG documents support class operations
>          Deprecated: .toggleClass() with no arguments and .toggleClass( Boolean )
>      Callbacks
>          Feature: Locking a Callback prevents only future list execution
>      Core
>          Breaking change: jQuery 3.0 runs in Strict Mode
>          Breaking change: document-ready handlers are now asynchronous
>          Breaking change: jQuery.isNumeric() and custom .toString()
>          Breaking change: Deprecated .context and .selector properties removed
>          Breaking change: Deprecated .size() removed
>          Breaking change: Undocumented internal methods no longer exposed
>          Breaking change: Return values on empty sets are undefined
>          Feature: for...of loops can be used on jQuery collections
>          Feature: jQuery.ready promise is formally supported
>          Deprecated: jQuery.unique(), renamed to jQuery.uniqueSort()
>          Deprecated: jQuery.parseJSON()
>          Deprecated: document-ready handlers other than jQuery(function)
> 
> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
> ---
>   lfs/jquery | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lfs/jquery b/lfs/jquery
> index 6b054cbd4..1d35bbedd 100644
> --- a/lfs/jquery
> +++ b/lfs/jquery
> @@ -24,7 +24,7 @@
>   
>   include Config
>   
> -VER        = 1.10.2
> +VER        = 3.6.0
>   
>   THISAPP    = jquery-$(VER)
>   DL_FILE    = $(THISAPP).min.js
> @@ -40,7 +40,7 @@ objects = $(DL_FILE)
>   
>   $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>   
> -$(DL_FILE)_MD5 = 628072e7212db1e8cdacb22b21752cda
> +$(DL_FILE)_MD5 = 8fb8fee4fcc3cc86ff6c724154c49c42
>   
>   install : $(TARGET)
>   
>
  
Michael Tremer March 18, 2021, 11:22 a.m. UTC | #2
Hello Adolf,

I will leave this then for probably Leo(?) to check if this adds any regressions.

It should be easy to test because he would only have to replace the file on this machine and check if the other functionality still works.

Best,
-Michael

> On 17 Mar 2021, at 21:48, Adolf Belka <adolf.belka@ipfire.org> wrote:
> 
> Hi All,
> 
> This patch for jquery has very significant changes. It has changed from Branch 1 to 2 to 3. The change from Branch 2 to 3 lists several breaking changes.
> I have no familiarity with jquery so cannot tell if these changes could give a problem or not to IPFire.
> 
> It would be good for someone familiar with the use of jquery in IPFire to test this patch to check if it is okay or creates a problem.
> 
> Regards,
> Adolf.
> 
> 
> On 17/03/2021 22:42, Adolf Belka wrote:
>> - Update from 1.10.2 to 3.6.0
>> - No update required for rootfile
>> - Changelog covers 8 years and 3 branches of code version
>> - The 1.x and 2.x branches no longer receive patches
>>    Summary of Important Changes for move to 3.0
>>     Attributes
>>         Breaking change: .removeAttr() no longer sets properties to false
>>         Breaking change: select-multiple with nothing selected returns an empty array
>>         Feature: SVG documents support class operations
>>         Deprecated: .toggleClass() with no arguments and .toggleClass( Boolean )
>>     Callbacks
>>         Feature: Locking a Callback prevents only future list execution
>>     Core
>>         Breaking change: jQuery 3.0 runs in Strict Mode
>>         Breaking change: document-ready handlers are now asynchronous
>>         Breaking change: jQuery.isNumeric() and custom .toString()
>>         Breaking change: Deprecated .context and .selector properties removed
>>         Breaking change: Deprecated .size() removed
>>         Breaking change: Undocumented internal methods no longer exposed
>>         Breaking change: Return values on empty sets are undefined
>>         Feature: for...of loops can be used on jQuery collections
>>         Feature: jQuery.ready promise is formally supported
>>         Deprecated: jQuery.unique(), renamed to jQuery.uniqueSort()
>>         Deprecated: jQuery.parseJSON()
>>         Deprecated: document-ready handlers other than jQuery(function)
>> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
>> ---
>>  lfs/jquery | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> diff --git a/lfs/jquery b/lfs/jquery
>> index 6b054cbd4..1d35bbedd 100644
>> --- a/lfs/jquery
>> +++ b/lfs/jquery
>> @@ -24,7 +24,7 @@
>>    include Config
>>  -VER        = 1.10.2
>> +VER        = 3.6.0
>>    THISAPP    = jquery-$(VER)
>>  DL_FILE    = $(THISAPP).min.js
>> @@ -40,7 +40,7 @@ objects = $(DL_FILE)
>>    $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>>  -$(DL_FILE)_MD5 = 628072e7212db1e8cdacb22b21752cda
>> +$(DL_FILE)_MD5 = 8fb8fee4fcc3cc86ff6c724154c49c42
>>    install : $(TARGET)
>>  
> 
> -- 
> Sent from my laptop
  
Leo-Andres Hofmann March 18, 2021, 7:32 p.m. UTC | #3
Hi Adolf,

thank you very much for getting this done so quickly!

I have updated jQuery on my test system and could not find any immediate issues. My Firefox 86 did not complain, the speedmeter and firewall GUI are working.
As far as I can tell, none of the affected funtions are used anywhere.

Best regards,
Leo

Am 17.03.2021 um 22:48 schrieb Adolf Belka:
> Hi All,
>
> This patch for jquery has very significant changes. It has changed from Branch 1 to 2 to 3. The change from Branch 2 to 3 lists several breaking changes.
> I have no familiarity with jquery so cannot tell if these changes could give a problem or not to IPFire.
>
> It would be good for someone familiar with the use of jquery in IPFire to test this patch to check if it is okay or creates a problem.
>
> Regards,
> Adolf.
>
>
> On 17/03/2021 22:42, Adolf Belka wrote:
>> - Update from 1.10.2 to 3.6.0
>> - No update required for rootfile
>> - Changelog covers 8 years and 3 branches of code version
>> - The 1.x and 2.x branches no longer receive patches
>>     Summary of Important Changes for move to 3.0
>>      Attributes
>>          Breaking change: .removeAttr() no longer sets properties to false
>>          Breaking change: select-multiple with nothing selected returns an empty array
>>          Feature: SVG documents support class operations
>>          Deprecated: .toggleClass() with no arguments and .toggleClass( Boolean )
>>      Callbacks
>>          Feature: Locking a Callback prevents only future list execution
>>      Core
>>          Breaking change: jQuery 3.0 runs in Strict Mode
>>          Breaking change: document-ready handlers are now asynchronous
>>          Breaking change: jQuery.isNumeric() and custom .toString()
>>          Breaking change: Deprecated .context and .selector properties removed
>>          Breaking change: Deprecated .size() removed
>>          Breaking change: Undocumented internal methods no longer exposed
>>          Breaking change: Return values on empty sets are undefined
>>          Feature: for...of loops can be used on jQuery collections
>>          Feature: jQuery.ready promise is formally supported
>>          Deprecated: jQuery.unique(), renamed to jQuery.uniqueSort()
>>          Deprecated: jQuery.parseJSON()
>>          Deprecated: document-ready handlers other than jQuery(function)
>>
>> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
>> ---
>>   lfs/jquery | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/lfs/jquery b/lfs/jquery
>> index 6b054cbd4..1d35bbedd 100644
>> --- a/lfs/jquery
>> +++ b/lfs/jquery
>> @@ -24,7 +24,7 @@
>>     include Config
>>   -VER        = 1.10.2
>> +VER        = 3.6.0
>>     THISAPP    = jquery-$(VER)
>>   DL_FILE    = $(THISAPP).min.js
>> @@ -40,7 +40,7 @@ objects = $(DL_FILE)
>>     $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>>   -$(DL_FILE)_MD5 = 628072e7212db1e8cdacb22b21752cda
>> +$(DL_FILE)_MD5 = 8fb8fee4fcc3cc86ff6c724154c49c42
>>     install : $(TARGET)
>>
>
  
Michael Tremer March 19, 2021, 9:59 a.m. UTC | #4
Thanks for the feedback, I will merge this patch :)

-Michael

> On 18 Mar 2021, at 19:32, Leo Hofmann <hofmann@leo-andres.de> wrote:
> 
> Hi Adolf,
> 
> thank you very much for getting this done so quickly!
> 
> I have updated jQuery on my test system and could not find any immediate issues. My Firefox 86 did not complain, the speedmeter and firewall GUI are working.
> As far as I can tell, none of the affected funtions are used anywhere.
> 
> Best regards,
> Leo
> 
> Am 17.03.2021 um 22:48 schrieb Adolf Belka:
>> Hi All,
>> 
>> This patch for jquery has very significant changes. It has changed from Branch 1 to 2 to 3. The change from Branch 2 to 3 lists several breaking changes.
>> I have no familiarity with jquery so cannot tell if these changes could give a problem or not to IPFire.
>> 
>> It would be good for someone familiar with the use of jquery in IPFire to test this patch to check if it is okay or creates a problem.
>> 
>> Regards,
>> Adolf.
>> 
>> 
>> On 17/03/2021 22:42, Adolf Belka wrote:
>>> - Update from 1.10.2 to 3.6.0
>>> - No update required for rootfile
>>> - Changelog covers 8 years and 3 branches of code version
>>> - The 1.x and 2.x branches no longer receive patches
>>>     Summary of Important Changes for move to 3.0
>>>      Attributes
>>>          Breaking change: .removeAttr() no longer sets properties to false
>>>          Breaking change: select-multiple with nothing selected returns an empty array
>>>          Feature: SVG documents support class operations
>>>          Deprecated: .toggleClass() with no arguments and .toggleClass( Boolean )
>>>      Callbacks
>>>          Feature: Locking a Callback prevents only future list execution
>>>      Core
>>>          Breaking change: jQuery 3.0 runs in Strict Mode
>>>          Breaking change: document-ready handlers are now asynchronous
>>>          Breaking change: jQuery.isNumeric() and custom .toString()
>>>          Breaking change: Deprecated .context and .selector properties removed
>>>          Breaking change: Deprecated .size() removed
>>>          Breaking change: Undocumented internal methods no longer exposed
>>>          Breaking change: Return values on empty sets are undefined
>>>          Feature: for...of loops can be used on jQuery collections
>>>          Feature: jQuery.ready promise is formally supported
>>>          Deprecated: jQuery.unique(), renamed to jQuery.uniqueSort()
>>>          Deprecated: jQuery.parseJSON()
>>>          Deprecated: document-ready handlers other than jQuery(function)
>>> 
>>> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
>>> ---
>>>   lfs/jquery | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>> 
>>> diff --git a/lfs/jquery b/lfs/jquery
>>> index 6b054cbd4..1d35bbedd 100644
>>> --- a/lfs/jquery
>>> +++ b/lfs/jquery
>>> @@ -24,7 +24,7 @@
>>>     include Config
>>>   -VER        = 1.10.2
>>> +VER        = 3.6.0
>>>     THISAPP    = jquery-$(VER)
>>>   DL_FILE    = $(THISAPP).min.js
>>> @@ -40,7 +40,7 @@ objects = $(DL_FILE)
>>>     $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>>>   -$(DL_FILE)_MD5 = 628072e7212db1e8cdacb22b21752cda
>>> +$(DL_FILE)_MD5 = 8fb8fee4fcc3cc86ff6c724154c49c42
>>>     install : $(TARGET)
>>> 
>>
  

Patch

diff --git a/lfs/jquery b/lfs/jquery
index 6b054cbd4..1d35bbedd 100644
--- a/lfs/jquery
+++ b/lfs/jquery
@@ -24,7 +24,7 @@ 
 
 include Config
 
-VER        = 1.10.2
+VER        = 3.6.0
 
 THISAPP    = jquery-$(VER)
 DL_FILE    = $(THISAPP).min.js
@@ -40,7 +40,7 @@  objects = $(DL_FILE)
 
 $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
 
-$(DL_FILE)_MD5 = 628072e7212db1e8cdacb22b21752cda
+$(DL_FILE)_MD5 = 8fb8fee4fcc3cc86ff6c724154c49c42
 
 install : $(TARGET)