optionsfw.cgi: Cosmetic fix - centered 'Save...' buttons

Message ID 20201227151636.6210-1-matthias.fischer@ipfire.org
State Superseded
Headers
Series optionsfw.cgi: Cosmetic fix - centered 'Save...' buttons |

Commit Message

Matthias Fischer 27 Dec 2020, 3:16 p.m. UTC
  Center 'Save' and 'Save And Restart' buttons as in most of the
other pages.

Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org>
---
 html/cgi-bin/optionsfw.cgi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Michael Tremer 28 Dec 2020, 1:21 p.m. UTC | #1
Hi,

> On 27 Dec 2020, at 16:16, Matthias Fischer <matthias.fischer@ipfire.org> wrote:
> 
> Center 'Save' and 'Save And Restart' buttons as in most of the
> other pages.

Yes that is a good idea.

However, you are changing the string on the button which is not part of any translation.

-Michael

> 
> Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org>
> ---
> html/cgi-bin/optionsfw.cgi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/html/cgi-bin/optionsfw.cgi b/html/cgi-bin/optionsfw.cgi
> index 8771a85ba..78e7710f5 100644
> --- a/html/cgi-bin/optionsfw.cgi
> +++ b/html/cgi-bin/optionsfw.cgi
> @@ -394,7 +394,7 @@ END
> 
> <br />
> <table width='100%' cellspacing='0'>
> -<tr><td align='right'><form method='post' action='$ENV{'SCRIPT_NAME'}'>
> +<tr><td align='center'><form method='post' action='$ENV{'SCRIPT_NAME'}'>
> <input type='submit' name='ACTION' value='$Lang::tr{'save'}' />
> <input type='submit' name='ACTION' value='$Lang::tr{'fw settings save and restart'}' />
> </form></td></tr>
> -- 
> 2.18.0
>
  

Patch

diff --git a/html/cgi-bin/optionsfw.cgi b/html/cgi-bin/optionsfw.cgi
index 8771a85ba..78e7710f5 100644
--- a/html/cgi-bin/optionsfw.cgi
+++ b/html/cgi-bin/optionsfw.cgi
@@ -394,7 +394,7 @@  END
 
 <br />
 <table width='100%' cellspacing='0'>
-<tr><td align='right'><form method='post' action='$ENV{'SCRIPT_NAME'}'>
+<tr><td align='center'><form method='post' action='$ENV{'SCRIPT_NAME'}'>
 <input type='submit' name='ACTION' value='$Lang::tr{'save'}' />
 <input type='submit' name='ACTION' value='$Lang::tr{'fw settings save and restart'}' />
 </form></td></tr>