From patchwork Tue Oct 13 16:07:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Tremer X-Patchwork-Id: 3546 Return-Path: Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4C9gTG728dz3x1S for ; Tue, 13 Oct 2020 16:08:50 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail02.haj.ipfire.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4C9gSs0T6wz1KH; Tue, 13 Oct 2020 16:08:29 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4C9gSp0Lrrz305F; Tue, 13 Oct 2020 16:08:26 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4C9gSk5M03z2xBf for ; Tue, 13 Oct 2020 16:08:22 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) by mail01.ipfire.org (Postfix) with ESMTPSA id 4C9gSj4Rrvz1GW; Tue, 13 Oct 2020 16:08:21 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1602605301; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zU1mx3gH2Cb9/+V6AEvoV+d7MpV59qVMp2Nh+wxTG64=; b=K8SbRU56zM5/EHcqnKjPzLuzPt+ruvS2grZ4OnV1tkO1oYxH81U/VsUWzvHFHJdmnyFenU tX6iOCdl5FMDNEDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1602605301; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zU1mx3gH2Cb9/+V6AEvoV+d7MpV59qVMp2Nh+wxTG64=; b=CLE6EqGk9JQDr9iDRsFcHGbWweD/dIZazmX6vJuhmKFjq7Vw/k1EdPs4QsBb5kMhEIWT6n sciS+WRikTuvVLj0JQ5PtC9uVm1Bw2jELQbPkpuUFVjdaCeYcyuQiAwT6iLyEFbuQavNEg Pt7owlFRvV61Jd9A0CCvK6K5I4yFpADvfhmeRSHGFq4s6TQhliG+F8TaqCKNFKCVbGw/Dk nc05XrI4Q24Q/q/K3cIs/2eCT33ZXf6fkcL3bleV/6UjA7AQ2D15E6v5IXuzd0cbFQP3dk C1sy13ji9s3cP/eka/lxN2+/OcUKz8leaKMMZnQUsAUE4un7SrzOKyeiUU3MnQ== From: Michael Tremer To: development@lists.ipfire.org Subject: [PATCH 20/54] samba: Remove printer management Date: Tue, 13 Oct 2020 16:07:38 +0000 Message-Id: <20201013160812.27754-20-michael.tremer@ipfire.org> In-Reply-To: <20201013160812.27754-1-michael.tremer@ipfire.org> References: <20201013160812.27754-1-michael.tremer@ipfire.org> MIME-Version: 1.0 X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: IPFire development talk List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Tremer Errors-To: development-bounces@lists.ipfire.org Sender: "Development" Signed-off-by: Michael Tremer --- config/backup/includes/samba | 1 - config/rootfiles/packages/aarch64/samba | 1 - config/rootfiles/packages/armv5tel/samba | 1 - config/rootfiles/packages/i586/samba | 1 - config/rootfiles/packages/x86_64/samba | 1 - html/cgi-bin/samba.cgi | 119 ----------------------- 6 files changed, 124 deletions(-) diff --git a/config/backup/includes/samba b/config/backup/includes/samba index 67823bd19..1d2166ca5 100644 --- a/config/backup/includes/samba +++ b/config/backup/includes/samba @@ -1,6 +1,5 @@ /var/ipfire/samba/global /var/ipfire/samba/pdc -/var/ipfire/samba/printer /var/ipfire/samba/private/ /var/ipfire/samba/settings /var/ipfire/samba/shares diff --git a/config/rootfiles/packages/aarch64/samba b/config/rootfiles/packages/aarch64/samba index 61e29fe8c..ad5ffb204 100644 --- a/config/rootfiles/packages/aarch64/samba +++ b/config/rootfiles/packages/aarch64/samba @@ -795,7 +795,6 @@ var/ipfire/backup/addons/includes/samba #var/ipfire/samba var/ipfire/samba/global var/ipfire/samba/pdc -var/ipfire/samba/printer #var/ipfire/samba/private var/ipfire/samba/private/secrets.tdb var/ipfire/samba/private/smbpasswd diff --git a/config/rootfiles/packages/armv5tel/samba b/config/rootfiles/packages/armv5tel/samba index 16e9dab11..9d445db8f 100644 --- a/config/rootfiles/packages/armv5tel/samba +++ b/config/rootfiles/packages/armv5tel/samba @@ -795,7 +795,6 @@ var/ipfire/backup/addons/includes/samba #var/ipfire/samba var/ipfire/samba/global var/ipfire/samba/pdc -var/ipfire/samba/printer #var/ipfire/samba/private var/ipfire/samba/private/secrets.tdb var/ipfire/samba/private/smbpasswd diff --git a/config/rootfiles/packages/i586/samba b/config/rootfiles/packages/i586/samba index dea9aa023..0888fc6ed 100644 --- a/config/rootfiles/packages/i586/samba +++ b/config/rootfiles/packages/i586/samba @@ -795,7 +795,6 @@ var/ipfire/backup/addons/includes/samba #var/ipfire/samba var/ipfire/samba/global var/ipfire/samba/pdc -var/ipfire/samba/printer #var/ipfire/samba/private var/ipfire/samba/private/secrets.tdb var/ipfire/samba/private/smbpasswd diff --git a/config/rootfiles/packages/x86_64/samba b/config/rootfiles/packages/x86_64/samba index 31328a3a0..54afad4d2 100644 --- a/config/rootfiles/packages/x86_64/samba +++ b/config/rootfiles/packages/x86_64/samba @@ -795,7 +795,6 @@ var/ipfire/backup/addons/includes/samba #var/ipfire/samba var/ipfire/samba/global var/ipfire/samba/pdc -var/ipfire/samba/printer #var/ipfire/samba/private var/ipfire/samba/private/secrets.tdb var/ipfire/samba/private/smbpasswd diff --git a/html/cgi-bin/samba.cgi b/html/cgi-bin/samba.cgi index cd0cc8ab8..a9478a139 100644 --- a/html/cgi-bin/samba.cgi +++ b/html/cgi-bin/samba.cgi @@ -48,8 +48,6 @@ my $userfile = "${General::swroot}/samba/private/smbpasswd"; my %selected= () ; my $defaultoption= "[Share]\npath = /var/ipfire/samba/share1\ncomment = Share - Public Access\nbrowseable = yes\nwriteable = yes\ncreate mask = 0777\ndirectory mask = 0777\npublic = yes\nforce user = samba"; -my $defaultprinter= "[Printer]\ncomment = Printer public\npath = /var/spool/cups\nprinting = sysvn\nprintcap = lpstat\npublic = yes\nwritable = no\nprintable = yes"; -my %printer = (); my %shares = (); &General::readhash("${General::swroot}/ethernet/settings", \%netsettings); @@ -873,120 +871,6 @@ if ($sambasettings{'ACTION'} eq 'smbsharechange') &Header::closebox(); -############################################################################################################################ -################################################ Verwalten von Druckern #################################################### - -my %printer = config("${General::swroot}/samba/printer"); - -&Header::openbox('100%', 'center', $Lang::tr{'printer'}); - -my @Printers = keys(%printer); -print < -
- - -END -; -foreach my $printerentry (sort @Printers) - { - chomp $printerentry; - print < - - -END -; - } -print < -
-
$Lang::tr{'manage printers'} -
$Lang::tr{'printername'}$Lang::tr{'options'}
$printerentry
- - - -
- - - -
- - - -
- - -
- - -
-END -; - -if ($sambasettings{'ACTION'} eq 'printeradd' || $sambasettings{'ACTION'} eq 'printercaption' ) - { - print < - - - - -
$Lang::tr{'add printer'}
$Lang::tr{'show share options'} -
-
- - -
-
- -END -; - } - -if ($sambasettings{'ACTION'} eq 'printerchange' || $sambasettings{'ACTION'} eq 'printercaption2' ) - { - my $printeroption = $printer{$sambasettings{'NAME'}}; - print < - - - - -
$Lang::tr{'edit printer'}
-
- - -
- -
-END -; - } - -if ($sambasettings{'ACTION'} eq 'smbprinteradd') - { - $printer{'xvx'}= "$sambasettings{'PRINTEROPTION'}"; - save("printer"); - my %printer = config("${General::swroot}/samba/printer"); - } - -if ($sambasettings{'ACTION'} eq 'smbprinterdel') - { - delete $printer{$sambasettings{'NAME'}}; - save("printer"); - my %printer = config("${General::swroot}/samba/printer"); - } - -if ($sambasettings{'ACTION'} eq 'smbprinterchange') - { - $printer{$sambasettings{'NAME'}} = $sambasettings{'PRINTEROPTION'}; - save("printer"); - my %printer = config("${General::swroot}/samba/printer"); - } - -&Header::closebox(); - ############################################################################################################################ ############################################### Anzeige des Sambastatus #################################################### @@ -1049,9 +933,6 @@ my $smb = shift; open (FILE, ">${General::swroot}/samba/$smb") or die "Can't $smb settings $!"; flock (FILE, 2); -if ( $smb eq 'printer') - {while (my ($name, $option) = each %printer){chomp $option;$option =~ s/\r\n/\n/gi;$option =~ s/^\n//gi;$option =~ s/^\r//gi;$option =~ s/^.\n//gi;$option =~ s/^.\r//gi;print FILE "$option\n";}} - if ( $smb eq 'shares') {while (my ($name, $option) = each %shares){chomp $option;$option =~ s/\r\n/\n/gi;$option =~ s/^\n//gi;$option =~ s/^\r//gi;$option =~ s/^.\n//gi;$option =~ s/^.\r//gi;print FILE "$option\n";} }