diff mbox series

[1/9] samba.cgi: remove unsupported security = share

Message ID 20201005201711.4259-1-arne_f@ipfire.org
State Accepted
Commit c771fe7c4ffd7dc04f8eb5976df14465e4587d12
Headers
Series [1/9] samba.cgi: remove unsupported security = share |

Commit Message

Arne Fitzenreiter Oct. 5, 2020, 8:17 p.m. UTC 
  Signed-off-by: Arne Fitzenreiter <arne_f@ipfire.org>
---
 html/cgi-bin/samba.cgi | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Michael Tremer Oct. 6, 2020, 12:24 p.m. UTC | #1 
Hi,

I merged the whole patchset, but I would like to know how we are going to migrate any existing installations?

-Michael

> On 5 Oct 2020, at 21:17, Arne Fitzenreiter <arne_f@ipfire.org> wrote:
> 
> Signed-off-by: Arne Fitzenreiter <arne_f@ipfire.org>
> ---
> html/cgi-bin/samba.cgi | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/html/cgi-bin/samba.cgi b/html/cgi-bin/samba.cgi
> index 696cb1b70..8f88bc728 100644
> --- a/html/cgi-bin/samba.cgi
> +++ b/html/cgi-bin/samba.cgi
> @@ -78,7 +78,7 @@ $sambasettings{'WORKGRP'} = 'homeip.net';
> $sambasettings{'NETBIOSNAME'} = 'IPFire';
> $sambasettings{'SRVSTRING'} = 'Samba running on IPFire 2.x';
> $sambasettings{'INTERFACES'} = '';
> -$sambasettings{'SECURITY'} = 'share';
> +$sambasettings{'SECURITY'} = 'user';
> $sambasettings{'OSLEVEL'} = '33';
> $sambasettings{'GREEN'} = 'on';
> $sambasettings{'BLUE'} = 'off';
> @@ -150,7 +150,7 @@ if ($sambasettings{'ACTION'} eq 'globalresetyes')
> 	$sambasettings{'NETBIOSNAME'} = 'IPFire';
> 	$sambasettings{'SRVSTRING'} = 'Samba running on IPFire 2.x';
> 	$sambasettings{'INTERFACES'} = '';
> -	$sambasettings{'SECURITY'} = 'share';
> +	$sambasettings{'SECURITY'} = 'user';
> 	$sambasettings{'OSLEVEL'} = '65';
> 	$sambasettings{'GREEN'} = 'on';
> 	$sambasettings{'BLUE'} = 'off';
> @@ -535,7 +535,6 @@ print <<END
> <tr><td align='left'><br /></td><td></td></tr>
> <tr bgcolor='$color{'color20'}'><td colspan='2' align='left'><b>$Lang::tr{'security options'}</b></td></tr>
> <tr><td align='left' width='40%'>$Lang::tr{'security'}</td><td align='left'><select name='SECURITY' style="width: 165px">
> -																				<option value='share' $selected{'SECURITY'}{'share'}>Share</option>
> 																				<option value='user' $selected{'SECURITY'}{'user'}>User</option>
> 																				<option value='domain' $selected{'SECURITY'}{'domain'}>Domain</option>
> 																				<option value='ADS' $selected{'SECURITY'}{'ADS'}>ADS</option>
> -- 
> 2.17.1
>
diff mbox series

Patch

diff --git a/html/cgi-bin/samba.cgi b/html/cgi-bin/samba.cgi
index 696cb1b70..8f88bc728 100644
--- a/html/cgi-bin/samba.cgi
+++ b/html/cgi-bin/samba.cgi
@@ -78,7 +78,7 @@  $sambasettings{'WORKGRP'} = 'homeip.net';
 $sambasettings{'NETBIOSNAME'} = 'IPFire';
 $sambasettings{'SRVSTRING'} = 'Samba running on IPFire 2.x';
 $sambasettings{'INTERFACES'} = '';
-$sambasettings{'SECURITY'} = 'share';
+$sambasettings{'SECURITY'} = 'user';
 $sambasettings{'OSLEVEL'} = '33';
 $sambasettings{'GREEN'} = 'on';
 $sambasettings{'BLUE'} = 'off';
@@ -150,7 +150,7 @@  if ($sambasettings{'ACTION'} eq 'globalresetyes')
 	$sambasettings{'NETBIOSNAME'} = 'IPFire';
 	$sambasettings{'SRVSTRING'} = 'Samba running on IPFire 2.x';
 	$sambasettings{'INTERFACES'} = '';
-	$sambasettings{'SECURITY'} = 'share';
+	$sambasettings{'SECURITY'} = 'user';
 	$sambasettings{'OSLEVEL'} = '65';
 	$sambasettings{'GREEN'} = 'on';
 	$sambasettings{'BLUE'} = 'off';
@@ -535,7 +535,6 @@  print <<END
 <tr><td align='left'><br /></td><td></td></tr>
 <tr bgcolor='$color{'color20'}'><td colspan='2' align='left'><b>$Lang::tr{'security options'}</b></td></tr>
 <tr><td align='left' width='40%'>$Lang::tr{'security'}</td><td align='left'><select name='SECURITY' style="width: 165px">
-																				<option value='share' $selected{'SECURITY'}{'share'}>Share</option>
 																				<option value='user' $selected{'SECURITY'}{'user'}>User</option>
 																				<option value='domain' $selected{'SECURITY'}{'domain'}>Domain</option>
 																				<option value='ADS' $selected{'SECURITY'}{'ADS'}>ADS</option>