diff mbox series

[3/4] netother.cgi: Added missing double quotes

Message ID 20200905154113.3555-3-matthias.fischer@ipfire.org
State Accepted
Commit b1b1a258356d7bf40ab4dba3716c2a8639ac7cd2
Headers
Series [1/4] graphs.pl: Added translation for 'ACPI Thermal Zone' |

Commit Message

Matthias Fischer Sept. 5, 2020, 3:41 p.m. UTC 
  Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org>
---
 html/cgi-bin/netother.cgi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Tremer Oct. 5, 2020, 3:32 p.m. UTC | #1 
Hi,

> On 5 Sep 2020, at 16:41, Matthias Fischer <matthias.fischer@ipfire.org> wrote:
> 
> Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org>
> ---
> html/cgi-bin/netother.cgi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/html/cgi-bin/netother.cgi b/html/cgi-bin/netother.cgi
> index 3256a0d6b..459979684 100755
> --- a/html/cgi-bin/netother.cgi
> +++ b/html/cgi-bin/netother.cgi
> @@ -71,7 +71,7 @@ if ( $querry[0] eq "conntrack") {
> 		&Header::closebox();
> 	}
> 
> -	&Header::openbox('100%', 'center', $Lang::tr{'connnection tracking'});
> +	&Header::openbox('100%', 'center', "$Lang::tr{'connnection tracking'}");
> 	&Graphs::makegraphbox("netother.cgi", "conntrack", "day");
> 	&Header::closebox();

There was a typo here. “connnection” had three n.

> 
> -- 
> 2.18.0
>
Matthias Fischer Oct. 5, 2020, 4:10 p.m. UTC | #2 
Hi,

On 05.10.2020 17:32, Michael Tremer wrote:
> There was a typo here. “connnection” had three n.

Yep. Saw it - but too late.

I'm in the deepest basement right now - being ashamed...

Thanks for fixing.

Best,
Matthias
Michael Tremer Oct. 6, 2020, 11:57 a.m. UTC | #3 
Hi,

> On 5 Oct 2020, at 17:10, Matthias Fischer <matthias.fischer@ipfire.org> wrote:
> 
> Hi,
> 
> On 05.10.2020 17:32, Michael Tremer wrote:
>> There was a typo here. “connnection” had three n.
> 
> Yep. Saw it - but too late.
> 
> I'm in the deepest basement right now - being ashamed...

Don’t be. Nobody saw it.

I am just using this to illustrate why we review code here :)

-Michael

> 
> Thanks for fixing.
> 
> Best,
> Matthias
diff mbox series

Patch

diff --git a/html/cgi-bin/netother.cgi b/html/cgi-bin/netother.cgi
index 3256a0d6b..459979684 100755
--- a/html/cgi-bin/netother.cgi
+++ b/html/cgi-bin/netother.cgi
@@ -71,7 +71,7 @@  if ( $querry[0] eq "conntrack") {
 		&Header::closebox();
 	}
 
-	&Header::openbox('100%', 'center', $Lang::tr{'connnection tracking'});
+	&Header::openbox('100%', 'center', "$Lang::tr{'connnection tracking'}");
 	&Graphs::makegraphbox("netother.cgi", "conntrack", "day");
 	&Header::closebox();