| Message ID | 20200513135520.30310-1-matthias.fischer@ipfire.org |
|---|---|
| State | Rejected |
| Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 49Mblz4n41z3xQr for <patchwork@web04.haj.ipfire.org>; Wed, 13 May 2020 13:55:27 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail02.haj.ipfire.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 49Mbly4Gsdz1kv; Wed, 13 May 2020 13:55:26 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 49Mbly1kdbz2yx2; Wed, 13 May 2020 13:55:26 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 49Mblw5Kdwz2y3N for <development@lists.ipfire.org>; Wed, 13 May 2020 13:55:24 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) by mail01.ipfire.org (Postfix) with ESMTPSA id 49Mblw1LKwz1kv for <development@lists.ipfire.org>; Wed, 13 May 2020 13:55:24 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1589378124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc; bh=P5LyaJORFr7ZqMxkt7FxXKDFQkgozKiCuX9/3We5V00=; b=oO1FG4w/Bg6vnG+E4bKtW4FfyYeC/Apt261m3v0zyxSXe8Z31EhgF2ZL+iUthXEWLzOBgZ vkus/73MVmAG1BCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1589378124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc; bh=P5LyaJORFr7ZqMxkt7FxXKDFQkgozKiCuX9/3We5V00=; b=Sa5FjTBc2/2yJDHDC8f5bABYPvoZj6RI0n7M1oExpJviNVXt7/ew+8kWzblXCBZxRQi10F JttaaFYrual4fxKiEs8+Xojxwd1lMVLR5lmZgfuE3Ww8JWq1iqgfiSZPcxXyLs/bymzpLS 0LEkF01kEilPHlk+/QlBKtYtfpM8pJnLJOgHa5a2hsg/tBreD6ocAYI/zWgJTouCO0D4QP sokQ1SUwb/EuGNmkMWo1M7zGn620UFqdHqVE76h2PZivPg/v9PGOWAwXPpyCtOTU+1/N5a Yey5wiQPib/tf8uGp2XZN0jC+6jlB+Wt9+NjQ9G0FHyqWmxHQe/59ioCG0wORw== From: Matthias Fischer <matthias.fischer@ipfire.org> To: development@lists.ipfire.org Subject: [PATCH] Typo in 'media.cgi' Date: Wed, 13 May 2020 15:55:20 +0200 Message-Id: <20200513135520.30310-1-matthias.fischer@ipfire.org> Authentication-Results: mail01.ipfire.org; auth=pass smtp.mailfrom=matthias.fischer@ipfire.org X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> List-Unsubscribe: <https://lists.ipfire.org/mailman/options/development>, <mailto:development-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/development/> List-Post: <mailto:development@lists.ipfire.org> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Subscribe: <https://lists.ipfire.org/mailman/listinfo/development>, <mailto:development-request@lists.ipfire.org?subject=subscribe> Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org> |
| Series |
Typo in 'media.cgi'
|
|
Commit Message
Matthias Fischer
13 May 2020, 1:55 p.m. UTC
'transfers' = 'Transfers'
Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org>
---
html/cgi-bin/media.cgi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi, Should we not have a variable here to get the string form the language files? -Michael > On 13 May 2020, at 14:55, Matthias Fischer <matthias.fischer@ipfire.org> wrote: > > 'transfers' = 'Transfers' > > Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org> > --- > html/cgi-bin/media.cgi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/html/cgi-bin/media.cgi b/html/cgi-bin/media.cgi > index 0bb6435ab..a33d69313 100644 > --- a/html/cgi-bin/media.cgi > +++ b/html/cgi-bin/media.cgi > @@ -147,7 +147,7 @@ END > my @iostat1 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$1}'); > my @iostat2 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$5}'); > my @iostat3 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$6}'); > - print "<tr><td colspan='3'> \n<tr><td colspan='3'><h3>transfers</h3></td></tr>"; > + print "<tr><td colspan='3'> \n<tr><td colspan='3'><h3>Transfers</h3></td></tr>"; > my $i=0; > > for(my $i = 1; $i <= $#iostat1; $i++){ > -- > 2.17.1 >
Right. Work in progress. On 13.05.2020 16:04, Michael Tremer wrote: > Hi, > > Should we not have a variable here to get the string form the language files? > > -Michael > >> On 13 May 2020, at 14:55, Matthias Fischer <matthias.fischer@ipfire.org> wrote: >> >> 'transfers' = 'Transfers' >> >> Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org> >> --- >> html/cgi-bin/media.cgi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/html/cgi-bin/media.cgi b/html/cgi-bin/media.cgi >> index 0bb6435ab..a33d69313 100644 >> --- a/html/cgi-bin/media.cgi >> +++ b/html/cgi-bin/media.cgi >> @@ -147,7 +147,7 @@ END >> my @iostat1 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$1}'); >> my @iostat2 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$5}'); >> my @iostat3 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$6}'); >> - print "<tr><td colspan='3'> \n<tr><td colspan='3'><h3>transfers</h3></td></tr>"; >> + print "<tr><td colspan='3'> \n<tr><td colspan='3'><h3>Transfers</h3></td></tr>"; >> my $i=0; >> >> for(my $i = 1; $i <= $#iostat1; $i++){ >> -- >> 2.17.1 >> >
diff --git a/html/cgi-bin/media.cgi b/html/cgi-bin/media.cgi index 0bb6435ab..a33d69313 100644 --- a/html/cgi-bin/media.cgi +++ b/html/cgi-bin/media.cgi @@ -147,7 +147,7 @@ END my @iostat1 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$1}'); my @iostat2 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$5}'); my @iostat3 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$6}'); - print "<tr><td colspan='3'> \n<tr><td colspan='3'><h3>transfers</h3></td></tr>"; + print "<tr><td colspan='3'> \n<tr><td colspan='3'><h3>Transfers</h3></td></tr>"; my $i=0; for(my $i = 1; $i <= $#iostat1; $i++){