ids.cgi: Fix logic if suricata needs to be restarted.

Message ID 20200406123421.3162-1-stefan.schantl@ipfire.org
State Accepted
Commit 1622e5c1f3781f1b6e370cb540ecabe17383acad
Headers
Series ids.cgi: Fix logic if suricata needs to be restarted. |

Commit Message

Stefan Schantl April 6, 2020, 12:34 p.m. UTC
  Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
---
 html/cgi-bin/ids.cgi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
  

Patch

diff --git a/html/cgi-bin/ids.cgi b/html/cgi-bin/ids.cgi
index df7138e08..bc31a341f 100644
--- a/html/cgi-bin/ids.cgi
+++ b/html/cgi-bin/ids.cgi
@@ -417,17 +417,17 @@  if ($cgiparams{'RULESET'} eq $Lang::tr{'save'}) {
 
 	# Loop through the hash of idsrules.
 	foreach my $rulefile(keys %idsrules) {
+		# Check if the state of the rulefile has been changed.
+		unless ($cgiparams{$rulefile} eq $idsrules{$rulefile}{'Rulefile'}{'State'}) {
+			# A restart of suricata is required to apply the changes of the used rulefiles.
+			$suricata_restart_required = 1;
+		}
+
 		# Check if the rulefile is enabled.
 		if ($cgiparams{$rulefile} eq "on") {
 			# Add rulefile to the array of enabled rulefiles.
 			push(@enabled_rulefiles, $rulefile);
 
-			# Check if the state of the rulefile has been changed.
-			unless ($cgiparams{$rulefile} eq $idsrules{$rulefile}{'Rulefile'}{'State'}) {
-				# A restart of suricata is required to apply the changes of the used rulefiles.
-				$suricata_restart_required = 1;
-			}
-
 			# Drop item from cgiparams hash.
 			delete $cgiparams{$rulefile};
 		}