[2/2] Suricata: Add port 3128 (Transparent Proxy) to group of HTTP ports.

Message ID 20200401090207.3894-2-stefan.schantl@ipfire.org
State Accepted
Headers show
Series [1/2] Suricata: Add port 81 (UpdateAccelerator) to group of HTTP ports. | expand

Commit Message

Stefan Schantl April 1, 2020, 9:02 a.m. UTC
Fixes #12308.

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
---
 config/suricata/suricata.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Arne Fitzenreiter April 1, 2020, 10:24 a.m. UTC | #1
I think it should be better to read the proxy config which port is used.
Many installtions still use 800

Arne


Am 2020-04-01 11:02, schrieb Stefan Schantl:
> Fixes #12308.
> 
> Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
> ---
>  config/suricata/suricata.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/config/suricata/suricata.yaml 
> b/config/suricata/suricata.yaml
> index cb7ececb4..4a605c272 100644
> --- a/config/suricata/suricata.yaml
> +++ b/config/suricata/suricata.yaml
> @@ -30,7 +30,7 @@ vars:
>      ENIP_SERVER: "$HOME_NET"
> 
>    port-groups:
> -    HTTP_PORTS: "[80,81]"
> +    HTTP_PORTS: "[80,81,3128]"
>      SHELLCODE_PORTS: "!80"
>      ORACLE_PORTS: 1521
>      SSH_PORTS: "[22,222]"
Michael Tremer April 1, 2020, 10:54 a.m. UTC | #2
> On 1 Apr 2020, at 11:24, Arne Fitzenreiter <arne_f@ipfire.org> wrote:
> 
> I think it should be better to read the proxy config which port is used.
> Many installtions still use 800

Absolutely.

Why do we only add the transparent port here and not the default port?

-Michael

> 
> Arne
> 
> 
> Am 2020-04-01 11:02, schrieb Stefan Schantl:
>> Fixes #12308.
>> Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
>> ---
>> config/suricata/suricata.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> diff --git a/config/suricata/suricata.yaml b/config/suricata/suricata.yaml
>> index cb7ececb4..4a605c272 100644
>> --- a/config/suricata/suricata.yaml
>> +++ b/config/suricata/suricata.yaml
>> @@ -30,7 +30,7 @@ vars:
>>     ENIP_SERVER: "$HOME_NET"
>>   port-groups:
>> -    HTTP_PORTS: "[80,81]"
>> +    HTTP_PORTS: "[80,81,3128]"
>>     SHELLCODE_PORTS: "!80"
>>     ORACLE_PORTS: 1521
>>     SSH_PORTS: "[22,222]"

Patch

diff --git a/config/suricata/suricata.yaml b/config/suricata/suricata.yaml
index cb7ececb4..4a605c272 100644
--- a/config/suricata/suricata.yaml
+++ b/config/suricata/suricata.yaml
@@ -30,7 +30,7 @@  vars:
     ENIP_SERVER: "$HOME_NET"
 
   port-groups:
-    HTTP_PORTS: "[80,81]"
+    HTTP_PORTS: "[80,81,3128]"
     SHELLCODE_PORTS: "!80"
     ORACLE_PORTS: 1521
     SSH_PORTS: "[22,222]"