convert-snort: Fix logic for detecting enough free disk space.

Message ID 20190408180253.5394-1-stefan.schantl@ipfire.org
State Accepted
Commit e4bc9b8b6fa0cc0d67d2f698e2bdd5d41af49f05
Headers
Series convert-snort: Fix logic for detecting enough free disk space. |

Commit Message

Stefan Schantl April 9, 2019, 4:02 a.m. UTC
  The subfunction only will return something if the check fails - so the logic
of the if statement was wrong set and the downloader only was called if
this check failed and to less diskspace would be available.

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
---
 config/suricata/convert-snort | 3 +++
 1 file changed, 3 insertions(+)
  

Patch

diff --git a/config/suricata/convert-snort b/config/suricata/convert-snort
index ca650b149..19aa38fbc 100644
--- a/config/suricata/convert-snort
+++ b/config/suricata/convert-snort
@@ -231,6 +231,9 @@  if (-f $snort_rules_tarball) {
 } else {
 	# Check if enought disk space is available.
 	if(&IDS::checkdiskspace()) {
+		# Print error message.
+		print "Could not download ruleset - Not enough free diskspace available.\n";
+	} else {
 		# Call the download function and grab the new ruleset.
 		&IDS::downloadruleset();
 	}