Message ID | 20171124203255.5ae990c1.peter.mueller@link38.eu |
---|---|
State | Accepted |
Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (unknown [172.28.1.200]) by web02.ipfire.org (Postfix) with ESMTP id AE86260238 for <patchwork@ipfire.org>; Fri, 24 Nov 2017 20:33:05 +0100 (CET) Received: from mail01.ipfire.org (localhost [IPv6:::1]) by mail01.ipfire.org (Postfix) with ESMTP id 46FB51BE5; Fri, 24 Nov 2017 20:33:05 +0100 (CET) Received: from mx.link38.eu (mx.link38.eu [188.68.43.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx.link38.eu", Issuer "Let's Encrypt Authority X3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id C8F101942 for <development@lists.ipfire.org>; Fri, 24 Nov 2017 20:33:02 +0100 (CET) X-Virus-Scanned: ClamAV at mx.link38.eu Received: from mx-fra.brokers.link38.eu (mx-fra.brokers.link38.eu [10.141.75.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx.link38.eu (Postfix) with ESMTPS id 2D30940123 for <development@lists.ipfire.org>; Fri, 24 Nov 2017 20:32:57 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx-fra.brokers.link38.eu (Postfix) with ESMTPSA id 956CA9F392 for <development@lists.ipfire.org>; Fri, 24 Nov 2017 20:32:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=link38.eu; s=201711; t=1511551976; x=1574623976; bh=ALg0xzRnMbHPEYP38iYqcZdKiTYQIYqZuVbtfsk5its=; h=Date:From:To:Subject:Message-ID:Content-Type:From:To:Subject:Date: Cc; b=uLQS7fEeWsyaBQeR6hp1/o1xS7Ctg3E/5OpJ8ix81XCwhLuFFuRZyvsZ3jVtHrAfj 4aQcbJQ2cV9Ikx76v61Jr+HuwbN8/YQ43pASTfGVeZEeZZEAzmGAyiRZZWQ0UEaNvx IN1cWktqANpS5IYwr8HrQfqYBqYQPPPXoApRd8c7w5Vj5ub2/0Gb8a0zIK7XuL5vLH s1lS5emRxPBxiV8iekGnYdbRQjq8ANtbhVWPlaXl6CJsl1CkH/h1jpnqh7VRqVL7Wy 7y4e4b5AdcI7AYpWS40CM3HKThftPEI8q2yKd9BVp1kzBhkq5Kxc24G987EGH2yMWZ +KF1GcKYI1WGQ== Date: Fri, 24 Nov 2017 20:32:55 +0100 From: Peter =?utf-8?q?M=C3=BCller?= <peter.mueller@link38.eu> To: "development@lists.ipfire.org" <development@lists.ipfire.org> Subject: [PATCH] correct wrong headline at hardwaregraphs.cgi Message-ID: <20171124203255.5ae990c1.peter.mueller@link38.eu> Organization: Link38 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> List-Unsubscribe: <https://lists.ipfire.org/mailman/options/development>, <mailto:development-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <https://lists.ipfire.org/pipermail/development/> List-Post: <mailto:development@lists.ipfire.org> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Subscribe: <https://lists.ipfire.org/mailman/listinfo/development>, <mailto:development-request@lists.ipfire.org?subject=subscribe> Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org> |
Series |
correct wrong headline at hardwaregraphs.cgi
|
|
Commit Message
Peter Müller
Nov. 25, 2017, 6:32 a.m. UTC
The page description (title and headline) should print
"hardware graphs" instead of only mentioning HDDs.
Signed-off-by: Peter Müller <peter.mueller@link38.eu>
---
html/cgi-bin/hardwaregraphs.cgi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
The word "Graph" in the titles of all the graphs is redundant (at least in English grammar). Its pretty apparent we are looking at a graph. :) On Nov 24, 2017 11:33 AM, "Peter Müller" <peter.mueller@link38.eu> wrote: > The page description (title and headline) should print > "hardware graphs" instead of only mentioning HDDs. > > Signed-off-by: Peter Müller <peter.mueller@link38.eu> > --- > html/cgi-bin/hardwaregraphs.cgi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/html/cgi-bin/hardwaregraphs.cgi > b/html/cgi-bin/hardwaregraphs.cgi > index 7b5a848bf..f5999c87e 100644 > --- a/html/cgi-bin/hardwaregraphs.cgi > +++ b/html/cgi-bin/hardwaregraphs.cgi > @@ -73,7 +73,7 @@ if ( $querry[0] =~ "hwtemp"){ > &Graphs::updatehddgraph($querry[0],$querry[1]); > }else{ > &Header::showhttpheaders(); > - &Header::openpage($Lang::tr{'harddisk temperature graphs'}, 1, > ''); > + &Header::openpage($Lang::tr{'hardware graphs'}, 1, ''); > &Header::openbigbox('100%', 'left'); > > &Header::getcgihash(\%sensorsettings); > -- > 2.13.6 > > > <div dir="auto">The word "Graph" in the titles of all the graphs is redundant (at least in English grammar). Its pretty apparent we are looking at a graph. :) </div><div class="gmail_extra"><br><div class="gmail_quote">On Nov 24, 2017 11:33 AM, "Peter Müller" <<a href="mailto:peter.mueller@link38.eu">peter.mueller@link38.eu</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The page description (title and headline) should print<br> "hardware graphs" instead of only mentioning HDDs.<br> <br> Signed-off-by: Peter Müller <<a href="mailto:peter.mueller@link38.eu">peter.mueller@link38.eu</a>><br> ---<br> html/cgi-bin/hardwaregraphs.<wbr>cgi | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br> <br> diff --git a/html/cgi-bin/hardwaregraphs.<wbr>cgi b/html/cgi-bin/hardwaregraphs.<wbr>cgi<br> index 7b5a848bf..f5999c87e 100644<br> --- a/html/cgi-bin/hardwaregraphs.<wbr>cgi<br> +++ b/html/cgi-bin/hardwaregraphs.<wbr>cgi<br> @@ -73,7 +73,7 @@ if ( $querry[0] =~ "hwtemp"){<br> &Graphs::updatehddgraph($<wbr>querry[0],$querry[1]);<br> }else{<br> &Header::showhttpheaders();<br> - &Header::openpage($Lang::tr{'<wbr>harddisk temperature graphs'}, 1, '');<br> + &Header::openpage($Lang::tr{'<wbr>hardware graphs'}, 1, '');<br> &Header::openbigbox('100%', 'left');<br> <br> &Header::getcgihash(\%<wbr>sensorsettings);<br> --<br> 2.13.6<br> <br> <br> </blockquote></div></div>
Hello, yes, but I thought it should print at least the right redundancy. :-) Best regards, Peter Müller > The word "Graph" in the titles of all the graphs is redundant (at least in > English grammar). Its pretty apparent we are looking at a graph. :) > > On Nov 24, 2017 11:33 AM, "Peter Müller" <peter.mueller@link38.eu> wrote: > > > The page description (title and headline) should print > > "hardware graphs" instead of only mentioning HDDs. > > > > Signed-off-by: Peter Müller <peter.mueller@link38.eu> > > --- > > html/cgi-bin/hardwaregraphs.cgi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/html/cgi-bin/hardwaregraphs.cgi > > b/html/cgi-bin/hardwaregraphs.cgi > > index 7b5a848bf..f5999c87e 100644 > > --- a/html/cgi-bin/hardwaregraphs.cgi > > +++ b/html/cgi-bin/hardwaregraphs.cgi > > @@ -73,7 +73,7 @@ if ( $querry[0] =~ "hwtemp"){ > > &Graphs::updatehddgraph($querry[0],$querry[1]); > > }else{ > > &Header::showhttpheaders(); > > - &Header::openpage($Lang::tr{'harddisk temperature graphs'}, 1, > > ''); > > + &Header::openpage($Lang::tr{'hardware graphs'}, 1, ''); > > &Header::openbigbox('100%', 'left'); > > > > &Header::getcgihash(\%sensorsettings); > > -- > > 2.13.6 > > > > > >
diff --git a/html/cgi-bin/hardwaregraphs.cgi b/html/cgi-bin/hardwaregraphs.cgi index 7b5a848bf..f5999c87e 100644 --- a/html/cgi-bin/hardwaregraphs.cgi +++ b/html/cgi-bin/hardwaregraphs.cgi @@ -73,7 +73,7 @@ if ( $querry[0] =~ "hwtemp"){ &Graphs::updatehddgraph($querry[0],$querry[1]); }else{ &Header::showhttpheaders(); - &Header::openpage($Lang::tr{'harddisk temperature graphs'}, 1, ''); + &Header::openpage($Lang::tr{'hardware graphs'}, 1, ''); &Header::openbigbox('100%', 'left'); &Header::getcgihash(\%sensorsettings);