correct wrong headline at hardwaregraphs.cgi

Message ID 20171124203255.5ae990c1.peter.mueller@link38.eu
State Accepted
Headers
Series correct wrong headline at hardwaregraphs.cgi |

Commit Message

Peter Müller Nov. 25, 2017, 6:32 a.m. UTC
  The page description (title and headline) should print
"hardware graphs" instead of only mentioning HDDs.

Signed-off-by: Peter Müller <peter.mueller@link38.eu>
---
 html/cgi-bin/hardwaregraphs.cgi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Codermotor Nov. 26, 2017, 7:56 a.m. UTC | #1
The word "Graph" in the titles of all the graphs is redundant  (at least in
English grammar). Its pretty apparent we are looking at a graph. :)

On Nov 24, 2017 11:33 AM, "Peter Müller" <peter.mueller@link38.eu> wrote:

> The page description (title and headline) should print
> "hardware graphs" instead of only mentioning HDDs.
>
> Signed-off-by: Peter Müller <peter.mueller@link38.eu>
> ---
>  html/cgi-bin/hardwaregraphs.cgi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/html/cgi-bin/hardwaregraphs.cgi
> b/html/cgi-bin/hardwaregraphs.cgi
> index 7b5a848bf..f5999c87e 100644
> --- a/html/cgi-bin/hardwaregraphs.cgi
> +++ b/html/cgi-bin/hardwaregraphs.cgi
> @@ -73,7 +73,7 @@ if ( $querry[0] =~ "hwtemp"){
>         &Graphs::updatehddgraph($querry[0],$querry[1]);
>  }else{
>         &Header::showhttpheaders();
> -       &Header::openpage($Lang::tr{'harddisk temperature graphs'}, 1,
> '');
> +       &Header::openpage($Lang::tr{'hardware graphs'}, 1, '');
>         &Header::openbigbox('100%', 'left');
>
>         &Header::getcgihash(\%sensorsettings);
> --
> 2.13.6
>
>
>
<div dir="auto">The word &quot;Graph&quot; in the titles of all the graphs is redundant  (at least in English grammar). Its pretty apparent we are looking at a graph. :) </div><div class="gmail_extra"><br><div class="gmail_quote">On Nov 24, 2017 11:33 AM, &quot;Peter Müller&quot; &lt;<a href="mailto:peter.mueller@link38.eu">peter.mueller@link38.eu</a>&gt; wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The page description (title and headline) should print<br>
&quot;hardware graphs&quot; instead of only mentioning HDDs.<br>
<br>
Signed-off-by: Peter Müller &lt;<a href="mailto:peter.mueller@link38.eu">peter.mueller@link38.eu</a>&gt;<br>
---<br>
 html/cgi-bin/hardwaregraphs.<wbr>cgi | 2 +-<br>
 1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/html/cgi-bin/hardwaregraphs.<wbr>cgi b/html/cgi-bin/hardwaregraphs.<wbr>cgi<br>
index 7b5a848bf..f5999c87e 100644<br>
--- a/html/cgi-bin/hardwaregraphs.<wbr>cgi<br>
+++ b/html/cgi-bin/hardwaregraphs.<wbr>cgi<br>
@@ -73,7 +73,7 @@ if ( $querry[0] =~ &quot;hwtemp&quot;){<br>
        &amp;Graphs::updatehddgraph($<wbr>querry[0],$querry[1]);<br>
 }else{<br>
        &amp;Header::showhttpheaders();<br>
-       &amp;Header::openpage($Lang::tr{&#39;<wbr>harddisk temperature graphs&#39;}, 1, &#39;&#39;);<br>
+       &amp;Header::openpage($Lang::tr{&#39;<wbr>hardware graphs&#39;}, 1, &#39;&#39;);<br>
        &amp;Header::openbigbox(&#39;100%&#39;, &#39;left&#39;);<br>
<br>
        &amp;Header::getcgihash(\%<wbr>sensorsettings);<br>
--<br>
2.13.6<br>
<br>
<br>
</blockquote></div></div>
  
Peter Müller Nov. 28, 2017, 4:02 a.m. UTC | #2
Hello,

yes, but I thought it should print at least the right redundancy. :-)

Best regards,
Peter Müller

> The word "Graph" in the titles of all the graphs is redundant  (at least in
> English grammar). Its pretty apparent we are looking at a graph. :)
> 
> On Nov 24, 2017 11:33 AM, "Peter Müller" <peter.mueller@link38.eu> wrote:
> 
> > The page description (title and headline) should print
> > "hardware graphs" instead of only mentioning HDDs.
> >
> > Signed-off-by: Peter Müller <peter.mueller@link38.eu>
> > ---
> >  html/cgi-bin/hardwaregraphs.cgi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/html/cgi-bin/hardwaregraphs.cgi
> > b/html/cgi-bin/hardwaregraphs.cgi
> > index 7b5a848bf..f5999c87e 100644
> > --- a/html/cgi-bin/hardwaregraphs.cgi
> > +++ b/html/cgi-bin/hardwaregraphs.cgi
> > @@ -73,7 +73,7 @@ if ( $querry[0] =~ "hwtemp"){
> >         &Graphs::updatehddgraph($querry[0],$querry[1]);
> >  }else{
> >         &Header::showhttpheaders();
> > -       &Header::openpage($Lang::tr{'harddisk temperature graphs'}, 1,
> > '');
> > +       &Header::openpage($Lang::tr{'hardware graphs'}, 1, '');
> >         &Header::openbigbox('100%', 'left');
> >
> >         &Header::getcgihash(\%sensorsettings);
> > --
> > 2.13.6
> >
> >
> >
  

Patch

diff --git a/html/cgi-bin/hardwaregraphs.cgi b/html/cgi-bin/hardwaregraphs.cgi
index 7b5a848bf..f5999c87e 100644
--- a/html/cgi-bin/hardwaregraphs.cgi
+++ b/html/cgi-bin/hardwaregraphs.cgi
@@ -73,7 +73,7 @@  if ( $querry[0] =~ "hwtemp"){
 	&Graphs::updatehddgraph($querry[0],$querry[1]);
 }else{
 	&Header::showhttpheaders();
-	&Header::openpage($Lang::tr{'harddisk temperature graphs'}, 1, '');
+	&Header::openpage($Lang::tr{'hardware graphs'}, 1, '');
 	&Header::openbigbox('100%', 'left');
 
 	&Header::getcgihash(\%sensorsettings);