diff mbox series

[v3] download ET IDS rules via HTTPS

Message ID 1708b1ac-091c-392f-b944-918ab7efbba2@link38.eu
State Accepted
Headers
Series [v3] download ET IDS rules via HTTPS |

Commit Message

Peter Müller Aug. 17, 2018, 1:09 a.m. UTC 
  The Emerging Threats ruleset server supports HTTPS. It should
be used for downloading the ruleset in IPFire, too.

This also needs to be applied on the upcoming ids.cgi file for Suricata
which I will do in a second patch.

The third version of this patch superseds the first and
second one which were broken due to bugs in the MUAs GPG
implementation.

Signed-off-by: Peter Müller <peter.mueller@link38.eu>
---
 html/cgi-bin/ids.cgi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Tremer Aug. 17, 2018, 4:05 a.m. UTC | #1 
Merged.

On Thu, 2018-08-16 at 17:09 +0200, Peter Müller wrote:
> The Emerging Threats ruleset server supports HTTPS. It should
> be used for downloading the ruleset in IPFire, too.
> 
> This also needs to be applied on the upcoming ids.cgi file for Suricata
> which I will do in a second patch.
> 
> The third version of this patch superseds the first and
> second one which were broken due to bugs in the MUAs GPG
> implementation.
> 
> Signed-off-by: Peter Müller <peter.mueller@link38.eu>
> ---
>  html/cgi-bin/ids.cgi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/html/cgi-bin/ids.cgi b/html/cgi-bin/ids.cgi
> index 9863251e2..d9d697deb 100644
> --- a/html/cgi-bin/ids.cgi
> +++ b/html/cgi-bin/ids.cgi
> @@ -265,7 +265,7 @@ if (!$errormessage) {
>  	} elsif ($snortsettings{'RULES'} eq 'community') {
>  		$url=" https://www.snort.org/rules/community";
>  	} else {
> -		$url="
> http://rules.emergingthreats.net/open/snort-2.9.0/emerging.rules.tar.gz";
> +		$url="
> https://rules.emergingthreats.net/open/snort-2.9.0/emerging.rules.tar.gz";
>  	}
>  
>  	if ($snortsettings{'ACTION'} eq $Lang::tr{'save'} &&
> $snortsettings{'ACTION2'} eq "snort" ) {
diff mbox series

Patch

diff --git a/html/cgi-bin/ids.cgi b/html/cgi-bin/ids.cgi
index 9863251e2..d9d697deb 100644
--- a/html/cgi-bin/ids.cgi
+++ b/html/cgi-bin/ids.cgi
@@ -265,7 +265,7 @@  if (!$errormessage) {
 	} elsif ($snortsettings{'RULES'} eq 'community') {
 		$url=" https://www.snort.org/rules/community";
 	} else {
-		$url="http://rules.emergingthreats.net/open/snort-2.9.0/emerging.rules.tar.gz";
+		$url="https://rules.emergingthreats.net/open/snort-2.9.0/emerging.rules.tar.gz";
 	}
 
 	if ($snortsettings{'ACTION'} eq $Lang::tr{'save'} && $snortsettings{'ACTION2'} eq "snort" ) {