[4/5] Add new package python3-msgpack

Message ID 1549021965-16633-4-git-send-email-jonatan.schlag@ipfire.org
State Accepted
Commit def9f4a3e074e1401c6f40946833785d4b27ce66
Headers
Series [1/5] Add new package python3-settuptools |

Commit Message

Jonatan Schlag Feb. 1, 2019, 10:52 p.m. UTC
  Signed-off-by: Jonatan Schlag <jonatan.schlag@ipfire.org>
---
 config/rootfiles/packages/python3-msgpack | 17 +++++++
 lfs/python3-msgpack                       | 83 +++++++++++++++++++++++++++++++
 make.sh                                   |  1 +
 3 files changed, 101 insertions(+)
 create mode 100644 config/rootfiles/packages/python3-msgpack
 create mode 100644 lfs/python3-msgpack
  

Comments

Matthias Fischer Feb. 3, 2019, 12:52 p.m. UTC | #1
Hi,

Something weird happened.

While building and packaging current 'next' I ran into an error with
'python3-msgpack':

***SNIP***
...
'/usr/src/config/rootfiles/packages//python3-msgpack' ->
'/install/packages/package/ROOTFILES'
tar:
usr/lib/python3.6/site-packages/msgpack/_packer.cpython-36m-i586-linux-gnu.so:
Cannot stat: No such file or directory
tar:
usr/lib/python3.6/site-packages/msgpack/_unpacker.cpython-36m-i586-linux-gnu.so:
Cannot stat: No such file or directory
tar: Exiting with failure status due to previous errors
make: *** [python3-msgpack:58: dist] Error 2
...

ERROR: Packaging python3-msgpack                               [ FAIL ]
Check /home/matz/ipfire-2.x/log/_build.packages.log for errors if
applicable                                                     [ FAIL ]

***SNAP***

I tested with current 'curl 7.63' and 'dhcpcd 7.1.0'.

'log/msgpack-python-0.5.6' shows the following entries:

...
+usr/lib/python3.6/site-packages/msgpack/_packer.cpython-36m-i386-linux-gnu.so
+usr/lib/python3.6/site-packages/msgpack/_unpacker.cpython-36m-i386-linux-gnu.so
...
-usr/lib/python3.6/site-packages/msgpack/_packer.cpython-36m-i586-linux-gnu.so
-usr/lib/python3.6/site-packages/msgpack/_unpacker.cpython-36m-i586-linux-gnu.so
...

As you can see, "MACHINE" got translated into 'i386' here. These files
exist, but can't be found during packaging. It looks for 'i586'.

Can anyone confirm?

Best,
Matthias

On 01.02.2019 12:52, Jonatan Schlag wrote:
> Signed-off-by: Jonatan Schlag <jonatan.schlag@ipfire.org>
> ---
>  config/rootfiles/packages/python3-msgpack | 17 +++++++
>  lfs/python3-msgpack                       | 83 +++++++++++++++++++++++++++++++
>  make.sh                                   |  1 +
>  3 files changed, 101 insertions(+)
>  create mode 100644 config/rootfiles/packages/python3-msgpack
>  create mode 100644 lfs/python3-msgpack
> 
> diff --git a/config/rootfiles/packages/python3-msgpack b/config/rootfiles/packages/python3-msgpack
> new file mode 100644
> index 0000000..1cc53c4
> --- /dev/null
> +++ b/config/rootfiles/packages/python3-msgpack
> @@ -0,0 +1,17 @@
> +#usr/lib/python3.6/site-packages/msgpack
> +usr/lib/python3.6/site-packages/msgpack/__init__.py
> +usr/lib/python3.6/site-packages/msgpack/__pycache__
> +usr/lib/python3.6/site-packages/msgpack/__pycache__/__init__.cpython-36.pyc
> +usr/lib/python3.6/site-packages/msgpack/__pycache__/_version.cpython-36.pyc
> +usr/lib/python3.6/site-packages/msgpack/__pycache__/exceptions.cpython-36.pyc
> +usr/lib/python3.6/site-packages/msgpack/__pycache__/fallback.cpython-36.pyc
> +usr/lib/python3.6/site-packages/msgpack/_packer.cpython-36m-MACHINE-linux-gnu.so
> +usr/lib/python3.6/site-packages/msgpack/_unpacker.cpython-36m-MACHINE-linux-gnu.so
> +usr/lib/python3.6/site-packages/msgpack/_version.py
> +usr/lib/python3.6/site-packages/msgpack/exceptions.py
> +usr/lib/python3.6/site-packages/msgpack/fallback.py
> +usr/lib/python3.6/site-packages/msgpack_python-0.5.6-py3.6.egg-info
> +usr/lib/python3.6/site-packages/msgpack_python-0.5.6-py3.6.egg-info/PKG-INFO
> +usr/lib/python3.6/site-packages/msgpack_python-0.5.6-py3.6.egg-info/SOURCES.txt
> +usr/lib/python3.6/site-packages/msgpack_python-0.5.6-py3.6.egg-info/dependency_links.txt
> +usr/lib/python3.6/site-packages/msgpack_python-0.5.6-py3.6.egg-info/top_level.txt
> diff --git a/lfs/python3-msgpack b/lfs/python3-msgpack
> new file mode 100644
> index 0000000..1d9280a
> --- /dev/null
> +++ b/lfs/python3-msgpack
> @@ -0,0 +1,83 @@
> +###############################################################################
> +#                                                                             #
> +# IPFire.org - A linux based firewall                                         #
> +# Copyright (C) 2007-2018  IPFire Team  <info@ipfire.org>                     #
> +#                                                                             #
> +# This program is free software: you can redistribute it and/or modify        #
> +# it under the terms of the GNU General Public License as published by        #
> +# the Free Software Foundation, either version 3 of the License, or           #
> +# (at your option) any later version.                                         #
> +#                                                                             #
> +# This program is distributed in the hope that it will be useful,             #
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of              #
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the               #
> +# GNU General Public License for more details.                                #
> +#                                                                             #
> +# You should have received a copy of the GNU General Public License           #
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.       #
> +#                                                                             #
> +###############################################################################
> +
> +###############################################################################
> +# Definitions
> +###############################################################################
> +
> +include Config
> +
> +VER        = 0.5.6
> +
> +THISAPP    = msgpack-python-$(VER)
> +DL_FILE    = $(THISAPP).tar.gz
> +DL_FROM    = $(URL_IPFIRE)
> +DIR_APP    = $(DIR_SRC)/$(THISAPP)
> +TARGET     = $(DIR_INFO)/$(THISAPP)
> +PROG       = python3-msgpack
> +PAK_VER    = 1
> +
> +DEPS       = "python3"
> +
> +###############################################################################
> +# Top-level Rules
> +###############################################################################
> +
> +objects = $(DL_FILE)
> +
> +$(DL_FILE) = $(DL_FROM)/$(DL_FILE)
> +
> +$(DL_FILE)_MD5 = 6d644c06a87a5a111bbbf5b34b4be440
> +
> +install : $(TARGET)
> +
> +check : $(patsubst %,$(DIR_CHK)/%,$(objects))
> +
> +download :$(patsubst %,$(DIR_DL)/%,$(objects))
> +
> +md5 : $(subst %,%_MD5,$(objects))
> +
> +dist: 
> +	@$(PAK)
> +
> +###############################################################################
> +# Downloading, checking, md5sum
> +###############################################################################
> +
> +$(patsubst %,$(DIR_CHK)/%,$(objects)) :
> +	@$(CHECK)
> +
> +$(patsubst %,$(DIR_DL)/%,$(objects)) :
> +	@$(LOAD)
> +
> +$(subst %,%_MD5,$(objects)) :
> +	@$(MD5)
> +
> +###############################################################################
> +# Installation Details
> +###############################################################################
> +
> +$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> +	@$(PREBUILD)
> +	@rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar zxf $(DIR_DL)/$(DL_FILE)
> +	cd $(DIR_APP) && python3 setup.py build
> +	cd $(DIR_APP) && python3 setup.py install --root=/
> +	@rm -rf $(DIR_APP)
> +	@$(POSTBUILD)
> diff --git a/make.sh b/make.sh
> index 9eb4fbf..68882fc 100755
> --- a/make.sh
> +++ b/make.sh
> @@ -1513,6 +1513,7 @@ buildipfire() {
>    lfsmake2 python3-pyasn1
>    lfsmake2 python3-botocore
>    lfsmake2 python3-llfuse
> +  lfsmake2 python3-msgpack
>    lfsmake2 aws-cli
>    lfsmake2 transmission
>    lfsmake2 dpfhack
>
  
Matthias Fischer Feb. 4, 2019, 12:19 a.m. UTC | #2
On 03.02.2019 02:52, Matthias Fischer wrote:
> Hi,
> 
> Something weird happened.
> 
> While building and packaging current 'next' I ran into an error with
> 'python3-msgpack':
> 
> ***SNIP***
> ...
> '/usr/src/config/rootfiles/packages//python3-msgpack' ->
> '/install/packages/package/ROOTFILES'
> tar:
> usr/lib/python3.6/site-packages/msgpack/_packer.cpython-36m-i586-linux-gnu.so:
> Cannot stat: No such file or directory
> tar:
> usr/lib/python3.6/site-packages/msgpack/_unpacker.cpython-36m-i586-linux-gnu.so:
> Cannot stat: No such file or directory
> tar: Exiting with failure status due to previous errors
> make: *** [python3-msgpack:58: dist] Error 2
> ...
> 
> ERROR: Packaging python3-msgpack                               [ FAIL ]
> Check /home/matz/ipfire-2.x/log/_build.packages.log for errors if
> applicable                                                     [ FAIL ]
> 
> ***SNAP***
> ...

Confirmed with second - clean - build using current 'next', this time
without 'curl 7.63.0'. Identical error.

Best,
Matthias
  
Michael Tremer Feb. 4, 2019, 8:45 a.m. UTC | #3
Sorry, I overlooked those in Jonatan’s patch.

Arne has fixed this next now - I believe.

-Michael

> On 3 Feb 2019, at 13:19, Matthias Fischer <matthias.fischer@ipfire.org> wrote:
> 
> On 03.02.2019 02:52, Matthias Fischer wrote:
>> Hi,
>> 
>> Something weird happened.
>> 
>> While building and packaging current 'next' I ran into an error with
>> 'python3-msgpack':
>> 
>> ***SNIP***
>> ...
>> '/usr/src/config/rootfiles/packages//python3-msgpack' ->
>> '/install/packages/package/ROOTFILES'
>> tar:
>> usr/lib/python3.6/site-packages/msgpack/_packer.cpython-36m-i586-linux-gnu.so:
>> Cannot stat: No such file or directory
>> tar:
>> usr/lib/python3.6/site-packages/msgpack/_unpacker.cpython-36m-i586-linux-gnu.so:
>> Cannot stat: No such file or directory
>> tar: Exiting with failure status due to previous errors
>> make: *** [python3-msgpack:58: dist] Error 2
>> ...
>> 
>> ERROR: Packaging python3-msgpack                               [ FAIL ]
>> Check /home/matz/ipfire-2.x/log/_build.packages.log for errors if
>> applicable                                                     [ FAIL ]
>> 
>> ***SNAP***
>> ...
> 
> Confirmed with second - clean - build using current 'next', this time
> without 'curl 7.63.0'. Identical error.
> 
> Best,
> Matthias
  
Matthias Fischer Feb. 5, 2019, 4:23 a.m. UTC | #4
Hi,

On 03.02.2019 22:45, Michael Tremer wrote:
> Sorry, I overlooked those in Jonatan’s patch.
> 
> Arne has fixed this next now - I believe.

Sorry, that didn't help.

Tonight I made a third test build containing your fix: same error as below.

Contents of /build/usr/lib/python3.6/site-packages/msgpack/:

...
root@Devel:
/home/matz/ipfire-2.x/build/usr/lib/python3.6/site-packages/msgpack # ls -l
total 292
-rw-r--r-- 1 root root   1056 Jul 30  2016 exceptions.py
-rw-r--r-- 1 root root  35973 Mar 10  2018 fallback.py
-rw-r--r-- 1 root root   1605 Mar 10  2018 __init__.py
-rwxr-xr-x 1 root root 108124 Feb  4 01:56
_packer.cpython-36m-i386-linux-gnu.so
drwxr-xr-x 2 root root   4096 Feb  4 01:29 __pycache__
-rwxr-xr-x 1 root root 134828 Feb  4 01:56
_unpacker.cpython-36m-i386-linux-gnu.so
-rw-r--r-- 1 root root     20 Mar 10  2018 _version.py
...

Something I can do?

Best,
Matthias

> -Michael
> 
>> On 3 Feb 2019, at 13:19, Matthias Fischer <matthias.fischer@ipfire.org> wrote:
>> 
>> On 03.02.2019 02:52, Matthias Fischer wrote:
>>> Hi,
>>> 
>>> Something weird happened.
>>> 
>>> While building and packaging current 'next' I ran into an error with
>>> 'python3-msgpack':
>>> 
>>> ***SNIP***
>>> ...
>>> '/usr/src/config/rootfiles/packages//python3-msgpack' ->
>>> '/install/packages/package/ROOTFILES'
>>> tar:
>>> usr/lib/python3.6/site-packages/msgpack/_packer.cpython-36m-i586-linux-gnu.so:
>>> Cannot stat: No such file or directory
>>> tar:
>>> usr/lib/python3.6/site-packages/msgpack/_unpacker.cpython-36m-i586-linux-gnu.so:
>>> Cannot stat: No such file or directory
>>> tar: Exiting with failure status due to previous errors
>>> make: *** [python3-msgpack:58: dist] Error 2
>>> ...
>>> 
>>> ERROR: Packaging python3-msgpack                               [ FAIL ]
>>> Check /home/matz/ipfire-2.x/log/_build.packages.log for errors if
>>> applicable                                                     [ FAIL ]
>>> 
>>> ***SNAP***
>>> ...
>> 
>> Confirmed with second - clean - build using current 'next', this time
>> without 'curl 7.63.0'. Identical error.
>> 
>> Best,
>> Matthias
> 
>
  
Michael Tremer Feb. 5, 2019, 9:44 a.m. UTC | #5
I gave Jonatan a call today and made him aware of this.

Please get this fixed as soon as possible.

-Michael

> On 4 Feb 2019, at 17:23, Matthias Fischer <matthias.fischer@ipfire.org> wrote:
> 
> Hi,
> 
> On 03.02.2019 22:45, Michael Tremer wrote:
>> Sorry, I overlooked those in Jonatan’s patch.
>> 
>> Arne has fixed this next now - I believe.
> 
> Sorry, that didn't help.
> 
> Tonight I made a third test build containing your fix: same error as below.
> 
> Contents of /build/usr/lib/python3.6/site-packages/msgpack/:
> 
> ...
> root@Devel:
> /home/matz/ipfire-2.x/build/usr/lib/python3.6/site-packages/msgpack # ls -l
> total 292
> -rw-r--r-- 1 root root   1056 Jul 30  2016 exceptions.py
> -rw-r--r-- 1 root root  35973 Mar 10  2018 fallback.py
> -rw-r--r-- 1 root root   1605 Mar 10  2018 __init__.py
> -rwxr-xr-x 1 root root 108124 Feb  4 01:56
> _packer.cpython-36m-i386-linux-gnu.so
> drwxr-xr-x 2 root root   4096 Feb  4 01:29 __pycache__
> -rwxr-xr-x 1 root root 134828 Feb  4 01:56
> _unpacker.cpython-36m-i386-linux-gnu.so
> -rw-r--r-- 1 root root     20 Mar 10  2018 _version.py
> ...
> 
> Something I can do?
> 
> Best,
> Matthias
> 
>> -Michael
>> 
>>> On 3 Feb 2019, at 13:19, Matthias Fischer <matthias.fischer@ipfire.org> wrote:
>>> 
>>> On 03.02.2019 02:52, Matthias Fischer wrote:
>>>> Hi,
>>>> 
>>>> Something weird happened.
>>>> 
>>>> While building and packaging current 'next' I ran into an error with
>>>> 'python3-msgpack':
>>>> 
>>>> ***SNIP***
>>>> ...
>>>> '/usr/src/config/rootfiles/packages//python3-msgpack' ->
>>>> '/install/packages/package/ROOTFILES'
>>>> tar:
>>>> usr/lib/python3.6/site-packages/msgpack/_packer.cpython-36m-i586-linux-gnu.so:
>>>> Cannot stat: No such file or directory
>>>> tar:
>>>> usr/lib/python3.6/site-packages/msgpack/_unpacker.cpython-36m-i586-linux-gnu.so:
>>>> Cannot stat: No such file or directory
>>>> tar: Exiting with failure status due to previous errors
>>>> make: *** [python3-msgpack:58: dist] Error 2
>>>> ...
>>>> 
>>>> ERROR: Packaging python3-msgpack                               [ FAIL ]
>>>> Check /home/matz/ipfire-2.x/log/_build.packages.log for errors if
>>>> applicable                                                     [ FAIL ]
>>>> 
>>>> ***SNAP***
>>>> ...
>>> 
>>> Confirmed with second - clean - build using current 'next', this time
>>> without 'curl 7.63.0'. Identical error.
>>> 
>>> Best,
>>> Matthias
>> 
>>
  

Patch

diff --git a/config/rootfiles/packages/python3-msgpack b/config/rootfiles/packages/python3-msgpack
new file mode 100644
index 0000000..1cc53c4
--- /dev/null
+++ b/config/rootfiles/packages/python3-msgpack
@@ -0,0 +1,17 @@ 
+#usr/lib/python3.6/site-packages/msgpack
+usr/lib/python3.6/site-packages/msgpack/__init__.py
+usr/lib/python3.6/site-packages/msgpack/__pycache__
+usr/lib/python3.6/site-packages/msgpack/__pycache__/__init__.cpython-36.pyc
+usr/lib/python3.6/site-packages/msgpack/__pycache__/_version.cpython-36.pyc
+usr/lib/python3.6/site-packages/msgpack/__pycache__/exceptions.cpython-36.pyc
+usr/lib/python3.6/site-packages/msgpack/__pycache__/fallback.cpython-36.pyc
+usr/lib/python3.6/site-packages/msgpack/_packer.cpython-36m-MACHINE-linux-gnu.so
+usr/lib/python3.6/site-packages/msgpack/_unpacker.cpython-36m-MACHINE-linux-gnu.so
+usr/lib/python3.6/site-packages/msgpack/_version.py
+usr/lib/python3.6/site-packages/msgpack/exceptions.py
+usr/lib/python3.6/site-packages/msgpack/fallback.py
+usr/lib/python3.6/site-packages/msgpack_python-0.5.6-py3.6.egg-info
+usr/lib/python3.6/site-packages/msgpack_python-0.5.6-py3.6.egg-info/PKG-INFO
+usr/lib/python3.6/site-packages/msgpack_python-0.5.6-py3.6.egg-info/SOURCES.txt
+usr/lib/python3.6/site-packages/msgpack_python-0.5.6-py3.6.egg-info/dependency_links.txt
+usr/lib/python3.6/site-packages/msgpack_python-0.5.6-py3.6.egg-info/top_level.txt
diff --git a/lfs/python3-msgpack b/lfs/python3-msgpack
new file mode 100644
index 0000000..1d9280a
--- /dev/null
+++ b/lfs/python3-msgpack
@@ -0,0 +1,83 @@ 
+###############################################################################
+#                                                                             #
+# IPFire.org - A linux based firewall                                         #
+# Copyright (C) 2007-2018  IPFire Team  <info@ipfire.org>                     #
+#                                                                             #
+# This program is free software: you can redistribute it and/or modify        #
+# it under the terms of the GNU General Public License as published by        #
+# the Free Software Foundation, either version 3 of the License, or           #
+# (at your option) any later version.                                         #
+#                                                                             #
+# This program is distributed in the hope that it will be useful,             #
+# but WITHOUT ANY WARRANTY; without even the implied warranty of              #
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the               #
+# GNU General Public License for more details.                                #
+#                                                                             #
+# You should have received a copy of the GNU General Public License           #
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.       #
+#                                                                             #
+###############################################################################
+
+###############################################################################
+# Definitions
+###############################################################################
+
+include Config
+
+VER        = 0.5.6
+
+THISAPP    = msgpack-python-$(VER)
+DL_FILE    = $(THISAPP).tar.gz
+DL_FROM    = $(URL_IPFIRE)
+DIR_APP    = $(DIR_SRC)/$(THISAPP)
+TARGET     = $(DIR_INFO)/$(THISAPP)
+PROG       = python3-msgpack
+PAK_VER    = 1
+
+DEPS       = "python3"
+
+###############################################################################
+# Top-level Rules
+###############################################################################
+
+objects = $(DL_FILE)
+
+$(DL_FILE) = $(DL_FROM)/$(DL_FILE)
+
+$(DL_FILE)_MD5 = 6d644c06a87a5a111bbbf5b34b4be440
+
+install : $(TARGET)
+
+check : $(patsubst %,$(DIR_CHK)/%,$(objects))
+
+download :$(patsubst %,$(DIR_DL)/%,$(objects))
+
+md5 : $(subst %,%_MD5,$(objects))
+
+dist: 
+	@$(PAK)
+
+###############################################################################
+# Downloading, checking, md5sum
+###############################################################################
+
+$(patsubst %,$(DIR_CHK)/%,$(objects)) :
+	@$(CHECK)
+
+$(patsubst %,$(DIR_DL)/%,$(objects)) :
+	@$(LOAD)
+
+$(subst %,%_MD5,$(objects)) :
+	@$(MD5)
+
+###############################################################################
+# Installation Details
+###############################################################################
+
+$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
+	@$(PREBUILD)
+	@rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar zxf $(DIR_DL)/$(DL_FILE)
+	cd $(DIR_APP) && python3 setup.py build
+	cd $(DIR_APP) && python3 setup.py install --root=/
+	@rm -rf $(DIR_APP)
+	@$(POSTBUILD)
diff --git a/make.sh b/make.sh
index 9eb4fbf..68882fc 100755
--- a/make.sh
+++ b/make.sh
@@ -1513,6 +1513,7 @@  buildipfire() {
   lfsmake2 python3-pyasn1
   lfsmake2 python3-botocore
   lfsmake2 python3-llfuse
+  lfsmake2 python3-msgpack
   lfsmake2 aws-cli
   lfsmake2 transmission
   lfsmake2 dpfhack