[v2,1/5] ports: Change ports settings file to /etc/network/${port}/settings
| Message ID | 1497543533-5925-1-git-send-email-jonatan.schlag@ipfire.org |
|---|---|
| State | Dropped |
| Headers |
Return-Path: <development-bounces@lists.ipfire.org>
Received: from mail01.ipfire.org (unknown [172.28.1.200])
by web02.ipfire.org (Postfix) with ESMTP id 152BD61C93
for <patchwork@ipfire.org>; Thu, 15 Jun 2017 18:19:24 +0200 (CEST)
Received: from mail01.ipfire.org (localhost [IPv6:::1])
by mail01.ipfire.org (Postfix) with ESMTP id 1B1062873;
Thu, 15 Jun 2017 18:19:22 +0200 (CEST)
Received: from ipfire.localdomain (unknown [46.183.103.8])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits))
(No client certificate requested)
by mail01.ipfire.org (Postfix) with ESMTPSA id B0D242869;
Thu, 15 Jun 2017 18:19:06 +0200 (CEST)
From: Jonatan Schlag <jonatan.schlag@ipfire.org>
To: development@lists.ipfire.org,
network@lists.ipfire.org
Subject: [PATCH v2 1/5] ports: Change ports settings file to
/etc/network/${port}/settings
Date: Thu, 15 Jun 2017 18:18:49 +0200
Message-Id: <1497543533-5925-1-git-send-email-jonatan.schlag@ipfire.org>
X-Mailer: git-send-email 2.6.3
X-BeenThere: development@lists.ipfire.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: IPFire development talk <development.lists.ipfire.org>
List-Unsubscribe: <http://lists.ipfire.org/mailman/options/development>,
<mailto:development-request@lists.ipfire.org?subject=unsubscribe>
List-Archive: <http://lists.ipfire.org/pipermail/development/>
List-Post: <mailto:development@lists.ipfire.org>
List-Help: <mailto:development-request@lists.ipfire.org?subject=help>
List-Subscribe: <http://lists.ipfire.org/mailman/listinfo/development>,
<mailto:development-request@lists.ipfire.org?subject=subscribe>
Errors-To: development-bounces@lists.ipfire.org
Sender: "Development" <development-bounces@lists.ipfire.org>
|
Message
Jonatan Schlag
16 Jun 2017, 2:18 a.m. UTC
The configuration of a port was stored in a file called:
/etc/network/${port}
This is bad because it is very hard to add further information
which belong primary not to the configuration to this file.
So we change the settings file to /etc/network/${port}/settings like for the zones.
This make it possible to store other configurations like the color in other files in the directory
/etc/network/${port}.
A workaround to move the config file into the new directory scheme is:
port=p1 && mv /etc/network/ports/${port} /etc/network/ports/${port}-save \
&& mkdir -p /etc/network/ports/${port} \
&& mv /etc/network/ports/${port}-save /etc/network/ports/${port}/settings
where port is the name of the port like p1 or p0.
Signed-off-by: Jonatan Schlag <jonatan.schlag@ipfire.org>
---
src/functions/functions.ports | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)