[1/2] ddns: Import patch for schokokeks.org support.
Message ID | 1475225814-5754-1-git-send-email-stefan.schantl@ipfire.org |
---|---|
State | Accepted |
Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (hedwig.ipfire.org [172.28.1.200]) by web02.ipfire.org (Postfix) with ESMTP id D959261E79 for <patchwork@ipfire.org>; Fri, 30 Sep 2016 10:56:40 +0200 (CEST) Received: from mail01.ipfire.org (localhost [IPv6:::1]) by mail01.ipfire.org (Postfix) with ESMTP id 124D21B32; Fri, 30 Sep 2016 10:56:37 +0200 (CEST) Received: from tuxedo.stevee (212095007240.public.telering.at [212.95.7.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id B1D18195A; Fri, 30 Sep 2016 10:56:31 +0200 (CEST) From: Stefan Schantl <stefan.schantl@ipfire.org> To: development@lists.ipfire.org Subject: [PATCH 1/2] ddns: Import patch for schokokeks.org support. Date: Fri, 30 Sep 2016 10:56:53 +0200 Message-Id: <1475225814-5754-1-git-send-email-stefan.schantl@ipfire.org> X-Mailer: git-send-email 2.7.4 X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> List-Unsubscribe: <http://lists.ipfire.org/mailman/options/development>, <mailto:development-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/development/> List-Post: <mailto:development@lists.ipfire.org> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Subscribe: <http://lists.ipfire.org/mailman/listinfo/development>, <mailto:development-request@lists.ipfire.org?subject=subscribe> Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org> |
Message
Stefan Schantl
Sept. 30, 2016, 6:56 p.m. UTC
Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
---
lfs/ddns | 2 +
.../ddns-0001-New-provider-Schokokeks.org.patch | 47 ++++++++++++++++++++++
2 files changed, 49 insertions(+)
create mode 100644 src/patches/ddns-0001-New-provider-Schokokeks.org.patch
Comments
Hi, I did not see this patch going through the normal mailing list process. However, I have a comment that I will post here instead. On Fri, 2016-09-30 at 10:56 +0200, Stefan Schantl wrote: > Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org> > --- > lfs/ddns | 2 + > .../ddns-0001-New-provider-Schokokeks.org.patch | 47 > ++++++++++++++++++++++ > 2 files changed, 49 insertions(+) > create mode 100644 src/patches/ddns-0001-New-provider-Schokokeks.org.patch > > diff --git a/lfs/ddns b/lfs/ddns > index 422f8e3..90c70c6 100644 > --- a/lfs/ddns > +++ b/lfs/ddns > @@ -71,6 +71,8 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) > @$(PREBUILD) > @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_FILE) > > + cd $(DIR_APP) && patch -Np1 -i $(DIR_SRC)/src/patches/ddns-0001-New- > provider-Schokokeks.org.patch > + > cd $(DIR_APP) && [ -x "configure" ] || sh ./autogen.sh > cd $(DIR_APP) && ./configure \ > --prefix=/usr \ > diff --git a/src/patches/ddns-0001-New-provider-Schokokeks.org.patch > b/src/patches/ddns-0001-New-provider-Schokokeks.org.patch > new file mode 100644 > index 0000000..be123a5 > --- /dev/null > +++ b/src/patches/ddns-0001-New-provider-Schokokeks.org.patch > @@ -0,0 +1,47 @@ > +From 521c9d90f4e879ef3d9e1590f29e27990011ae46 Mon Sep 17 00:00:00 2001 > +From: Steffen Peters <sauron99@gmx.de> > +Date: Mon, 4 Jul 2016 22:14:10 +0200 > +Subject: [PATCH 185/185] New provider: Schokokeks.org > + > +Signed-off-by: Steffen Peters <sauron99@gmx.de> > +Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org> > +--- > + README | 1 + > + src/ddns/providers.py | 12 ++++++++++++ > + 2 files changed, 13 insertions(+) > + > +diff --git a/README b/README > +index d8027a4..cedbf21 100644 > +--- a/README > ++++ b/README > +@@ -75,6 +75,7 @@ SUPPORTED PROVIDERS: > + opendns.com > + ovh.com > + regfish.com > ++ schokokeks.org > + selfhost.de > + spdns.org > + strato.com > +diff --git a/src/ddns/providers.py b/src/ddns/providers.py > +index 6b25cb6..c482dad 100644 > +--- a/src/ddns/providers.py > ++++ b/src/ddns/providers.py > +@@ -1687,3 +1687,15 @@ class DDNSProviderZZZZ(DDNSProvider): > + > + # If we got here, some other update error happened. > + raise DDNSUpdateError > ++ > ++class DDNSProviderSchokokeksDNS(DDNSProtocolDynDNS2, DDNSProvider): > ++ handle = "schokokeks.org" > ++ name = "Schokokeks" > ++ website = "http://www.schokokeks.org/" > ++ protocols = ("ipv4",) > ++ > ++ # Information about the format of the request is to be found > ++ # https://wiki.schokokeks.org/DynDNS > ++ > ++ url = "https://dyndns.schokokeks.org/nic/update?myip=<ipaddr>;" > ++ This URL is clearly malformed and therefore the patch should not have been accepted. <ipaddr> is just a placeholder here and luckily everything after the ? is stripped off and replaced by the actual arguments. But that is still stuff that I do not want to see here. Best, -Michael > +-- > +2.7.4 > +