mbox

BUG11177: pppoe password not required anymore

Message ID 1473316618-18264-1-git-send-email-alexander.marx@ipfire.org
State Accepted
Commit 3364c93e37c65ed8544066ed55afe1941b2b6f8d
Headers

Message

Alexander Marx Sept. 8, 2016, 4:36 p.m. UTC 
  fixes: #11177

There are providers which do not use passwords anymore.
For this reason the password field is no longer mandatory.

Signed-off-by: Alexander Marx <alexander.marx@ipfire.org>
---
 html/cgi-bin/pppsetup.cgi | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

Comments

Michael Tremer Sept. 8, 2016, 9:59 p.m. UTC | #1 
Thanks. That was quick.

On Thu, 2016-09-08 at 08:36 +0200, Alexander Marx wrote:
> fixes: #11177
> 
> There are providers which do not use passwords anymore.
> For this reason the password field is no longer mandatory.
> 
> Signed-off-by: Alexander Marx <alexander.marx@ipfire.org>
> ---
>  html/cgi-bin/pppsetup.cgi | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/html/cgi-bin/pppsetup.cgi b/html/cgi-bin/pppsetup.cgi
> index 36d0ced..4b45ee5 100644
> --- a/html/cgi-bin/pppsetup.cgi
> +++ b/html/cgi-bin/pppsetup.cgi
> @@ -103,10 +103,7 @@ elsif ($pppsettings{'ACTION'} eq $Lang::tr{'save'})
>                  if ($pppsettings{'USERNAME'} eq '') {
>                          $errormessage = $Lang::tr{'username not set'};
>                          goto ERROR; }
> -                if ($pppsettings{'PASSWORD'} eq '') {
> -                        $errormessage = $Lang::tr{'password not set'};
> -                        goto ERROR; }
> -        }
> +		}
>  
>          if ($pppsettings{'TIMEOUT'} eq '') {
>                  $errormessage = $Lang::tr{'idle timeout not set'};
> @@ -927,7 +924,7 @@ print <<END
>  <tr>
>          <td width='25%'>$Lang::tr{'username'}&nbsp;<img src='/blob.gif'
> alt='*' /></td>
>          <td width='25%'><input type='text' name='USERNAME'
> value='$pppsettings{'USERNAME'}' /></td>
> -        <td width='25%'>$Lang::tr{'password'}&nbsp;<img src='/blob.gif'
> alt='*' /></td>
> +        <td width='25%'>$Lang::tr{'password'}&nbsp;</td>
>          <td width='25%'><input type='password' name='PASSWORD'
> value='$pppsettings{'PASSWORD'}' /></td>
>  </tr>
>  <tr>