libtirpc: change from package to common v2

Message ID	1468219053-28294-1-git-send-email-marcel.lorenz@ipfire.org
State	Dropped
Headers	From: Marcel Lorenz <marcel.lorenz@ipfire.org> To: development@lists.ipfire.org Subject: [PATCH] libtirpc: change from package to common v2 Date: Mon, 11 Jul 2016 08:37:33 +0200 Message-Id: <1468219053-28294-1-git-send-email-marcel.lorenz@ipfire.org> Precedence: list Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org>

Message ID

1468219053-28294-1-git-send-email-marcel.lorenz@ipfire.org

State

Dropped

Headers

From: Marcel Lorenz <marcel.lorenz@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH] libtirpc: change from package to common v2
Date: Mon, 11 Jul 2016 08:37:33 +0200
Message-Id: <1468219053-28294-1-git-send-email-marcel.lorenz@ipfire.org>
Precedence: list
Errors-To: development-bounces@lists.ipfire.org
Sender: "Development" <development-bounces@lists.ipfire.org>

Message

Marcel Lorenz July 11, 2016, 4:37 p.m. UTC

  The dependency from rpcbind package are removed

Signed-off-by: Marcel Lorenz <marcel.lorenz@ipfire.org>
---
 config/rootfiles/{packages => common}/libtirpc | 0
 lfs/libtirpc                                   | 6 ------
 lfs/rpcbind                                    | 2 +-
 3 files changed, 1 insertion(+), 7 deletions(-)
 rename config/rootfiles/{packages => common}/libtirpc (100%)

Comments

Jonatan Schlag July 14, 2016, 7:43 p.m. UTC | #1

Am Mo, 11. Jul, 2016 um 8:37 schrieb Marcel Lorenz 
<marcel.lorenz@ipfire.org>:
> The dependency from rpcbind package are removed
> 
> Signed-off-by: Marcel Lorenz <marcel.lorenz@ipfire.org>
> ---
>  config/rootfiles/{packages => common}/libtirpc | 0
>  lfs/libtirpc                                   | 6 ------
>  lfs/rpcbind                                    | 2 +-
>  3 files changed, 1 insertion(+), 7 deletions(-)
>  rename config/rootfiles/{packages => common}/libtirpc (100%)
> 
> diff --git a/config/rootfiles/packages/libtirpc 
> b/config/rootfiles/common/libtirpc
> similarity index 100%
> rename from config/rootfiles/packages/libtirpc
> rename to config/rootfiles/common/libtirpc
> diff --git a/lfs/libtirpc b/lfs/libtirpc
> index 382d7e5..c37fa9b 100644
> --- a/lfs/libtirpc
> +++ b/lfs/libtirpc
> @@ -31,10 +31,7 @@ DL_FILE    = $(THISAPP).tar.bz2
>  DL_FROM    = $(URL_IPFIRE)
>  DIR_APP    = $(DIR_SRC)/$(THISAPP)
>  TARGET     = $(DIR_INFO)/$(THISAPP)
> -PROG       = libtirpc
> -PAK_VER    = 1
> 
> -DEPS       = ""
> 
>  
> ###############################################################################
>  # Top-level Rules
> @@ -54,9 +51,6 @@ download :$(patsubst %,$(DIR_DL)/%,$(objects))
> 
>  md5 : $(subst %,%_MD5,$(objects))
> 
> -dist:
> -	@$(PAK)
> -
>  
> ###############################################################################
>  # Downloading, checking, md5sum
>  
> ###############################################################################
> diff --git a/lfs/rpcbind b/lfs/rpcbind
> index d9e2885..99fccbc 100644
> --- a/lfs/rpcbind
> +++ b/lfs/rpcbind
> @@ -34,7 +34,7 @@ TARGET     = $(DIR_INFO)/$(THISAPP)
>  PROG       = rpcbind
>  PAK_VER    = 1
> 
> -DEPS       = "libtirpc"
> +DEPS       = ""
> 
>  
> ###############################################################################
>  # Top-level Rules
> --
> 1.9.1

Reviewed-by: Jonatan Schlag <jonatan.schlag@ipfire.org>

Michael Tremer July 14, 2016, 7:49 p.m. UTC | #2

Why does this package have to be in the core system?

On Thu, 2016-07-14 at 11:43 +0200, Jonatan Schlag wrote:
> Am Mo, 11. Jul, 2016 um 8:37 schrieb Marcel Lorenz <marcel.lorenz@ipfire.org>:
> > The dependency from rpcbind package are removed
> > 
> > Signed-off-by: Marcel Lorenz <marcel.lorenz@ipfire.org>
> > ---
> >  config/rootfiles/{packages => common}/libtirpc | 0
> >  lfs/libtirpc                                   | 6 ------
> >  lfs/rpcbind                                    | 2 +-
> >  3 files changed, 1 insertion(+), 7 deletions(-)
> >  rename config/rootfiles/{packages => common}/libtirpc (100%)
> > 
> > diff --git a/config/rootfiles/packages/libtirpc
> > b/config/rootfiles/common/libtirpc
> > similarity index 100%
> > rename from config/rootfiles/packages/libtirpc
> > rename to config/rootfiles/common/libtirpc
> > diff --git a/lfs/libtirpc b/lfs/libtirpc
> > index 382d7e5..c37fa9b 100644
> > --- a/lfs/libtirpc
> > +++ b/lfs/libtirpc
> > @@ -31,10 +31,7 @@ DL_FILE    = $(THISAPP).tar.bz2
> >  DL_FROM    = $(URL_IPFIRE)
> >  DIR_APP    = $(DIR_SRC)/$(THISAPP)
> >  TARGET     = $(DIR_INFO)/$(THISAPP)
> > -PROG       = libtirpc
> > -PAK_VER    = 1
> >  
> > -DEPS       = ""
> >  
> >  ###########################################################################
> > ####
> >  # Top-level Rules
> > @@ -54,9 +51,6 @@ download :$(patsubst %,$(DIR_DL)/%,$(objects))
> >  
> >  md5 : $(subst %,%_MD5,$(objects))
> >  
> > -dist:
> > -	@$(PAK)
> > -
> >  ###########################################################################
> > ####
> >  # Downloading, checking, md5sum
> >  ###########################################################################
> > ####
> > diff --git a/lfs/rpcbind b/lfs/rpcbind
> > index d9e2885..99fccbc 100644
> > --- a/lfs/rpcbind
> > +++ b/lfs/rpcbind
> > @@ -34,7 +34,7 @@ TARGET     = $(DIR_INFO)/$(THISAPP)
> >  PROG       = rpcbind
> >  PAK_VER    = 1
> >  
> > -DEPS       = "libtirpc"
> > +DEPS       = ""
> >  
> >  ###########################################################################
> > ####
> >  # Top-level Rules
> > -- 
> > 1.9.1
> Reviewed-by: Jonatan Schlag <jonatan.schlag@ipfire.org>

Marcel Lorenz July 16, 2016, 2:51 a.m. UTC | #3

Am 2016-07-14 11:49, schrieb Michael Tremer:
> Why does this package have to be in the core system?
> 
Hi Michael,
Hi Jonatan,

libtirpc is a hard dependency for new lsof package
and losf is in core system. Without lsof wont build.

The CFGL="-L./lib -ltirpc" in losof package
instruct the libtirpc libraries location to make command

Best,
Marcel

> On Thu, 2016-07-14 at 11:43 +0200, Jonatan Schlag wrote:
>> Am Mo, 11. Jul, 2016 um 8:37 schrieb Marcel Lorenz 
>> <marcel.lorenz@ipfire.org>:
>> > The dependency from rpcbind package are removed
>> >
>> > Signed-off-by: Marcel Lorenz <marcel.lorenz@ipfire.org>
>> > ---
>> >  config/rootfiles/{packages => common}/libtirpc | 0
>> >  lfs/libtirpc                                   | 6 ------
>> >  lfs/rpcbind                                    | 2 +-
>> >  3 files changed, 1 insertion(+), 7 deletions(-)
>> >  rename config/rootfiles/{packages => common}/libtirpc (100%)
>> >
>> > diff --git a/config/rootfiles/packages/libtirpc
>> > b/config/rootfiles/common/libtirpc
>> > similarity index 100%
>> > rename from config/rootfiles/packages/libtirpc
>> > rename to config/rootfiles/common/libtirpc
>> > diff --git a/lfs/libtirpc b/lfs/libtirpc
>> > index 382d7e5..c37fa9b 100644
>> > --- a/lfs/libtirpc
>> > +++ b/lfs/libtirpc
>> > @@ -31,10 +31,7 @@ DL_FILE    = $(THISAPP).tar.bz2
>> >  DL_FROM    = $(URL_IPFIRE)
>> >  DIR_APP    = $(DIR_SRC)/$(THISAPP)
>> >  TARGET     = $(DIR_INFO)/$(THISAPP)
>> > -PROG       = libtirpc
>> > -PAK_VER    = 1
>> >  
>> > -DEPS       = ""
>> >  
>> >  ###########################################################################
>> > ####
>> >  # Top-level Rules
>> > @@ -54,9 +51,6 @@ download :$(patsubst %,$(DIR_DL)/%,$(objects))
>> >  
>> >  md5 : $(subst %,%_MD5,$(objects))
>> >  
>> > -dist:
>> > -	@$(PAK)
>> > -
>> >  ###########################################################################
>> > ####
>> >  # Downloading, checking, md5sum
>> >  ###########################################################################
>> > ####
>> > diff --git a/lfs/rpcbind b/lfs/rpcbind
>> > index d9e2885..99fccbc 100644
>> > --- a/lfs/rpcbind
>> > +++ b/lfs/rpcbind
>> > @@ -34,7 +34,7 @@ TARGET     = $(DIR_INFO)/$(THISAPP)
>> >  PROG       = rpcbind
>> >  PAK_VER    = 1
>> >  
>> > -DEPS       = "libtirpc"
>> > +DEPS       = ""
>> >  
>> >  ###########################################################################
>> > ####
>> >  # Top-level Rules
>> > -- 
>> > 1.9.1
>> Reviewed-by: Jonatan Schlag <jonatan.schlag@ipfire.org>