[PATCHv2] Zoneedit: Provide better error message on error 702 responses.
Message ID | 1461933302-24640-1-git-send-email-stefan.schantl@ipfire.org |
---|---|
State | Accepted |
Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (hedwig.ipfire.org [172.28.1.200]) by web02.ipfire.org (Postfix) with ESMTP id AB5E162836 for <patchwork@ipfire.org>; Fri, 29 Apr 2016 14:35:06 +0200 (CEST) Received: from mail01.ipfire.org (localhost [IPv6:::1]) by mail01.ipfire.org (Postfix) with ESMTP id E9A7A15B0; Fri, 29 Apr 2016 14:35:05 +0200 (CEST) Received: from tuxedo.stevee (178.115.129.197.wireless.dyn.drei.com [178.115.129.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4897EC2; Fri, 29 Apr 2016 14:35:02 +0200 (CEST) From: Stefan Schantl <stefan.schantl@ipfire.org> To: development@lists.ipfire.org Subject: [PATCHv2] Zoneedit: Provide better error message on error 702 responses. Date: Fri, 29 Apr 2016 14:35:02 +0200 Message-Id: <1461933302-24640-1-git-send-email-stefan.schantl@ipfire.org> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1461933160.23498.2.camel@ipfire.org> References: <1461933160.23498.2.camel@ipfire.org> X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> List-Unsubscribe: <http://lists.ipfire.org/mailman/options/development>, <mailto:development-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/development/> List-Post: <mailto:development@lists.ipfire.org> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Subscribe: <http://lists.ipfire.org/mailman/listinfo/development>, <mailto:development-request@lists.ipfire.org?subject=subscribe> Cc: ddns@lists.ipfire.org Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org> |
Message
Stefan Schantl
April 29, 2016, 10:35 p.m. UTC
A returned error code 702 when using Zoneedit as provider now raise
a request error with an corresponding message instead of a simple
InternalServerError exception.
This will help to clarify and debug update problems.
Fixes #11042.
Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
---
src/ddns/providers.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Reviewed-by: Michael Tremer <michael.tremer@ipfire.org> ACK On Fri, 2016-04-29 at 14:35 +0200, Stefan Schantl wrote: > A returned error code 702 when using Zoneedit as provider now raise > a request error with an corresponding message instead of a simple > InternalServerError exception. > > This will help to clarify and debug update problems. > > Fixes #11042. > > Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org> > --- > src/ddns/providers.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/ddns/providers.py b/src/ddns/providers.py > index 3845193..c653aa5 100644 > --- a/src/ddns/providers.py > +++ b/src/ddns/providers.py > @@ -1576,7 +1576,7 @@ class DDNSProviderZoneedit(DDNSProvider): > elif output.startswith("<ERROR CODE=\"704\""): > raise DDNSRequestError(_("No valid FQDN was > given.")) > elif output.startswith("<ERROR CODE=\"702\""): > - raise DDNSInternalServerError > + raise DDNSRequestError(_("Too frequent update > requests have been sent.")) > > # If we got here, some other update error happened. > raise DDNSUpdateError